* [andriy.shevchenko@linux.intel.com: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support]
@ 2018-08-29 15:09 Andy Shevchenko
2018-08-29 15:15 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2018-08-29 15:09 UTC (permalink / raw)
To: Mark Brown
Cc: linux-spi, devicetree, linux-kernel, Thomas Petazzoni,
Allan Nielsen, Alexandre Belloni
----- Forwarded message from Andy Shevchenko <andriy.shevchenko@linux.intel.com> -----
Date: Wed, 29 Aug 2018 18:08:31 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support
User-Agent: Mutt/1.10.1 (2018-07-13)
On Wed, Aug 29, 2018 at 02:45:48PM +0200, Alexandre Belloni wrote:
> Unfortunately, the Jaguar2 CPU_SYSTEM_CTRL register set has a different
> layout than the Ocelot one. Handle that while keeping most of the code
> common.
> -#define OCELOT_IF_SI_OWNER_MASK GENMASK(5, 4)
> + 0x3 << if_si_owner_offset,
Perhaps,
#define MSCC_IF_SI_OWNER_MASK GENMASK(1, 0)
...
MSCC_IF_SI_OWNER_MASK << if_si_owner_offset,
--
With Best Regards,
Andy Shevchenko
----- End forwarded message -----
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [andriy.shevchenko@linux.intel.com: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support]
2018-08-29 15:09 [andriy.shevchenko@linux.intel.com: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support] Andy Shevchenko
@ 2018-08-29 15:15 ` Mark Brown
2018-08-29 16:52 ` Andy Shevchenko
2018-08-29 18:02 ` Alexandre Belloni
0 siblings, 2 replies; 5+ messages in thread
From: Mark Brown @ 2018-08-29 15:15 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-spi, devicetree, linux-kernel, Thomas Petazzoni,
Allan Nielsen, Alexandre Belloni
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
On Wed, Aug 29, 2018 at 06:09:55PM +0300, Andy Shevchenko wrote:
> ----- Forwarded message from Andy Shevchenko <andriy.shevchenko@linux.intel.com> -----
>
> Date: Wed, 29 Aug 2018 18:08:31 +0300
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> To: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Subject: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support
> User-Agent: Mutt/1.10.1 (2018-07-13)
>
> On Wed, Aug 29, 2018 at 02:45:48PM +0200, Alexandre Belloni wrote:
> > Unfortunately, the Jaguar2 CPU_SYSTEM_CTRL register set has a different
> > layout than the Ocelot one. Handle that while keeping most of the code
> > common.
>
> > -#define OCELOT_IF_SI_OWNER_MASK GENMASK(5, 4)
>
> > + 0x3 << if_si_owner_offset,
>
> Perhaps,
>
> #define MSCC_IF_SI_OWNER_MASK GENMASK(1, 0)
Oops, sorry - that seems to have been eaten somewhere. :(
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [andriy.shevchenko@linux.intel.com: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support]
2018-08-29 15:15 ` Mark Brown
@ 2018-08-29 16:52 ` Andy Shevchenko
2018-08-29 18:02 ` Alexandre Belloni
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2018-08-29 16:52 UTC (permalink / raw)
To: Mark Brown
Cc: Andy Shevchenko, linux-spi, devicetree,
Linux Kernel Mailing List, Thomas Petazzoni, allan.nielsen,
Alexandre Belloni
On Wed, Aug 29, 2018 at 6:16 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Aug 29, 2018 at 06:09:55PM +0300, Andy Shevchenko wrote:
> > ----- Forwarded message from Andy Shevchenko <andriy.shevchenko@linux.intel.com> -----
> >
> > Date: Wed, 29 Aug 2018 18:08:31 +0300
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > To: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Subject: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support
> > User-Agent: Mutt/1.10.1 (2018-07-13)
> >
> > On Wed, Aug 29, 2018 at 02:45:48PM +0200, Alexandre Belloni wrote:
> > > Unfortunately, the Jaguar2 CPU_SYSTEM_CTRL register set has a different
> > > layout than the Ocelot one. Handle that while keeping most of the code
> > > common.
> >
> > > -#define OCELOT_IF_SI_OWNER_MASK GENMASK(5, 4)
> >
> > > + 0x3 << if_si_owner_offset,
> >
> > Perhaps,
> >
> > #define MSCC_IF_SI_OWNER_MASK GENMASK(1, 0)
>
> Oops, sorry - that seems to have been eaten somewhere. :(
Nothing to sorry about, I'm in a process on move to mutt, so, I
mispushed 'r' (Reply) instead of 'g' (Group Reply).
I just forwarded the first one.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [andriy.shevchenko@linux.intel.com: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support]
2018-08-29 15:15 ` Mark Brown
2018-08-29 16:52 ` Andy Shevchenko
@ 2018-08-29 18:02 ` Alexandre Belloni
2018-08-30 10:50 ` Mark Brown
1 sibling, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2018-08-29 18:02 UTC (permalink / raw)
To: Mark Brown
Cc: Andy Shevchenko, linux-spi, devicetree, linux-kernel,
Thomas Petazzoni, Allan Nielsen
Mark,
On 29/08/2018 16:15:02+0100, Mark Brown wrote:
> On Wed, Aug 29, 2018 at 06:09:55PM +0300, Andy Shevchenko wrote:
> > ----- Forwarded message from Andy Shevchenko <andriy.shevchenko@linux.intel.com> -----
> >
> > Date: Wed, 29 Aug 2018 18:08:31 +0300
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > To: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > Subject: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support
> > User-Agent: Mutt/1.10.1 (2018-07-13)
> >
> > On Wed, Aug 29, 2018 at 02:45:48PM +0200, Alexandre Belloni wrote:
> > > Unfortunately, the Jaguar2 CPU_SYSTEM_CTRL register set has a different
> > > layout than the Ocelot one. Handle that while keeping most of the code
> > > common.
> >
> > > -#define OCELOT_IF_SI_OWNER_MASK GENMASK(5, 4)
> >
> > > + 0x3 << if_si_owner_offset,
> >
> > Perhaps,
> >
> > #define MSCC_IF_SI_OWNER_MASK GENMASK(1, 0)
>
> Oops, sorry - that seems to have been eaten somewhere. :(
Do you want me to send a new version or a patch that you could squash in
the second one?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [andriy.shevchenko@linux.intel.com: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support]
2018-08-29 18:02 ` Alexandre Belloni
@ 2018-08-30 10:50 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2018-08-30 10:50 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Andy Shevchenko, linux-spi, devicetree, linux-kernel,
Thomas Petazzoni, Allan Nielsen
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
On Wed, Aug 29, 2018 at 08:02:42PM +0200, Alexandre Belloni wrote:
> Do you want me to send a new version or a patch that you could squash in
> the second one?
A followup would be best given that I applied it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-30 10:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29 15:09 [andriy.shevchenko@linux.intel.com: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support] Andy Shevchenko
2018-08-29 15:15 ` Mark Brown
2018-08-29 16:52 ` Andy Shevchenko
2018-08-29 18:02 ` Alexandre Belloni
2018-08-30 10:50 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).