* [PATCH] net: dsa: remove redundant null pointer check before put_device
@ 2018-09-16 13:45 zhong jiang
2018-09-17 15:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2018-09-16 13:45 UTC (permalink / raw)
To: davem, f.fainelli, andrew; +Cc: vivien.didelot, netdev, linux-kernel
put_device has taken the null pinter check into account. So it is
safe to remove the duplicated check before put_device.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
net/dsa/legacy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/dsa/legacy.c b/net/dsa/legacy.c
index 42a7b85..8aa92b0 100644
--- a/net/dsa/legacy.c
+++ b/net/dsa/legacy.c
@@ -392,8 +392,7 @@ static void dsa_of_free_platform_data(struct dsa_platform_data *pd)
}
/* Drop our reference to the MDIO bus device */
- if (pd->chip[i].host_dev)
- put_device(pd->chip[i].host_dev);
+ put_device(pd->chip[i].host_dev);
}
kfree(pd->chip);
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: dsa: remove redundant null pointer check before put_device
2018-09-16 13:45 [PATCH] net: dsa: remove redundant null pointer check before put_device zhong jiang
@ 2018-09-17 15:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-17 15:21 UTC (permalink / raw)
To: zhongjiang; +Cc: f.fainelli, andrew, vivien.didelot, netdev, linux-kernel
From: zhong jiang <zhongjiang@huawei.com>
Date: Sun, 16 Sep 2018 21:45:02 +0800
> put_device has taken the null pinter check into account. So it is
> safe to remove the duplicated check before put_device.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-17 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-16 13:45 [PATCH] net: dsa: remove redundant null pointer check before put_device zhong jiang
2018-09-17 15:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).