linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] video/fbdev/stifb: Fix spelling mistake in fall-through annotation
@ 2018-09-03 20:07 ` Gustavo A. R. Silva
  2018-09-26 16:52   ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-09-03 20:07 UTC (permalink / raw)
  To: James E.J. Bottomley, Helge Deller, Bartlomiej Zolnierkiewicz
  Cc: linux-parisc, dri-devel, linux-fbdev, linux-kernel, Gustavo A. R. Silva

Replace "fall though" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling
-Wimplicit-fallthrough

Addresses-Coverity-ID: 402013 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/video/fbdev/stifb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
index 045e8af..9e88e3f 100644
--- a/drivers/video/fbdev/stifb.c
+++ b/drivers/video/fbdev/stifb.c
@@ -1157,7 +1157,7 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
 			dev_name);
 		   goto out_err0;
 		}
-		/* fall though */
+		/* fall through */
 	case S9000_ID_ARTIST:
 	case S9000_ID_HCRX:
 	case S9000_ID_TIMBER:
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] video/fbdev/stifb: Fix spelling mistake in fall-through annotation
  2018-09-03 20:07 ` [PATCH] video/fbdev/stifb: Fix spelling mistake in fall-through annotation Gustavo A. R. Silva
@ 2018-09-26 16:52   ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-09-26 16:52 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: James E.J. Bottomley, Helge Deller, linux-parisc, dri-devel,
	linux-fbdev, linux-kernel


On 09/03/2018 10:07 PM, Gustavo A. R. Silva wrote:
> Replace "fall though" with a proper "fall through" annotation.
> 
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
> 
> Addresses-Coverity-ID: 402013 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Patch queued for 4.19, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-26 16:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20180903200806epcas2p1171387c9a1699140856911ce283f470c@epcas2p1.samsung.com>
2018-09-03 20:07 ` [PATCH] video/fbdev/stifb: Fix spelling mistake in fall-through annotation Gustavo A. R. Silva
2018-09-26 16:52   ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).