From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
support.opensource@diasemi.com
Subject: Re: [PATCH 2/2] usb: typec: fusb302: Resolve fixed power role contract setup
Date: Thu, 27 Sep 2018 13:54:01 +0300 [thread overview]
Message-ID: <20180927105401.GO11965@kuha.fi.intel.com> (raw)
In-Reply-To: <383410593681e2fed025a4b538ea0840ff370a9a.1537975081.git.Adam.Thomson.Opensource@diasemi.com>
On Wed, Sep 26, 2018 at 04:23:52PM +0100, Adam Thomson wrote:
> When the controller is configured for a fixed power role (Source
> only or Sink only), attach does not proceed within the TCPM state
> machine as there is no CC event generated by this driver to update
> the CC line status.
>
> To rectify this, when CC is configured as Source or Sink we now
> make use of the hardware's automatic fixed Source or Sink
> toggling mechanism, which detects attaches in the same way as for
> DRP toggling. In this way the result of toggling is handled in the
> same way by the 'fusb302_handle_togdone()' function, and CC events
> are generated as expected for TCPM allowing a contract to be
> established.
>
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index fd851d8..43b64d9 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -679,6 +679,7 @@ static int tcpm_set_cc(struct tcpc_dev *dev, enum typec_cc_status cc)
> int ret = 0;
> bool pull_up, pull_down;
> u8 rd_mda;
> + enum toggling_mode mode;
>
> mutex_lock(&chip->lock);
> switch (cc) {
> @@ -764,6 +765,29 @@ static int tcpm_set_cc(struct tcpc_dev *dev, enum typec_cc_status cc)
> chip->intr_comp_chng = false;
> }
> fusb302_log(chip, "cc := %s", typec_cc_status_name[cc]);
> +
> + /* Enable detection for fixed SNK or SRC only roles */
> + switch (cc) {
> + case TYPEC_CC_RD:
> + mode = TOGGLING_MODE_SNK;
> + break;
> + case TYPEC_CC_RP_DEF:
> + case TYPEC_CC_RP_1_5:
> + case TYPEC_CC_RP_3_0:
> + mode = TOGGLING_MODE_SRC;
> + break;
> + default:
> + mode = TOGGLING_MODE_OFF;
> + break;
> + }
> +
> + if (mode != TOGGLING_MODE_OFF) {
> + ret = fusb302_set_toggling(chip, mode);
> + if (ret < 0)
> + fusb302_log(chip,
> + "cannot set fixed role toggling mode, ret=%d",
> + ret);
> + }
> done:
> mutex_unlock(&chip->lock);
>
> --
> 1.9.1
--
heikki
prev parent reply other threads:[~2018-09-27 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 15:23 [PATCH 0/2] usb: typec: fusb302: Resolve fixed role power configuration Adam Thomson
2018-09-26 15:23 ` [PATCH 1/2] usb: typec: fusb302: Correct spelling mistake for toggling state Adam Thomson
2018-09-26 16:27 ` Guenter Roeck
2018-09-27 10:54 ` Heikki Krogerus
2018-09-26 15:23 ` [PATCH 2/2] usb: typec: fusb302: Resolve fixed power role contract setup Adam Thomson
2018-09-26 16:30 ` Guenter Roeck
2018-09-27 10:54 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927105401.GO11965@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).