From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
support.opensource@diasemi.com
Subject: Re: [PATCH 1/2] usb: typec: fusb302: Correct spelling mistake for toggling state
Date: Thu, 27 Sep 2018 13:54:43 +0300 [thread overview]
Message-ID: <20180927105443.GP11965@kuha.fi.intel.com> (raw)
In-Reply-To: <8ef602efbb7ee84ec86225ae4b9e1d138154e51b.1537975081.git.Adam.Thomson.Opensource@diasemi.com>
On Wed, Sep 26, 2018 at 04:23:51PM +0100, Adam Thomson wrote:
> There's a typo in the enum name of the 'OFF' state for toggling
> (TOGGLINE instead of TOGGLING). This commit resolves that trivial
> spelling inconsistency.
>
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 6e9370a..fd851d8 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -42,7 +42,7 @@
> #define T_BC_LVL_DEBOUNCE_DELAY_MS 30
>
> enum toggling_mode {
> - TOGGLINE_MODE_OFF,
> + TOGGLING_MODE_OFF,
> TOGGLING_MODE_DRP,
> TOGGLING_MODE_SNK,
> TOGGLING_MODE_SRC,
> @@ -594,7 +594,7 @@ static int fusb302_set_toggling(struct fusb302_chip *chip,
> chip->intr_comp_chng = false;
> /* configure toggling mode: none/snk/src/drp */
> switch (mode) {
> - case TOGGLINE_MODE_OFF:
> + case TOGGLING_MODE_OFF:
> ret = fusb302_i2c_mask_write(chip, FUSB_REG_CONTROL2,
> FUSB_REG_CONTROL2_MODE_MASK,
> FUSB_REG_CONTROL2_MODE_NONE);
> @@ -626,7 +626,7 @@ static int fusb302_set_toggling(struct fusb302_chip *chip,
> break;
> }
>
> - if (mode == TOGGLINE_MODE_OFF) {
> + if (mode == TOGGLING_MODE_OFF) {
> /* mask TOGDONE interrupt */
> ret = fusb302_i2c_set_bits(chip, FUSB_REG_MASKA,
> FUSB_REG_MASKA_TOGDONE);
> @@ -702,7 +702,7 @@ static int tcpm_set_cc(struct tcpc_dev *dev, enum typec_cc_status cc)
> ret = -EINVAL;
> goto done;
> }
> - ret = fusb302_set_toggling(chip, TOGGLINE_MODE_OFF);
> + ret = fusb302_set_toggling(chip, TOGGLING_MODE_OFF);
> if (ret < 0) {
> fusb302_log(chip, "cannot stop toggling, ret=%d", ret);
> goto done;
> @@ -1292,7 +1292,7 @@ static int fusb302_handle_togdone_snk(struct fusb302_chip *chip,
> tcpm_cc_change(chip->tcpm_port);
> }
> /* turn off toggling */
> - ret = fusb302_set_toggling(chip, TOGGLINE_MODE_OFF);
> + ret = fusb302_set_toggling(chip, TOGGLING_MODE_OFF);
> if (ret < 0) {
> fusb302_log(chip,
> "cannot set toggling mode off, ret=%d", ret);
> @@ -1388,7 +1388,7 @@ static int fusb302_handle_togdone_src(struct fusb302_chip *chip,
> tcpm_cc_change(chip->tcpm_port);
> }
> /* turn off toggling */
> - ret = fusb302_set_toggling(chip, TOGGLINE_MODE_OFF);
> + ret = fusb302_set_toggling(chip, TOGGLING_MODE_OFF);
> if (ret < 0) {
> fusb302_log(chip,
> "cannot set toggling mode off, ret=%d", ret);
> --
> 1.9.1
--
heikki
next prev parent reply other threads:[~2018-09-27 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 15:23 [PATCH 0/2] usb: typec: fusb302: Resolve fixed role power configuration Adam Thomson
2018-09-26 15:23 ` [PATCH 1/2] usb: typec: fusb302: Correct spelling mistake for toggling state Adam Thomson
2018-09-26 16:27 ` Guenter Roeck
2018-09-27 10:54 ` Heikki Krogerus [this message]
2018-09-26 15:23 ` [PATCH 2/2] usb: typec: fusb302: Resolve fixed power role contract setup Adam Thomson
2018-09-26 16:30 ` Guenter Roeck
2018-09-27 10:54 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927105443.GP11965@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).