From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] mfd: remove redundant 'default n' from Kconfig
Date: Wed, 10 Oct 2018 16:51:25 +0200 [thread overview]
Message-ID: <20181010145127eucas1p2fcd5b5f91fa3ac7f763a51c0d5e8b3cb~cRtzjSAO11833118331eucas1p2t@eucas1p2.samsung.com> (raw)
In-Reply-To: CGME20181010145127eucas1p2fcd5b5f91fa3ac7f763a51c0d5e8b3cb@eucas1p2.samsung.com
'default n' is the default value for any bool or tristate Kconfig
setting so there is no need to write it explicitly.
Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
is not set' for visible symbols") the Kconfig behavior is the same
regardless of 'default n' being present or not:
...
One side effect of (and the main motivation for) this change is making
the following two definitions behave exactly the same:
config FOO
bool
config FOO
bool
default n
With this change, neither of these will generate a
'# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
That might make it clearer to people that a bare 'default n' is
redundant.
...
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/mfd/Kconfig | 6 ------
1 file changed, 6 deletions(-)
Index: b/drivers/mfd/Kconfig
===================================================================
--- a/drivers/mfd/Kconfig 2018-10-09 15:58:40.547122978 +0200
+++ b/drivers/mfd/Kconfig 2018-10-10 16:49:37.575915230 +0200
@@ -8,7 +8,6 @@ menu "Multifunction device drivers"
config MFD_CORE
tristate
select IRQ_DOMAIN
- default n
config MFD_CS5535
tristate "AMD CS5535 and CS5536 southbridge core functions"
@@ -870,7 +869,6 @@ config MFD_VIPERBOARD
tristate "Nano River Technologies Viperboard"
select MFD_CORE
depends on USB
- default n
help
Say yes here if you want support for Nano River Technologies
Viperboard.
@@ -1575,7 +1573,6 @@ config MFD_TWL4030_AUDIO
bool "TI TWL4030 Audio"
depends on TWL4030_CORE
select MFD_CORE
- default n
config TWL6040_CORE
bool "TI TWL6040 audio codec"
@@ -1583,7 +1580,6 @@ config TWL6040_CORE
select MFD_CORE
select REGMAP_I2C
select REGMAP_IRQ
- default n
help
Say yes here if you want support for Texas Instruments TWL6040 audio
codec.
@@ -1605,7 +1601,6 @@ config MFD_WL1273_CORE
tristate "TI WL1273 FM radio"
depends on I2C
select MFD_CORE
- default n
help
This is the core driver for the TI WL1273 FM radio. This MFD
driver connects the radio-wl1273 V4L2 module and the wl1273
@@ -1649,7 +1644,6 @@ config MFD_TC3589X
config MFD_TMIO
bool
- default n
config MFD_T7L66XB
bool "Toshiba T7L66XB"
next parent reply other threads:[~2018-10-10 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181010145127eucas1p2fcd5b5f91fa3ac7f763a51c0d5e8b3cb@eucas1p2.samsung.com>
2018-10-10 14:51 ` Bartlomiej Zolnierkiewicz [this message]
2018-10-11 5:48 ` [PATCH] mfd: remove redundant 'default n' from Kconfig Lee Jones
2018-10-12 12:08 ` Bartlomiej Zolnierkiewicz
2018-10-25 6:57 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20181010145127eucas1p2fcd5b5f91fa3ac7f763a51c0d5e8b3cb~cRtzjSAO11833118331eucas1p2t@eucas1p2.samsung.com' \
--to=b.zolnierkie@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).