From: Lee Jones <lee.jones@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: remove redundant 'default n' from Kconfig
Date: Thu, 25 Oct 2018 07:57:59 +0100 [thread overview]
Message-ID: <20181025065759.GE4939@dell> (raw)
In-Reply-To: <20181012120851eucas1p27177441e71df4665a87d0a5d87a61796~c2yaPCm9h0943209432eucas1p2Q@eucas1p2.samsung.com>
On Fri, 12 Oct 2018, Bartlomiej Zolnierkiewicz wrote:
> On 10/11/2018 07:48 AM, Lee Jones wrote:
> > On Wed, 10 Oct 2018, Bartlomiej Zolnierkiewicz wrote:
> >
> >> 'default n' is the default value for any bool or tristate Kconfig
> >> setting so there is no need to write it explicitly.
> >>
> >> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> >> is not set' for visible symbols") the Kconfig behavior is the same
> >> regardless of 'default n' being present or not:
> >>
> >> ...
> >> One side effect of (and the main motivation for) this change is making
> >> the following two definitions behave exactly the same:
> >>
> >> config FOO
> >> bool
> >>
> >> config FOO
> >> bool
> >> default n
> >>
> >> With this change, neither of these will generate a
> >> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> >> That might make it clearer to people that a bare 'default n' is
> >> redundant.
> >> ...
> >>
> >> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> >> ---
> >> drivers/mfd/Kconfig | 6 ------
> >> 1 file changed, 6 deletions(-)
> >
> > The change looks okay to me, but I would also like you to include the
> > Maintainers/Reviewers for the affected source files.
>
> Could you please explain in more details what do you mean?
>
> The only affected source file is drivers/mfd/Kconfig:
>
> $ ./scripts/get_maintainer.pl -f drivers/mfd/Kconfig
> Lee Jones <lee.jones@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> linux-kernel@vger.kernel.org (open list)
You need to run get_maintainer.pl on each of the source files this
patch affects.
> > Also, I assume you are not just submitting these changes to the MFD
> > subsystem. My suggesting is to change each subsystem per patch (as
> > you have done here), and submit them in one patch-set with each of the
> > subsystem Maintainers included, so each of us has some visibility into
> > how the general idea is being received.
>
> The general idea is trivial - remove redundant "default n" from Kconfig
> files and as a result cut ~700 LOC kernel wide. I assume that this is so
> trivial change that there is no need for longer deliberations.
I agree that the patch looks fairly inert.
> Also I'm sorry but I simply cannot invest few days straight in preparing
> the full patchset. OTOH investing few minutes a day or a week is fine so
> this is why I'm doing this change incrementally.
However, converting a few subsystems at a time doesn't sound like a
great hardship. It allows other Maintainers to see how the idea is
being received generally - rather than doing them all independently
which disallows shared interest/discussion.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2018-10-25 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181010145127eucas1p2fcd5b5f91fa3ac7f763a51c0d5e8b3cb@eucas1p2.samsung.com>
2018-10-10 14:51 ` [PATCH] mfd: remove redundant 'default n' from Kconfig Bartlomiej Zolnierkiewicz
2018-10-11 5:48 ` Lee Jones
2018-10-12 12:08 ` Bartlomiej Zolnierkiewicz
2018-10-25 6:57 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025065759.GE4939@dell \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).