From: Chao Fan <fanc.fnst@cn.fujitsu.com>
To: Baoquan He <bhe@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
<linux-efi@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<bp@alien8.de>, <tglx@linutronix.de>, <mingo@redhat.com>,
<hpa@zytor.com>, <keescook@chromium.org>, <msys.mizuma@gmail.com>,
<indou.takao@jp.fujitsu.com>, <caoj.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v9 0/8] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory
Date: Thu, 18 Oct 2018 13:48:53 +0800 [thread overview]
Message-ID: <20181018054853.GC12871@localhost.localdomain> (raw)
In-Reply-To: <20181018035958.GA1885@192.168.1.4>
On Thu, Oct 18, 2018 at 11:59:58AM +0800, Baoquan He wrote:
>On 10/17/18 at 06:20pm, Chao Fan wrote:
>> In the earliest time, I tried to dig ACPI tabls to solve this problem.
>> But I didn't splite the code in 'compressed/' and ACPI code, so the patch
>> is hard to follow so refused by community.
>> Somebody suggest to add a kernel parameter to specify the
>> immovable memory so that limit kaslr in these regions. Then I make
>> a new patchset. After several versions, Ingo gave a suggestion:
>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1634024.html
>> Follow Ingo's suggestion, imitate the ACPI code to parse the acpi
>> tables, so that the kaslr can get necessary memory information in
>> ACPI tables.
>> I think ACPI code is an independent part, so imitate the codes
>> and functions to 'compressed/' directory, so that kaslr won't
>> influence the initialization of ACPI.
>>
>> PATCH 1/3 Add acpitb.c to provide functions to parse ACPI code.
>> PATCH 2/3 If CONFIG_MEMORY_HOTREMOVE enabled, walk all nodes and
>> store the information of immovable memory regions.
>> PATCH 3/3 According to the immovable memory regions, filter the
>> immovable regions which KASLR can choose.
>
>Chao, seems you didn't update above accordingly.
oops, sorry for that.
Thanks,
Chao Fan
>
>>
>> v1->v2:
>> - Simplify some code.
>> Follow Baoquan He's suggestion:
>> - Reuse the head file of acpi code.
>>
>> v2->v3:
>> - Test in more conditions, so remove the 'RFC' tag.
>> - Change some comments.
>>
>> v3->v4:
>> Follow Thomas Gleixner's suggetsion:
>> - Put the whole efi related function into #define CONFIG_EFI and return
>> false in the other stub.
>> - Simplify two functions in head file.
>>
>> v4->v5:
>> Follow Dou Liyang's suggestion:
>> - Add more comments about some functions based on kernel code.
>> - Change some typo in comments.
>> - Clean useless variable.
>> - Add check for the boundary of array.
>> - Add check for 'movable_node' parameter
>>
>> v5->v6:
>> Follow Baoquan He's suggestion:
>> - Change some log.
>> - Add the check for acpi_rsdp
>> - Change some code logical to make code clear
>>
>> v6->v7:
>> Follow Rafael's suggestion:
>> - Add more comments and patch log.
>> Follow test robot's suggestion:
>> - Add "static" tag for function
>>
>> v7-v8:
>> Follow Kees Cook's suggestion:
>> - Use mem_overlaps() to check memory region.
>> - Use #ifdef in the definition of function.
>>
>> v8-v9:
>> Follow Boris' suggetion:
>> - Change code style.
>> - Splite PATCH 1/3 to more path.
>> - Introduce some new function
>> - Use existing function to rework some code
>> Follow Masayoshi's suggetion:
>> - Make code more readable
>>
>> Any comments will be welcome.
>>
>>
>> Chao Fan (8):
>> x86/boot: Introduce cmdline_find_option_arg()to detect if option=arg
>> in cmdline
>> x86/boot: Copy kstrtoull() to compressed period
>> x86/boot: Add efi_get_rsdp_addr() to dig out RSDP from EFI table
>> x86/boot: Add bios_get_rsdp_addr() to search RSDP in memory
>> x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdlien from kexec
>> x86/boot: Dig out SRAT table from RSDP and find immovable memory
>> x86/boot/KASLR: Walk srat tables to filter immovable memory
>> x86/boot/KASLR: Limit kaslr to choosing the immovable memory
>>
>> arch/x86/boot/compressed/Makefile | 4 +
>> arch/x86/boot/compressed/acpitb.c | 354 +++++++++++++++++++++++++++++
>> arch/x86/boot/compressed/cmdline.c | 15 ++
>> arch/x86/boot/compressed/kaslr.c | 77 ++++++-
>> arch/x86/boot/compressed/misc.c | 88 +++++++
>> arch/x86/boot/compressed/misc.h | 15 ++
>> 6 files changed, 542 insertions(+), 11 deletions(-)
>> create mode 100644 arch/x86/boot/compressed/acpitb.c
>>
>> --
>> 2.17.2
>>
>>
>>
>
>
prev parent reply other threads:[~2018-10-18 5:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 10:20 [PATCH v9 0/8] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory Chao Fan
2018-10-17 10:20 ` [PATCH v9 1/8] x86/boot: Introduce cmdline_find_option_arg()to detect if option=arg in cmdline Chao Fan
2018-10-18 4:01 ` Baoquan He
2018-10-18 6:15 ` Chao Fan
2018-10-17 10:20 ` [PATCH v9 2/8] x86/boot: Copy kstrtoull() to compressed period Chao Fan
2018-10-18 4:03 ` Baoquan He
2018-10-18 5:51 ` Chao Fan
2018-10-18 6:01 ` Baoquan He
2018-10-18 6:08 ` Chao Fan
2018-10-17 10:20 ` [PATCH v9 3/8] x86/boot: Add efi_get_rsdp_addr() to dig out RSDP from EFI table Chao Fan
2018-10-18 4:35 ` Baoquan He
2018-10-18 5:54 ` Chao Fan
2018-10-18 5:56 ` Baoquan He
2018-10-18 6:10 ` Chao Fan
2018-10-17 10:20 ` [PATCH v9 4/8] x86/boot: Add bios_get_rsdp_addr() to search RSDP in memory Chao Fan
2018-10-17 10:20 ` [PATCH v9 5/8] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdlien from kexec Chao Fan
2018-10-21 2:26 ` Baoquan He
2018-10-22 5:30 ` Fan, Chao
2018-10-22 6:06 ` Baoquan He
2018-10-22 7:30 ` Chao Fan
2018-10-22 7:36 ` Baoquan He
2018-10-17 10:20 ` [PATCH v9 6/8] x86/boot: Dig out SRAT table from RSDP and find immovable memory Chao Fan
2018-10-18 6:12 ` Chao Fan
2018-10-21 2:34 ` Baoquan He
2018-10-22 5:29 ` Fan, Chao
2018-10-22 6:08 ` Baoquan He
2018-10-17 10:20 ` [PATCH v9 7/8] x86/boot/KASLR: Walk srat tables to filter " Chao Fan
2018-10-18 4:23 ` Baoquan He
2018-10-18 5:56 ` Chao Fan
2018-10-17 10:20 ` [PATCH v9 8/8] x86/boot/KASLR: Limit kaslr to choosing the " Chao Fan
2018-10-18 4:21 ` Baoquan He
2018-10-22 10:13 ` Chao Fan
2018-10-22 10:24 ` Baoquan He
2018-10-22 10:49 ` Chao Fan
2018-10-18 3:59 ` [PATCH v9 0/8] x86/boot/KASLR: Parse ACPI table and limit kaslr in " Baoquan He
2018-10-18 5:48 ` Chao Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018054853.GC12871@localhost.localdomain \
--to=fanc.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=msys.mizuma@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).