From: "Fan, Chao" <fanc.fnst@cn.fujitsu.com>
To: Baoquan He <bhe@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"msys.mizuma@gmail.com" <msys.mizuma@gmail.com>,
"Indoh, Takao" <indou.takao@fujitsu.com>,
"Cao, Jin" <caoj.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v9 5/8] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdlien from kexec
Date: Mon, 22 Oct 2018 05:30:38 +0000 [thread overview]
Message-ID: <B74D54765E346E448CD6C7B7B0334C258D955469@G08CNEXMBSHAD01.g08.fujitsu.local> (raw)
In-Reply-To: <20181021022650.GI1885@192.168.1.4>
On Sun, Oct 21, 2018 at 10:26:50AM +0800, Baoquan He wrote:
>On 10/17/18 at 06:20pm, Chao Fan wrote:
>> If KEXEC write the RSDP pointer to cmdline, parse the cmdline
>> and use it.
>> Imitate from early_param of "acpi_rsdp".
>>
>> Signed-off-by: Chao Fan <fanc.fnst@cn.fujitsu.com>
>> ---
>> arch/x86/boot/compressed/acpitb.c | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/x86/boot/compressed/acpitb.c b/arch/x86/boot/compressed/acpitb.c
>> index 50fa65cf824d..37b1f4407be8 100644
>> --- a/arch/x86/boot/compressed/acpitb.c
>> +++ b/arch/x86/boot/compressed/acpitb.c
>> @@ -8,6 +8,9 @@
>> #include <linux/numa.h>
>> #include <linux/acpi.h>
>>
>> +#define STATIC
>> +#include <linux/decompress/mm.h>
>> +
>> /* Search EFI table for RSDP table. */
>> static void efi_get_rsdp_addr(acpi_physical_address *rsdp_addr)
>> {
>> @@ -200,3 +203,23 @@ static void bios_get_rsdp_addr(acpi_physical_address *rsdp_addr)
>> *rsdp_addr = (acpi_physical_address)address;
>> }
>> }
>> +
>> +static void get_acpi_rsdp(acpi_physical_address *rsdp_addr)
>> +{
>> +#ifdef CONFIG_KEXEC
>> + unsigned long long res;
>> + int len = 0;
>> + char *val;
>> +
>> + val = malloc(20);
>
>Why is the length 20? Defined a macro?
>
Not a calculation, if it's enough to store the address, that will be OK.
Thanks,
Chao Fan
>> + len = cmdline_find_option("acpi_rsdp", val, 20);
>> +
>> + if (len == -1)
>> + return;
>> +
>> + if (len > 0) {
>> + val[len] = 0;
>> + *rsdp_addr = (acpi_physical_address)kstrtoull(val, 0, &res);
>> + }
>> +#endif
>> +}
>> --
>> 2.17.2
>>
>>
>>
>
>
next prev parent reply other threads:[~2018-10-22 5:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 10:20 [PATCH v9 0/8] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory Chao Fan
2018-10-17 10:20 ` [PATCH v9 1/8] x86/boot: Introduce cmdline_find_option_arg()to detect if option=arg in cmdline Chao Fan
2018-10-18 4:01 ` Baoquan He
2018-10-18 6:15 ` Chao Fan
2018-10-17 10:20 ` [PATCH v9 2/8] x86/boot: Copy kstrtoull() to compressed period Chao Fan
2018-10-18 4:03 ` Baoquan He
2018-10-18 5:51 ` Chao Fan
2018-10-18 6:01 ` Baoquan He
2018-10-18 6:08 ` Chao Fan
2018-10-17 10:20 ` [PATCH v9 3/8] x86/boot: Add efi_get_rsdp_addr() to dig out RSDP from EFI table Chao Fan
2018-10-18 4:35 ` Baoquan He
2018-10-18 5:54 ` Chao Fan
2018-10-18 5:56 ` Baoquan He
2018-10-18 6:10 ` Chao Fan
2018-10-17 10:20 ` [PATCH v9 4/8] x86/boot: Add bios_get_rsdp_addr() to search RSDP in memory Chao Fan
2018-10-17 10:20 ` [PATCH v9 5/8] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdlien from kexec Chao Fan
2018-10-21 2:26 ` Baoquan He
2018-10-22 5:30 ` Fan, Chao [this message]
2018-10-22 6:06 ` Baoquan He
2018-10-22 7:30 ` Chao Fan
2018-10-22 7:36 ` Baoquan He
2018-10-17 10:20 ` [PATCH v9 6/8] x86/boot: Dig out SRAT table from RSDP and find immovable memory Chao Fan
2018-10-18 6:12 ` Chao Fan
2018-10-21 2:34 ` Baoquan He
2018-10-22 5:29 ` Fan, Chao
2018-10-22 6:08 ` Baoquan He
2018-10-17 10:20 ` [PATCH v9 7/8] x86/boot/KASLR: Walk srat tables to filter " Chao Fan
2018-10-18 4:23 ` Baoquan He
2018-10-18 5:56 ` Chao Fan
2018-10-17 10:20 ` [PATCH v9 8/8] x86/boot/KASLR: Limit kaslr to choosing the " Chao Fan
2018-10-18 4:21 ` Baoquan He
2018-10-22 10:13 ` Chao Fan
2018-10-22 10:24 ` Baoquan He
2018-10-22 10:49 ` Chao Fan
2018-10-18 3:59 ` [PATCH v9 0/8] x86/boot/KASLR: Parse ACPI table and limit kaslr in " Baoquan He
2018-10-18 5:48 ` Chao Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B74D54765E346E448CD6C7B7B0334C258D955469@G08CNEXMBSHAD01.g08.fujitsu.local \
--to=fanc.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=indou.takao@fujitsu.com \
--cc=keescook@chromium.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=msys.mizuma@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).