* [PATCH] security: fix documentation for the socket_getpeersec_dgram hook
@ 2018-10-23 11:14 efremov
2018-10-23 19:28 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: efremov @ 2018-10-23 11:14 UTC (permalink / raw)
To: James Morris
Cc: Denis Efremov, Serge E. Hallyn, Eric Paris, Paul Moore,
Kees Cook, John Johansen, Catherine Zhang, linux-kernel
From: Denis Efremov <efremov@linux.com>
The socket_getpeersec_dgram hook was changed in the commit
"[AF_UNIX]: Kernel memory leak fix for af_unix datagram getpeersec patch"
(dc49c1f94e34). The arguments @secdata and @seclen were changed to @sock
and @secid. This patch updates the documentation accordingly.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
include/linux/lsm_hooks.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
index ae3766720264..a598e601ccb3 100644
--- a/include/linux/lsm_hooks.h
+++ b/include/linux/lsm_hooks.h
@@ -861,9 +861,9 @@
* the IP_PASSSEC option via getsockopt. It can then retrieve the
* security state returned by this hook for a packet via the SCM_SECURITY
* ancillary message type.
- * @skb is the skbuff for the packet being queried
- * @secdata is a pointer to a buffer in which to copy the security data
- * @seclen is the maximum length for @secdata
+ * @sock contains the socket structure.
+ * @skb is the skbuff for the packet being queried.
+ * @secid: pointer to where to put the secid of the packet.
* Return 0 on success, error on failure.
* @sk_alloc_security:
* Allocate and attach a security structure to the sk->sk_security field,
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] security: fix documentation for the socket_getpeersec_dgram hook
2018-10-23 11:14 [PATCH] security: fix documentation for the socket_getpeersec_dgram hook efremov
@ 2018-10-23 19:28 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2018-10-23 19:28 UTC (permalink / raw)
To: efremov
Cc: James Morris, Serge E. Hallyn, Eric Paris, Paul Moore,
John Johansen, Catherine Zhang, LKML
On Tue, Oct 23, 2018 at 4:14 AM, <efremov@linux.com> wrote:
> From: Denis Efremov <efremov@linux.com>
>
> The socket_getpeersec_dgram hook was changed in the commit
> "[AF_UNIX]: Kernel memory leak fix for af_unix datagram getpeersec patch"
> (dc49c1f94e34). The arguments @secdata and @seclen were changed to @sock
> and @secid. This patch updates the documentation accordingly.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> include/linux/lsm_hooks.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index ae3766720264..a598e601ccb3 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -861,9 +861,9 @@
> * the IP_PASSSEC option via getsockopt. It can then retrieve the
> * security state returned by this hook for a packet via the SCM_SECURITY
> * ancillary message type.
> - * @skb is the skbuff for the packet being queried
> - * @secdata is a pointer to a buffer in which to copy the security data
> - * @seclen is the maximum length for @secdata
> + * @sock contains the socket structure.
> + * @skb is the skbuff for the packet being queried.
> + * @secid: pointer to where to put the secid of the packet.
> * Return 0 on success, error on failure.
> * @sk_alloc_security:
> * Allocate and attach a security structure to the sk->sk_security field,
> --
> 2.17.2
>
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-23 19:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23 11:14 [PATCH] security: fix documentation for the socket_getpeersec_dgram hook efremov
2018-10-23 19:28 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).