From: Roman Gushchin <guro@fb.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>,
"Michal Hocko" <mhocko@kernel.org>,
Rik van Riel <riel@surriel.com>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [RFC PATCH] mm: don't reclaim inodes with many attached pages
Date: Wed, 24 Oct 2018 23:49:01 +0000 [thread overview]
Message-ID: <20181024234850.GA15663@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <20181024151853.3edd9097400b0d52edff1f16@linux-foundation.org>
On Wed, Oct 24, 2018 at 03:18:53PM -0700, Andrew Morton wrote:
> On Tue, 23 Oct 2018 16:43:29 +0000 Roman Gushchin <guro@fb.com> wrote:
>
> > Spock reported that the commit 172b06c32b94 ("mm: slowly shrink slabs
> > with a relatively small number of objects") leads to a regression on
> > his setup: periodically the majority of the pagecache is evicted
> > without an obvious reason, while before the change the amount of free
> > memory was balancing around the watermark.
> >
> > The reason behind is that the mentioned above change created some
> > minimal background pressure on the inode cache. The problem is that
> > if an inode is considered to be reclaimed, all belonging pagecache
> > page are stripped, no matter how many of them are there. So, if a huge
> > multi-gigabyte file is cached in the memory, and the goal is to
> > reclaim only few slab objects (unused inodes), we still can eventually
> > evict all gigabytes of the pagecache at once.
> >
> > The workload described by Spock has few large non-mapped files in the
> > pagecache, so it's especially noticeable.
> >
> > To solve the problem let's postpone the reclaim of inodes, which have
> > more than 1 attached page. Let's wait until the pagecache pages will
> > be evicted naturally by scanning the corresponding LRU lists, and only
> > then reclaim the inode structure.
> >
> > ...
> >
> > --- a/fs/inode.c
> > +++ b/fs/inode.c
> > @@ -730,8 +730,11 @@ static enum lru_status inode_lru_isolate(struct list_head *item,
> > return LRU_REMOVED;
> > }
> >
> > - /* recently referenced inodes get one more pass */
> > - if (inode->i_state & I_REFERENCED) {
> > + /*
> > + * Recently referenced inodes and inodes with many attached pages
> > + * get one more pass.
> > + */
> > + if (inode->i_state & I_REFERENCED || inode->i_data.nrpages > 1) {
> > inode->i_state &= ~I_REFERENCED;
> > spin_unlock(&inode->i_lock);
> > return LRU_ROTATE;
>
> hm, why "1"?
>
> I guess one could argue that this will encompass long symlinks, but I
> just made that up to make "1" appear more justifiable ;)
>
Well, I'm slightly aware of introducing an inode leak here, so I was thinking
about some small number of pages. It's definitely makes no sense to reclaim
several Gb of pagecache, however throwing away a couple of pages to speed up
inode reuse is totally fine.
But then I realized that I don't have any justification for a number like
4 or 32, so I ended up with 1. I'm pretty open here, but not sure that switching
to 0 is much better.
Thanks!
next prev parent reply other threads:[~2018-10-24 23:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 16:43 [RFC PATCH] mm: don't reclaim inodes with many attached pages Roman Gushchin
2018-10-24 22:18 ` Andrew Morton
2018-10-24 23:49 ` Roman Gushchin [this message]
2018-10-24 22:19 ` Andrew Morton
2018-10-24 23:51 ` Roman Gushchin
2018-10-25 9:23 ` Michal Hocko
2018-10-25 19:44 ` Andrew Morton
2018-10-25 20:20 ` Sasha Levin
2018-10-25 20:27 ` Matthew Wilcox
2018-10-25 21:44 ` Sasha Levin
2018-10-25 20:32 ` Roman Gushchin
2018-10-26 7:33 ` Michal Hocko
2018-10-26 15:54 ` Roman Gushchin
2018-10-26 8:57 ` Michal Hocko
2018-10-26 15:56 ` Roman Gushchin
2018-10-26 17:00 ` Spock
2018-10-26 15:58 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024234850.GA15663@castle.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rdunlap@infradead.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).