From: Sasha Levin <sashal@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>, Roman Gushchin <guro@fb.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>, Rik van Riel <riel@surriel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Sasha Levin <Alexander.Levin@microsoft.com>
Subject: Re: [RFC PATCH] mm: don't reclaim inodes with many attached pages
Date: Thu, 25 Oct 2018 17:44:49 -0400 [thread overview]
Message-ID: <20181025214449.GA2015@sasha-vm> (raw)
In-Reply-To: <20181025202707.GL25444@bombadil.infradead.org>
On Thu, Oct 25, 2018 at 01:27:07PM -0700, Matthew Wilcox wrote:
>On Thu, Oct 25, 2018 at 04:20:14PM -0400, Sasha Levin wrote:
>> On Thu, Oct 25, 2018 at 12:44:42PM -0700, Andrew Morton wrote:
>> > Yup. Sasha, can you please take care of this?
>>
>> Sure, I'll revert it from current stable trees.
>>
>> Should 172b06c32b94 and this commit be backported once Roman confirms
>> the issue is fixed? As far as I understand 172b06c32b94 addressed an
>> issue FB were seeing in their fleet and needed to be fixed.
>
>I'm not sure I see "FB sees an issue in their fleet" and "needs to be
>fixed in stable kernels" as related. FB's workload is different from
>most people's workloads and FB has a large and highly-skilled team of
>kernel engineers. Obviously I want this problem fixed in mainline,
>but I don't know that most people benefit from having it fixed in stable.
I don't want to make backporting decisions based on how big a certain
company's kernel team is. I only mentioned FB explicitly to suggest that
this issue is seen on real-life scenarios rather than on synthetic tests
or code review.
So yes, let's not run to fix it just because it's FB but also let's not
ignore it because FB has a world-class kernel team. This should be done
purely based on how likely this patch will regress stable kernels vs the
severity of the bug it fixes.
--
Thanks,
Sasha
next prev parent reply other threads:[~2018-10-25 21:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 16:43 [RFC PATCH] mm: don't reclaim inodes with many attached pages Roman Gushchin
2018-10-24 22:18 ` Andrew Morton
2018-10-24 23:49 ` Roman Gushchin
2018-10-24 22:19 ` Andrew Morton
2018-10-24 23:51 ` Roman Gushchin
2018-10-25 9:23 ` Michal Hocko
2018-10-25 19:44 ` Andrew Morton
2018-10-25 20:20 ` Sasha Levin
2018-10-25 20:27 ` Matthew Wilcox
2018-10-25 21:44 ` Sasha Levin [this message]
2018-10-25 20:32 ` Roman Gushchin
2018-10-26 7:33 ` Michal Hocko
2018-10-26 15:54 ` Roman Gushchin
2018-10-26 8:57 ` Michal Hocko
2018-10-26 15:56 ` Roman Gushchin
2018-10-26 17:00 ` Spock
2018-10-26 15:58 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025214449.GA2015@sasha-vm \
--to=sashal@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rdunlap@infradead.org \
--cc=riel@surriel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).