* [PATCH] staging: sm750fb: Add spaces around '+'
@ 2018-11-07 0:28 Laís Pessine do Carmo
2018-11-07 11:33 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Laís Pessine do Carmo @ 2018-11-07 0:28 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel, lkcamp
Add spaces around '+' to correct the following checkpath.pl warnings:
WARNING: line over 80 characters
+ write_dpPort(accel, *(unsigned int *)(pSrcbuf +
(j * 4)));
WARNING: line over 80 characters
+ memcpy(ajRemain, pSrcbuf+ul4BytesPerScan,
ulBytesRemain);
Signed-off-by: Laís Pessine do Carmo <laispc19@gmail.com>
---
Hi, I am new to Linux community and I am sending this patch to learn
about the kernel development.
Please, let me know if there is anything I can improve.
Thank you!
---
drivers/staging/sm750fb/sm750_accel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 1035e91e7cd3..eed840b251da 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -383,7 +383,8 @@ int sm750_hw_imageblit(struct lynx_accel *accel,
write_dpPort(accel, *(unsigned int *)(pSrcbuf + (j * 4)));
if (ulBytesRemain) {
- memcpy(ajRemain, pSrcbuf+ul4BytesPerScan, ulBytesRemain);
+ memcpy(ajRemain, pSrcbuf + ul4BytesPerScan,
+ ulBytesRemain);
write_dpPort(accel, *(unsigned int *)ajRemain);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sm750fb: Add spaces around '+'
2018-11-07 0:28 [PATCH] staging: sm750fb: Add spaces around '+' Laís Pessine do Carmo
@ 2018-11-07 11:33 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-11-07 11:33 UTC (permalink / raw)
To: Laís Pessine do Carmo
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, devel, linux-kernel, lkcamp
On Tue, Nov 06, 2018 at 10:28:04PM -0200, Laís Pessine do Carmo wrote:
> Add spaces around '+' to correct the following checkpath.pl warnings:
>
> WARNING: line over 80 characters
> + write_dpPort(accel, *(unsigned int *)(pSrcbuf +
> (j * 4)));
>
> WARNING: line over 80 characters
> + memcpy(ajRemain, pSrcbuf+ul4BytesPerScan,
> ulBytesRemain);
No need to line-wrap these warning lines next time.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-07 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07 0:28 [PATCH] staging: sm750fb: Add spaces around '+' Laís Pessine do Carmo
2018-11-07 11:33 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).