* [PATCH] arm64: dts: allwinner: h6: fix EMAC compatible string sequence
@ 2018-11-15 3:15 Icenowy Zheng
2018-11-15 15:06 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Icenowy Zheng @ 2018-11-15 3:15 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai
Cc: linux-arm-kernel, devicetree, linux-kernel, linux-sunxi, Icenowy Zheng
The SoC-specific compatible should come before the fallback compatible
string when multiple compatible strings are present, but the sequence is
wrong currently on H6 EMAC node (A64 fallback before H6 compatible).
Fix the sequence.
Fixes: c8ced5516d23 ("arm64: allwinner: h6: add EMAC device nodes")
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index 45bbb5116446..d1ed451f4d9e 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
@@ -326,8 +326,8 @@
};
emac: ethernet@5020000 {
- compatible = "allwinner,sun50i-a64-emac",
- "allwinner,sun50i-h6-emac";
+ compatible = "allwinner,sun50i-h6-emac",
+ "allwinner,sun50i-a64-emac";
syscon = <&syscon>;
reg = <0x05020000 0x10000>;
interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: fix EMAC compatible string sequence
2018-11-15 3:15 [PATCH] arm64: dts: allwinner: h6: fix EMAC compatible string sequence Icenowy Zheng
@ 2018-11-15 15:06 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2018-11-15 15:06 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Chen-Yu Tsai, linux-arm-kernel, devicetree, linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
On Thu, Nov 15, 2018 at 11:15:51AM +0800, Icenowy Zheng wrote:
> The SoC-specific compatible should come before the fallback compatible
> string when multiple compatible strings are present, but the sequence is
> wrong currently on H6 EMAC node (A64 fallback before H6 compatible).
>
> Fix the sequence.
>
> Fixes: c8ced5516d23 ("arm64: allwinner: h6: add EMAC device nodes")
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-15 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 3:15 [PATCH] arm64: dts: allwinner: h6: fix EMAC compatible string sequence Icenowy Zheng
2018-11-15 15:06 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).