* [PATCH -next] exportfs: fix 'passing zero to ERR_PTR()' warning
@ 2018-11-19 3:32 YueHaibing
2018-11-19 4:47 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-11-19 3:32 UTC (permalink / raw)
To: mszeredi, amir73il, neilb, bfields, viro
Cc: linux-kernel, akpm, matt.helsley, YueHaibing
Fix a static code checker warning:
fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR'
The error path for lookup_one_len_unlocked failure
should set err to PTR_ERR.
Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/exportfs/expfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c
index 645158d..c8a3dfd 100644
--- a/fs/exportfs/expfs.c
+++ b/fs/exportfs/expfs.c
@@ -147,6 +147,7 @@ static struct dentry *reconnect_one(struct vfsmount *mnt,
tmp = lookup_one_len_unlocked(nbuf, parent, strlen(nbuf));
if (IS_ERR(tmp)) {
dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));
+ err = PTR_ERR(tmp);
goto out_err;
}
if (tmp != dentry) {
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] exportfs: fix 'passing zero to ERR_PTR()' warning
2018-11-19 3:32 [PATCH -next] exportfs: fix 'passing zero to ERR_PTR()' warning YueHaibing
@ 2018-11-19 4:47 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2018-11-19 4:47 UTC (permalink / raw)
To: YueHaibing
Cc: mszeredi, amir73il, neilb, bfields, linux-kernel, akpm, matt.helsley
On Mon, Nov 19, 2018 at 11:32:41AM +0800, YueHaibing wrote:
> Fix a static code checker warning:
> fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR'
>
> The error path for lookup_one_len_unlocked failure
> should set err to PTR_ERR.
>
> Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-19 4:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-19 3:32 [PATCH -next] exportfs: fix 'passing zero to ERR_PTR()' warning YueHaibing
2018-11-19 4:47 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).