linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Thomas Gleixner" <tglx@linutronix.de>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Linus Walleij" <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH 0/2] irq/irq_sim: provide a specialized variant of irq_sim_fire()
Date: Tue, 20 Nov 2018 14:40:30 +0100	[thread overview]
Message-ID: <20181120134032.31645-1-brgl@bgdev.pl> (raw)

The interrupts simulator has a limitation in that a call to irq_sim_fire()
always fires the dummy interrupt - irrespective of the flags passed to the
irq request function.

This series addresses a problem with certain libgpiod tests failing when
using gpio-mockup with simulated interrupts since commit fa38869b0161
("gpiolib: Don't support irq sharing for userspace"). The tests are
failing because irq_sim fires interrupts for falling edge events even if
gpiolib requests a threaded irq triggered by rising edge only (and vice
versa).

We're introducing a new function: irq_sim_fire_edge() which takes
another argument allowing to specify the trigger type for the dummy
interrupt. We then use it in gpio-mockup.

Patch 1 applies on top of my previous irq_sim changeset[1]. Patch 2
applies on top of the recent changes to gpio-mockup[2].

Since test breakage in user-space after 4.20-rc1 can be considered
a regression, it would be great if this could go into 4.20.

[1] https://lkml.org/lkml/2018/11/9/1418
[2] https://lkml.org/lkml/2018/11/8/1012

Bartosz Golaszewski (2):
  irq/irq_sim: provide irq_sim_fire_edge()
  gpio: mockup: use irq_sim_fire_edge()

 drivers/gpio/gpio-mockup.c |  5 +++--
 include/linux/irq_sim.h    |  2 ++
 kernel/irq/irq_sim.c       | 30 ++++++++++++++++++++++++++++--
 3 files changed, 33 insertions(+), 4 deletions(-)

-- 
2.19.1


             reply	other threads:[~2018-11-20 13:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 13:40 Bartosz Golaszewski [this message]
2018-11-20 13:40 ` [PATCH 1/2] irq/irq_sim: provide irq_sim_fire_edge() Bartosz Golaszewski
2018-11-20 17:17   ` Uwe Kleine-König
2018-11-21 16:34     ` Bartosz Golaszewski
2018-11-21 19:15       ` Uwe Kleine-König
2018-11-23 15:59         ` Bartosz Golaszewski
2018-11-25 21:18           ` Uwe Kleine-König
2018-11-29 18:14             ` Bartosz Golaszewski
2018-11-30 22:26               ` Linus Walleij
2018-12-02 12:29                 ` Marc Zyngier
2018-12-02 17:00                   ` Bartosz Golaszewski
2018-12-02 21:56               ` Uwe Kleine-König
2018-12-02 22:20                 ` Bartosz Golaszewski
2018-12-03 10:23                   ` Bartosz Golaszewski
2018-12-03 10:49                     ` Uwe Kleine-König
2018-12-03 10:57                       ` Bartosz Golaszewski
2018-12-03 11:06                         ` Uwe Kleine-König
2018-12-05 12:19                           ` Linus Walleij
2018-12-05 12:38                             ` Bartosz Golaszewski
2018-12-05 12:55                               ` Linus Walleij
2018-12-17 10:32                               ` Bartosz Golaszewski
2018-12-17 12:59                                 ` Uwe Kleine-König
2018-12-17 13:59                                   ` Bartosz Golaszewski
2018-12-05 13:20                             ` Uwe Kleine-König
2018-12-14 14:07                               ` Linus Walleij
2018-12-17 11:19                                 ` Uwe Kleine-König
2018-11-20 13:40 ` [PATCH 2/2] gpio: mockup: use irq_sim_fire_edge() Bartosz Golaszewski
2018-12-03 11:09   ` Uwe Kleine-König
2018-12-11 14:15     ` Uwe Kleine-König
2018-12-11 15:38       ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120134032.31645-1-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).