* [PATCH v2] tee: optee: log message if dynamic shm is enabled
@ 2018-09-11 9:09 Victor Chong
2018-11-21 7:36 ` Jens Wiklander
0 siblings, 1 reply; 2+ messages in thread
From: Victor Chong @ 2018-09-11 9:09 UTC (permalink / raw)
To: Jens Wiklander; +Cc: tee-dev, linux-kernel, linux-arm-kernel
When dynamic shared memory support is enabled in the OP-TEE Trusted
OS, it doesn't mean that the driver supports it, which can confuse
users during debugging. Log a message when dynamic shared memory is
enabled in the driver, to let users know for sure.
Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Victor Chong <victor.chong@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
---
v2:
* Added patch description
[v1] lore.kernel.org/patchwork/patch/983949/
drivers/tee/optee/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index e1aafe842d66..cca5c091e55a 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np)
optee_enable_shm_cache(optee);
+ if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)
+ pr_info("dynamic shared memory is enabled\n");
+
pr_info("initialized driver\n");
return optee;
err:
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] tee: optee: log message if dynamic shm is enabled
2018-09-11 9:09 [PATCH v2] tee: optee: log message if dynamic shm is enabled Victor Chong
@ 2018-11-21 7:36 ` Jens Wiklander
0 siblings, 0 replies; 2+ messages in thread
From: Jens Wiklander @ 2018-11-21 7:36 UTC (permalink / raw)
To: Victor Chong; +Cc: tee-dev, linux-kernel, linux-arm-kernel
Hi Victor,
On Tue, Sep 11, 2018 at 06:09:02PM +0900, Victor Chong wrote:
> When dynamic shared memory support is enabled in the OP-TEE Trusted
> OS, it doesn't mean that the driver supports it, which can confuse
> users during debugging. Log a message when dynamic shared memory is
> enabled in the driver, to let users know for sure.
>
> Suggested-by: Jerome Forissier <jerome.forissier@linaro.org>
> Signed-off-by: Victor Chong <victor.chong@linaro.org>
> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>
> v2:
> * Added patch description
>
> [v1] lore.kernel.org/patchwork/patch/983949/
>
> drivers/tee/optee/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index e1aafe842d66..cca5c091e55a 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np)
>
> optee_enable_shm_cache(optee);
>
> + if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM)
> + pr_info("dynamic shared memory is enabled\n");
> +
> pr_info("initialized driver\n");
> return optee;
> err:
> --
> 2.17.1
Looks good. I'm picking this up.
Thanks,
Jens
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-21 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-11 9:09 [PATCH v2] tee: optee: log message if dynamic shm is enabled Victor Chong
2018-11-21 7:36 ` Jens Wiklander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).