linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 2/6] ARM: dtsi: add pwm node for sun8i R40.
@ 2018-11-25 16:19 Hao Zhang
  2018-11-26 20:46 ` Uwe Kleine-König
  0 siblings, 1 reply; 2+ messages in thread
From: Hao Zhang @ 2018-11-25 16:19 UTC (permalink / raw)
  To: robh+dt, mark.rutland, maxime.ripard, wens, mturquette, sboyd,
	thierry.reding
  Cc: linux-gpio, linux-kernel, devicetree, linux-arm-kernel,
	linux-pwm, linux-sunxi, hao5781286

This patch adds pwm node for sun8i R40.

Signed-off-by: Hao Zhang <hao5781286@gmail.com>
---
 arch/arm/boot/dts/sun8i-r40.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
index 6f4c9ca..cc05b2c 100644
--- a/arch/arm/boot/dts/sun8i-r40.dtsi
+++ b/arch/arm/boot/dts/sun8i-r40.dtsi
@@ -317,6 +317,7 @@
 			clock-names = "hosc", "losc";
 			#clock-cells = <1>;
 			#reset-cells = <1>;
+
 		};
 
 		pio: pinctrl@1c20800 {
@@ -373,6 +374,11 @@
 				bias-pull-up;
 			};
 
+			pwm_ch0_pin: pwm-ch0-pin {
+				pins = "PB2";
+				function = "pwm";
+			};
+
 			uart0_pb_pins: uart0-pb-pins {
 				pins = "PB22", "PB23";
 				function = "uart0";
@@ -384,6 +390,17 @@
 			reg = <0x01c20c90 0x10>;
 		};
 
+		pwm: pwm@1c23400 {
+			compatible = "allwinner,sun8i-r40-pwm";
+			reg = <0x01c23400 0x400>;
+			interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&osc24M>, <&ccu CLK_APB1>;
+			clock-names = "mux-0", "mux-1";
+			pwm-channels = <8>;
+			#pwm-cells = <3>;
+			status = "disabled";
+		};
+
 		uart0: serial@1c28000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x01c28000 0x400>;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 2/6] ARM: dtsi: add pwm node for sun8i R40.
  2018-11-25 16:19 [PATCH v3 2/6] ARM: dtsi: add pwm node for sun8i R40 Hao Zhang
@ 2018-11-26 20:46 ` Uwe Kleine-König
  0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2018-11-26 20:46 UTC (permalink / raw)
  To: Hao Zhang
  Cc: robh+dt, mark.rutland, maxime.ripard, wens, mturquette, sboyd,
	thierry.reding, linux-gpio, linux-kernel, devicetree,
	linux-arm-kernel, linux-pwm, linux-sunxi

On Mon, Nov 26, 2018 at 12:19:41AM +0800, Hao Zhang wrote:
> This patch adds pwm node for sun8i R40.
> 
> Signed-off-by: Hao Zhang <hao5781286@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-r40.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
> index 6f4c9ca..cc05b2c 100644
> --- a/arch/arm/boot/dts/sun8i-r40.dtsi
> +++ b/arch/arm/boot/dts/sun8i-r40.dtsi
> @@ -317,6 +317,7 @@
>  			clock-names = "hosc", "losc";
>  			#clock-cells = <1>;
>  			#reset-cells = <1>;
> +

This added line is unrelated (and wrong).

>  		};

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-26 20:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-25 16:19 [PATCH v3 2/6] ARM: dtsi: add pwm node for sun8i R40 Hao Zhang
2018-11-26 20:46 ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).