From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH v3 7/7] zram: writeback throttle
Date: Mon, 3 Dec 2018 08:18:29 +0900 [thread overview]
Message-ID: <20181202231829.GA21560@google.com> (raw)
In-Reply-To: <20181129022358.GA6379@jagdpanzerIV>
On Thu, Nov 29, 2018 at 11:23:58AM +0900, Sergey Senozhatsky wrote:
> On (11/27/18 14:54), Minchan Kim wrote:
> > diff --git a/Documentation/ABI/testing/sysfs-block-zram b/Documentation/ABI/testing/sysfs-block-zram
> > index 65fc33b2f53b..9d2339a485c8 100644
> > --- a/Documentation/ABI/testing/sysfs-block-zram
> > +++ b/Documentation/ABI/testing/sysfs-block-zram
> > @@ -121,3 +121,12 @@ Contact: Minchan Kim <minchan@kernel.org>
> > The bd_stat file is read-only and represents backing device's
> > statistics (bd_count, bd_reads, bd_writes) in a format
> > similar to block layer statistics file format.
> > +
> > +What: /sys/block/zram<id>/writeback_limit
> > +Date: November 2018
> > +Contact: Minchan Kim <minchan@kernel.org>
> > +Description:
> > + The writeback_limit file is read-write and specifies the maximum
> > + amount of writeback ZRAM can do. The limit could be changed
> > + in run time and "0" means disable the limit.
> > + No limit is the initial state.
> > diff --git a/Documentation/blockdev/zram.txt b/Documentation/blockdev/zram.txt
> > index 906df97527a7..64b61925e475 100644
> > --- a/Documentation/blockdev/zram.txt
> > +++ b/Documentation/blockdev/zram.txt
> > @@ -164,6 +164,8 @@ reset WO trigger device reset
> > mem_used_max WO reset the `mem_used_max' counter (see later)
> > mem_limit WO specifies the maximum amount of memory ZRAM can use
> > to store the compressed data
> > +writeback_limit WO specifies the maximum amount of write IO zram can
> > + write out to backing device as 4KB unit
> ^^^^
> page size units?
Per andrew's comment:
https://lkml.org/lkml/2018/11/27/156
I need to fix it to represent 4K always.
next prev parent reply other threads:[~2018-12-02 23:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 5:54 [PATCH v3 0/7] zram idle page writeback Minchan Kim
2018-11-27 5:54 ` [PATCH v3 1/7] zram: fix lockdep warning of free block handling Minchan Kim
2018-11-29 2:43 ` Sergey Senozhatsky
2018-11-27 5:54 ` [PATCH v3 2/7] zram: fix double free backing device Minchan Kim
2018-11-29 2:32 ` Sergey Senozhatsky
2018-11-27 5:54 ` [PATCH v3 3/7] zram: refactoring flags and writeback stuff Minchan Kim
2018-11-27 5:54 ` [PATCH v3 4/7] zram: introduce ZRAM_IDLE flag Minchan Kim
2018-11-29 2:29 ` Sergey Senozhatsky
2018-11-27 5:54 ` [PATCH v3 5/7] zram: support idle/huge page writeback Minchan Kim
2018-11-28 23:35 ` Andrew Morton
2018-11-29 1:36 ` Minchan Kim
2018-11-27 5:54 ` [PATCH v3 6/7] zram: add bd_stat statistics Minchan Kim
2018-11-27 5:54 ` [PATCH v3 7/7] zram: writeback throttle Minchan Kim
2018-11-28 23:41 ` Andrew Morton
2018-11-29 1:55 ` Minchan Kim
2018-11-29 2:23 ` Sergey Senozhatsky
2018-12-02 23:18 ` Minchan Kim [this message]
2018-12-03 2:30 ` Sergey Senozhatsky
2018-12-03 2:41 ` Minchan Kim
2018-12-03 2:45 ` Sergey Senozhatsky
2018-11-30 4:36 ` [PATCH v3 0/7] zram idle page writeback Sergey Senozhatsky
2018-12-02 23:20 ` Minchan Kim
2018-12-02 23:28 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181202231829.GA21560@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=joeypabalinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).