From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH v3 7/7] zram: writeback throttle
Date: Mon, 3 Dec 2018 11:41:46 +0900 [thread overview]
Message-ID: <20181203024146.GA149587@google.com> (raw)
In-Reply-To: <20181203023040.GA427@jagdpanzerIV>
On Mon, Dec 03, 2018 at 11:30:40AM +0900, Sergey Senozhatsky wrote:
> On (12/03/18 08:18), Minchan Kim wrote:
> >
> > Per andrew's comment:
> > https://lkml.org/lkml/2018/11/27/156
> >
> > I need to fix it to represent 4K always.
>
> Aha.
>
> Then we need to increase bd_writes PAGE_SIZE/4K times in writeback_store()?
>
> wb_count = atomic64_inc_return(&zram->stats.bd_writes);
> ...
> if (wb_limit != 0 && wb_count >= wb_limit)
> zram->stop_writeback = true;
>
> bd_wb_limit is in 4K units; but in writeback_store() we alloc a full page
> and write it to the backing device. So the actual number of written bytes
> can be larger on systems with page_size > 4K. Right?
Hey Sergey,
I changed interface in recent version v4. I belive it would be more
straigtforward for user. Could you review it?
Thanks!
next prev parent reply other threads:[~2018-12-03 2:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 5:54 [PATCH v3 0/7] zram idle page writeback Minchan Kim
2018-11-27 5:54 ` [PATCH v3 1/7] zram: fix lockdep warning of free block handling Minchan Kim
2018-11-29 2:43 ` Sergey Senozhatsky
2018-11-27 5:54 ` [PATCH v3 2/7] zram: fix double free backing device Minchan Kim
2018-11-29 2:32 ` Sergey Senozhatsky
2018-11-27 5:54 ` [PATCH v3 3/7] zram: refactoring flags and writeback stuff Minchan Kim
2018-11-27 5:54 ` [PATCH v3 4/7] zram: introduce ZRAM_IDLE flag Minchan Kim
2018-11-29 2:29 ` Sergey Senozhatsky
2018-11-27 5:54 ` [PATCH v3 5/7] zram: support idle/huge page writeback Minchan Kim
2018-11-28 23:35 ` Andrew Morton
2018-11-29 1:36 ` Minchan Kim
2018-11-27 5:54 ` [PATCH v3 6/7] zram: add bd_stat statistics Minchan Kim
2018-11-27 5:54 ` [PATCH v3 7/7] zram: writeback throttle Minchan Kim
2018-11-28 23:41 ` Andrew Morton
2018-11-29 1:55 ` Minchan Kim
2018-11-29 2:23 ` Sergey Senozhatsky
2018-12-02 23:18 ` Minchan Kim
2018-12-03 2:30 ` Sergey Senozhatsky
2018-12-03 2:41 ` Minchan Kim [this message]
2018-12-03 2:45 ` Sergey Senozhatsky
2018-11-30 4:36 ` [PATCH v3 0/7] zram idle page writeback Sergey Senozhatsky
2018-12-02 23:20 ` Minchan Kim
2018-12-02 23:28 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203024146.GA149587@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=joeypabalinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).