* [PATCH] mips: annotate implicit fall throughs
@ 2018-12-03 21:22 Mathieu Malaterre
2018-12-03 21:27 ` Boris Brezillon
2018-12-04 20:10 ` [PATCH v2] mtd: rawnand: jz4780: " Mathieu Malaterre
0 siblings, 2 replies; 4+ messages in thread
From: Mathieu Malaterre @ 2018-12-03 21:22 UTC (permalink / raw)
To: Paul Burton
Cc: trivial, kernel-janitors, Mathieu Malaterre, Harvey Hunt,
Boris Brezillon, Miquel Raynal, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, linux-mtd,
linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
these places in the code produced warnings. Fix them up.
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
index 731c6051d91e..7201827809e9 100644
--- a/drivers/mtd/nand/raw/jz4780_bch.c
+++ b/drivers/mtd/nand/raw/jz4780_bch.c
@@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
switch (size8) {
case 3:
dest8[2] = (val >> 16) & 0xff;
+ /* fall through */
case 2:
dest8[1] = (val >> 8) & 0xff;
+ /* fall through */
case 1:
dest8[0] = val & 0xff;
break;
--
2.19.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mips: annotate implicit fall throughs
2018-12-03 21:22 [PATCH] mips: annotate implicit fall throughs Mathieu Malaterre
@ 2018-12-03 21:27 ` Boris Brezillon
2018-12-04 20:10 ` [PATCH v2] mtd: rawnand: jz4780: " Mathieu Malaterre
1 sibling, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2018-12-03 21:27 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Paul Burton, trivial, kernel-janitors, Harvey Hunt,
Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris,
Marek Vasut, linux-mtd, linux-kernel
Hi Mathieu,
The subject prefix should be "mtd: rawnand: jz4780:" not "mips:"
Regards,
Boris
On Mon, 3 Dec 2018 22:22:13 +0100
Mathieu Malaterre <malat@debian.org> wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings. Fix them up.
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
> index 731c6051d91e..7201827809e9 100644
> --- a/drivers/mtd/nand/raw/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/jz4780_bch.c
> @@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
> switch (size8) {
> case 3:
> dest8[2] = (val >> 16) & 0xff;
> + /* fall through */
> case 2:
> dest8[1] = (val >> 8) & 0xff;
> + /* fall through */
> case 1:
> dest8[0] = val & 0xff;
> break;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] mtd: rawnand: jz4780: annotate implicit fall throughs
2018-12-03 21:22 [PATCH] mips: annotate implicit fall throughs Mathieu Malaterre
2018-12-03 21:27 ` Boris Brezillon
@ 2018-12-04 20:10 ` Mathieu Malaterre
2018-12-07 18:51 ` Miquel Raynal
1 sibling, 1 reply; 4+ messages in thread
From: Mathieu Malaterre @ 2018-12-04 20:10 UTC (permalink / raw)
To: Paul Burton
Cc: trivial, kernel-janitors, Mathieu Malaterre, Harvey Hunt,
Boris Brezillon, Miquel Raynal, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, linux-mtd,
linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
these places in the code produced warnings. Fix them up.
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
v2: fix subject prefix non sense
drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
index 731c6051d91e..7201827809e9 100644
--- a/drivers/mtd/nand/raw/jz4780_bch.c
+++ b/drivers/mtd/nand/raw/jz4780_bch.c
@@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
switch (size8) {
case 3:
dest8[2] = (val >> 16) & 0xff;
+ /* fall through */
case 2:
dest8[1] = (val >> 8) & 0xff;
+ /* fall through */
case 1:
dest8[0] = val & 0xff;
break;
--
2.19.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mtd: rawnand: jz4780: annotate implicit fall throughs
2018-12-04 20:10 ` [PATCH v2] mtd: rawnand: jz4780: " Mathieu Malaterre
@ 2018-12-07 18:51 ` Miquel Raynal
0 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2018-12-07 18:51 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Paul Burton, trivial, kernel-janitors, Harvey Hunt,
Boris Brezillon, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, linux-mtd, linux-kernel
Hi Mathieu,
Mathieu Malaterre <malat@debian.org> wrote on Tue, 4 Dec 2018 21:10:57
+0100:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings. Fix them up.
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> v2: fix subject prefix non sense
>
> drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
> index 731c6051d91e..7201827809e9 100644
> --- a/drivers/mtd/nand/raw/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/jz4780_bch.c
> @@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
> switch (size8) {
> case 3:
> dest8[2] = (val >> 16) & 0xff;
> + /* fall through */
> case 2:
> dest8[1] = (val >> 8) & 0xff;
> + /* fall through */
> case 1:
> dest8[0] = val & 0xff;
> break;
Applied to nand/next.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-07 18:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03 21:22 [PATCH] mips: annotate implicit fall throughs Mathieu Malaterre
2018-12-03 21:27 ` Boris Brezillon
2018-12-04 20:10 ` [PATCH v2] mtd: rawnand: jz4780: " Mathieu Malaterre
2018-12-07 18:51 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).