From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Guy Levi(SW)" <guyle@mellanox.com>
Cc: Jason Gunthorpe <jgg@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Majd Dibbiny <majd@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
Changbin Du <changbin.du@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: linux-next: build failure after merge of the rdma tree
Date: Thu, 6 Dec 2018 09:58:15 +1100 [thread overview]
Message-ID: <20181206095815.6e814057@canb.auug.org.au> (raw)
In-Reply-To: <AM0PR05MB533192C82AA04E89004251A1C7A80@AM0PR05MB5331.eurprd05.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
Hi Guy,
On Wed, 5 Dec 2018 12:25:57 +0000 "Guy Levi(SW)" <guyle@mellanox.com> wrote:
>
> >
> > Huh. So apparently every compiler that tested this patch (0-day, mine,
> > the submitters) optimized this call away because is_atomic_response()
> > always returns 0: meaning mlx5_get_atomic_laddr is never callable and
> > can be deleted entirely, including the call to mlx5_get_send_wqe.
> >
> > Not sure what compiler setup will hit this, but it is clearly wrong
> > code..
>
> Flag -o0 ?
No, but the kbuild tree contains a change that allows turning off of
gcc's autoinlining and the CONFIG option guarding that gets turned on
for allmodconfig builds among others.
Masahiro, should CONFIG_NO_AUTO_INLINE maybe need to be off unless
explicitly enabled (like CONFIG_DEBUG_INFO and others)?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-12-05 22:58 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 0:47 linux-next: build failure after merge of the rdma tree Stephen Rothwell
2018-12-04 1:52 ` Jason Gunthorpe
2018-12-04 9:42 ` Leon Romanovsky
2018-12-07 2:41 ` Stephen Rothwell
2018-12-05 12:25 ` Guy Levi(SW)
2018-12-05 22:58 ` Stephen Rothwell [this message]
2018-12-10 0:43 ` Changbin Du
2018-12-10 15:52 ` Masahiro Yamada
-- strict thread matches above, loose matches on Subject: below --
2020-02-26 2:51 Stephen Rothwell
2020-02-26 3:04 ` Devesh Sharma
2020-02-26 17:25 ` Jason Gunthorpe
2019-07-09 3:30 Stephen Rothwell
2019-07-09 7:04 ` Mark Zhang
2019-07-09 7:18 ` Leon Romanovsky
2019-07-09 12:43 ` Stephen Rothwell
2019-07-09 13:11 ` Leon Romanovsky
2019-07-09 12:46 ` Jason Gunthorpe
2019-07-10 1:04 ` Stephen Rothwell
2019-07-10 4:30 ` Stephen Rothwell
2019-07-16 23:28 ` Stephen Rothwell
2019-07-17 6:33 ` Masahiro Yamada
2019-07-17 7:45 ` Stephen Rothwell
2019-07-08 3:03 Stephen Rothwell
2019-07-08 14:09 ` Jason Gunthorpe
2019-07-08 2:57 Stephen Rothwell
2019-07-08 16:08 ` Jason Gunthorpe
2019-07-09 3:11 ` Stephen Rothwell
2019-07-25 18:32 ` Dennis Dalessandro
2019-07-01 4:14 Stephen Rothwell
2019-07-01 7:54 ` wangxi
2019-07-01 22:49 ` Jason Gunthorpe
2019-07-04 2:02 ` Stephen Rothwell
2019-07-04 2:04 ` Jason Gunthorpe
2019-07-04 2:10 ` oulijun
2019-07-04 4:07 ` wangxi
2019-07-04 4:10 ` wangxi
2019-07-04 6:31 ` oulijun
2019-07-05 13:15 ` Jason Gunthorpe
2019-07-05 14:59 ` Stephen Rothwell
2018-01-25 7:22 Stephen Rothwell
2018-01-25 8:50 ` Leon Romanovsky
2018-01-25 16:08 ` Doug Ledford
2017-07-31 2:07 Stephen Rothwell
2017-04-21 1:42 Stephen Rothwell
2017-04-21 1:58 ` Joe Perches
2017-04-21 2:21 ` Doug Ledford
2017-04-21 2:23 ` Stephen Rothwell
2017-04-21 2:21 ` Stephen Rothwell
2017-02-15 0:30 Stephen Rothwell
2017-02-15 1:05 ` Doug Ledford
2017-02-15 5:09 ` Selvin Xavier
2016-09-27 1:23 Stephen Rothwell
2016-09-27 5:04 ` Christoph Hellwig
2016-09-27 5:48 ` Stephen Rothwell
2016-09-27 13:39 ` Christoph Hellwig
2016-09-27 17:15 ` Doug Ledford
2016-09-28 1:43 ` Stephen Rothwell
2016-09-28 15:00 ` Doug Ledford
2016-09-28 15:23 ` Greg KH
2016-09-28 15:26 ` Doug Ledford
2016-09-28 21:45 ` Stephen Rothwell
2016-03-16 1:15 Stephen Rothwell
2016-03-16 6:49 ` Herbert Xu
2016-03-16 19:02 ` Doug Ledford
2016-03-16 20:41 ` Stephen Rothwell
2016-03-16 22:14 ` Ismail, Mustafa
2016-01-13 1:35 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206095815.6e814057@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=changbin.du@gmail.com \
--cc=dledford@redhat.com \
--cc=guyle@mellanox.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=majd@mellanox.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).