From: Mark Zhang <markz@mellanox.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@mellanox.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Majd Dibbiny <majd@mellanox.com>,
asahiro Yamada <yamada.masahiro@socionext.com>,
Leon Romanovsky <leonro@mellanox.com>
Subject: Re: linux-next: build failure after merge of the rdma tree
Date: Tue, 9 Jul 2019 07:04:16 +0000 [thread overview]
Message-ID: <ba1dd3e2-3091-816c-c308-2f9dd4385596@mellanox.com> (raw)
In-Reply-To: <20190709133019.25a8cd27@canb.auug.org.au>
Hi Stephen,
Can you please try the patch below, thank you.
net/mlx5: Remove include ib_verbs.h in rdma_counter.h
rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
from rdma_counter.h, but it is not defined yet.
Fixes: 413d3347503b ("RDMA/counter: Add set/clear per-port auto mode
support")
Signed-off-by: Mark Zhang <markz@mellanox.com>
diff --git a/include/rdma/rdma_counter.h b/include/rdma/rdma_counter.h
index 68827700ba95..eb99856e8b30 100644
--- a/include/rdma/rdma_counter.h
+++ b/include/rdma/rdma_counter.h
@@ -9,10 +9,10 @@
#include <linux/mutex.h>
#include <linux/pid_namespace.h>
-#include <rdma/ib_verbs.h>
#include <rdma/restrack.h>
#include <rdma/rdma_netlink.h>
+struct ib_device;
struct ib_qp;
struct auto_mode_param {
On 7/9/2019 11:30 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the rdma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from /home/sfr/next/next/include/rdma/rdma_counter.h:12,
> from <command-line>:
> /home/sfr/next/next/include/rdma/ib_verbs.h:2126:27: error: field 'port_counter' has incomplete type
> struct rdma_port_counter port_counter;
> ^~~~~~~~~~~~
>
> Caused by commit
>
> 413d3347503b ("RDMA/counter: Add set/clear per-port auto mode support")
>
> rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
> from rdma_counter.h, but it is not defined yet :-(
>
> I have applied the following patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 9 Jul 2019 13:17:49 +1000
> Subject: [PATCH] RDMA: don't try to build rdma_counter.h for now
>
> rdma_counter.h include ib_verbs.h which in turn needs rdma_port_counter
> from rdma_counter.h, but it is not defined yet :-(
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> include/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/Kbuild b/include/Kbuild
> index 78434c59701f..8dab85cdf4f4 100644
> --- a/include/Kbuild
> +++ b/include/Kbuild
> @@ -939,6 +939,7 @@ header-test- += rdma/ib.h
> header-test- += rdma/iw_portmap.h
> header-test- += rdma/opa_port_info.h
> header-test- += rdma/rdmavt_cq.h
> +header-test- += rdma/rdma_counter.h
> header-test- += rdma/restrack.h
> header-test- += rdma/signature.h
> header-test- += rdma/tid_rdma_defs.h
>
next prev parent reply other threads:[~2019-07-09 7:04 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 3:30 linux-next: build failure after merge of the rdma tree Stephen Rothwell
2019-07-09 7:04 ` Mark Zhang [this message]
2019-07-09 7:18 ` Leon Romanovsky
2019-07-09 12:43 ` Stephen Rothwell
2019-07-09 13:11 ` Leon Romanovsky
2019-07-09 12:46 ` Jason Gunthorpe
2019-07-10 1:04 ` Stephen Rothwell
2019-07-10 4:30 ` Stephen Rothwell
2019-07-16 23:28 ` Stephen Rothwell
2019-07-17 6:33 ` Masahiro Yamada
2019-07-17 7:45 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2020-02-26 2:51 Stephen Rothwell
2020-02-26 3:04 ` Devesh Sharma
2020-02-26 17:25 ` Jason Gunthorpe
2019-07-08 3:03 Stephen Rothwell
2019-07-08 14:09 ` Jason Gunthorpe
2019-07-08 2:57 Stephen Rothwell
2019-07-08 16:08 ` Jason Gunthorpe
2019-07-09 3:11 ` Stephen Rothwell
2019-07-25 18:32 ` Dennis Dalessandro
2019-07-01 4:14 Stephen Rothwell
2019-07-01 7:54 ` wangxi
2019-07-01 22:49 ` Jason Gunthorpe
2019-07-04 2:02 ` Stephen Rothwell
2019-07-04 2:04 ` Jason Gunthorpe
2019-07-04 2:10 ` oulijun
2019-07-04 4:07 ` wangxi
2019-07-04 4:10 ` wangxi
2019-07-04 6:31 ` oulijun
2019-07-05 13:15 ` Jason Gunthorpe
2019-07-05 14:59 ` Stephen Rothwell
2018-12-04 0:47 Stephen Rothwell
2018-12-04 1:52 ` Jason Gunthorpe
2018-12-04 9:42 ` Leon Romanovsky
2018-12-07 2:41 ` Stephen Rothwell
2018-12-05 12:25 ` Guy Levi(SW)
2018-12-05 22:58 ` Stephen Rothwell
2018-12-10 0:43 ` Changbin Du
2018-12-10 15:52 ` Masahiro Yamada
2018-01-25 7:22 Stephen Rothwell
2018-01-25 8:50 ` Leon Romanovsky
2018-01-25 16:08 ` Doug Ledford
2017-07-31 2:07 Stephen Rothwell
2017-04-21 1:42 Stephen Rothwell
2017-04-21 1:58 ` Joe Perches
2017-04-21 2:21 ` Doug Ledford
2017-04-21 2:23 ` Stephen Rothwell
2017-04-21 2:21 ` Stephen Rothwell
2017-02-15 0:30 Stephen Rothwell
2017-02-15 1:05 ` Doug Ledford
2017-02-15 5:09 ` Selvin Xavier
2016-09-27 1:23 Stephen Rothwell
2016-09-27 5:04 ` Christoph Hellwig
2016-09-27 5:48 ` Stephen Rothwell
2016-09-27 13:39 ` Christoph Hellwig
2016-09-27 17:15 ` Doug Ledford
2016-09-28 1:43 ` Stephen Rothwell
2016-09-28 15:00 ` Doug Ledford
2016-09-28 15:23 ` Greg KH
2016-09-28 15:26 ` Doug Ledford
2016-09-28 21:45 ` Stephen Rothwell
2016-03-16 1:15 Stephen Rothwell
2016-03-16 6:49 ` Herbert Xu
2016-03-16 19:02 ` Doug Ledford
2016-03-16 20:41 ` Stephen Rothwell
2016-03-16 22:14 ` Ismail, Mustafa
2016-01-13 1:35 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba1dd3e2-3091-816c-c308-2f9dd4385596@mellanox.com \
--to=markz@mellanox.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=majd@mellanox.com \
--cc=sfr@canb.auug.org.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).