From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Vokáč Michal" <Michal.Vokac@ysoft.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Lukasz Majewski" <l.majewski@majess.pl>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Lothar Waßmann" <LW@karo-electronics.de>,
"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state
Date: Wed, 12 Dec 2018 13:12:55 +0100 [thread overview]
Message-ID: <20181212121255.yg6b4pw7qord7ebi@pengutronix.de> (raw)
In-Reply-To: <52ed0614-d1f5-81cb-3b17-8eb137967872@ysoft.com>
On Wed, Dec 12, 2018 at 11:42:17AM +0000, Vokáč Michal wrote:
> On 12.12.2018 09:01, Uwe Kleine-König wrote:
> > On Thu, Dec 06, 2018 at 01:41:31PM +0000, Vokáč Michal wrote:
> >> Normally the PWM output is held LOW when PWM is disabled. This can cause
> >> problems when inverted PWM signal polarity is needed. With this behavior
> >> the connected circuit is fed by 100% duty cycle instead of being shut-off.
> >>
> >> Allow users to define a "pwm" and a "gpio" pinctrl states. The pwm pinctrl
> >> state is selected when PWM is enabled and the gpio pinctrl state is
> >> selected when PWM is disabled. In the gpio state the new pwm-gpios GPIO is
> >> configured as input and the internal pull-up resistor is used to pull the
> >> output level high.
> >>
> >> If all the pinctrl states and the pwm-gpios GPIO are not correctly
> >> specified in DT the PWM work as usual.
> >>
> >> As an example, with this patch a PWM controlled backlight with inversed
> >> signal polarity can be used in full brightness range. Without this patch
> >> the backlight can not be turned off as brightness = 0 disables the PWM
> >> and that in turn set PWM output LOW, that is full brightness.
> >>
> >> Inverted output of the PWM with "default" and with "pwm"+"gpio" pinctrl:
> >>
> >> +--------------+------------+---------------+----------- +-------------+
> >> | After reset | Bootloader | PWM probe | PWM | PWM |
> >> | 100k pull-up | | | enable 30% | disable |
> >> +--------------+------------+---------------+------------+-------------+
> >> | pinctrl | none | default | default | default |
> >> | out H __________________ __ __ |
> >> | out L \_________________/ \_/ \_/\____________ |
> >> | ^ ^ ^ |
> >> +--------------+------------+---------------+------------+-------------+
> >> | pinctrl | none | gpio | pwm | gpio |
> >> | out H __________________________________ __ __ _____________ |
> >> | out L \_/ \_/ \_/ |
> >> | ^ ^ ^ |
> >> +----------------------------------------------------------------------+
> >>
> >> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> >> ---
> >> Changes in v3:
> >> - Commit message update.
> >> - Minor fix in code comment (Uwe)
> >> - Align function arguments to the opening parentheses. (Uwe)
> >> - Do not test devm_pinctrl_get for NULL. (Thierry)
> >> - Convert all messages to dev_dbg() (Thierry)
> >> - Do not actively drive the pin in gpio state. Configure it as input
> >> and rely solely on the internal pull-up. (Thierry)
> >>
> >> Changes in v2:
> >> - Utilize the "pwm" and "gpio" pinctrl states.
> >> - Use the pwm-gpios signal to drive the output in "gpio" pinctrl state.
> >> - Select the right pinctrl state in probe.
> >>
> >> drivers/pwm/pwm-imx.c | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 77 insertions(+)
> >>
>
> [ snip ]
>
> > On thing I noticed while looking at the rcar driver is: This doesn't
> > wait for the current period to end. Is this supposed to happen? Also for
> > the enable case the hardware is configured for the desired duty cycle
> > and only then the pinctrl is switched to pwm. Both might result in a
> > spike that is not desired.
>
> The behavior should not change from how imx-pwm was working before.
> When PWM is disabled the output is immediately gated off (put into
> the idle state) independently on the period. I measured this.
Oh really, I wasn't aware of that. This is another bug in the imx pwm
then (I think).
> For the enable case you would certainly not get any additional spikes.
Yes, there is a possibility for a spike: If you configure for say 40%:
_ _
pwm output : ___/ \__/ \__
muxing : GPIO| PWM_
actual output: ____/\__/ \__
> The worst thing that may happen is that the first period will be
> slightly shorter depending on how long it takes to test the pinctrl
> and switch the muxing. And this is unavoidable, it would happen even
> if you wait for the start of a period. The test + muxing still takes
> some time.
You could first configure for duty_cycle 0 and a short period, then mux
to PWM and then configure the correct duty cycle. Ditto for disable.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-12-12 12:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:41 [RFC PATCH v3 0/2] pwm: imx: Configure output to GPIO in disabled state Vokáč Michal
2018-12-06 13:41 ` [RFC PATCH v3 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO Vokáč Michal
2018-12-10 23:16 ` Rob Herring
2018-12-14 13:45 ` Linus Walleij
2018-12-06 13:41 ` [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state Vokáč Michal
2018-12-06 13:59 ` Uwe Kleine-König
2018-12-06 15:37 ` Vokáč Michal
2018-12-06 16:16 ` Uwe Kleine-König
2018-12-10 11:15 ` Vokáč Michal
2018-12-10 11:17 ` Uwe Kleine-König
2018-12-10 11:38 ` Vokáč Michal
2018-12-12 8:01 ` Uwe Kleine-König
2018-12-12 11:42 ` Vokáč Michal
2018-12-12 12:12 ` Uwe Kleine-König [this message]
2019-01-24 8:59 ` Michal Vokáč
2019-01-24 9:22 ` Uwe Kleine-König
2019-01-24 10:12 ` Michal Vokáč
2019-01-24 10:44 ` Uwe Kleine-König
2019-01-30 14:42 ` Michal Vokáč
2019-01-30 15:39 ` Uwe Kleine-König
2019-02-01 15:50 ` Michal Vokáč
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212121255.yg6b4pw7qord7ebi@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=LW@karo-electronics.de \
--cc=Michal.Vokac@ysoft.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=l.majewski@majess.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).