From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Michal Vokáč" <michal.vokac@ysoft.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Lukasz Majewski" <l.majewski@majess.pl>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Lothar Waßmann" <LW@karo-electronics.de>,
"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state
Date: Thu, 24 Jan 2019 11:44:35 +0100 [thread overview]
Message-ID: <20190124104435.e6paqwcuz3hizwnv@pengutronix.de> (raw)
In-Reply-To: <4004896e-34fc-7160-2f21-30280d96f750@ysoft.com>
On Thu, Jan 24, 2019 at 11:12:12AM +0100, Michal Vokáč wrote:
> On 24.1.2019 10:22, Uwe Kleine-König wrote:
> > I think it might be beneficial to allow (or require) that disable acts
> > immediately. But this is not how it used to be and in my discussion with
> > Thierry (IIRC) he required to complete the currently running period.
>
> I am confused here. IFAIK it always used to be that:
>
> pwm_apply_state(pwm, { .enabled = 0 });
>
> immediately stops the PWM with:
>
> writel(0, imx->mmio_base + MX3_PWMCR);
>
> regardless of the period (for pwm-imx).
Then is is a bug since forever (well, or a fact that resulted from the
intended semantic not being documented and the driver author not caring
or knowing better).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-01-24 10:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:41 [RFC PATCH v3 0/2] pwm: imx: Configure output to GPIO in disabled state Vokáč Michal
2018-12-06 13:41 ` [RFC PATCH v3 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO Vokáč Michal
2018-12-10 23:16 ` Rob Herring
2018-12-14 13:45 ` Linus Walleij
2018-12-06 13:41 ` [RFC PATCH v3 2/2] pwm: imx: Configure output to GPIO in disabled state Vokáč Michal
2018-12-06 13:59 ` Uwe Kleine-König
2018-12-06 15:37 ` Vokáč Michal
2018-12-06 16:16 ` Uwe Kleine-König
2018-12-10 11:15 ` Vokáč Michal
2018-12-10 11:17 ` Uwe Kleine-König
2018-12-10 11:38 ` Vokáč Michal
2018-12-12 8:01 ` Uwe Kleine-König
2018-12-12 11:42 ` Vokáč Michal
2018-12-12 12:12 ` Uwe Kleine-König
2019-01-24 8:59 ` Michal Vokáč
2019-01-24 9:22 ` Uwe Kleine-König
2019-01-24 10:12 ` Michal Vokáč
2019-01-24 10:44 ` Uwe Kleine-König [this message]
2019-01-30 14:42 ` Michal Vokáč
2019-01-30 15:39 ` Uwe Kleine-König
2019-02-01 15:50 ` Michal Vokáč
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124104435.e6paqwcuz3hizwnv@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=LW@karo-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=l.majewski@majess.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.vokac@ysoft.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).