From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Naga Sureshkumar Relli <nagasure@xilinx.com>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
"robh@kernel.org" <robh@kernel.org>,
"richard@nod.at" <richard@nod.at>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"nagasuresh12@gmail.com" <nagasuresh12@gmail.com>,
Michal Simek <michals@xilinx.com>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller
Date: Wed, 12 Dec 2018 14:18:25 +0100 [thread overview]
Message-ID: <20181212141825.69711c57@xps13> (raw)
In-Reply-To: <MWHPR02MB2623EDA15BE59304795F3034AFA70@MWHPR02MB2623.namprd02.prod.outlook.com>
Hi Naga,
Naga Sureshkumar Relli <nagasure@xilinx.com> wrote on Wed, 12 Dec 2018
13:07:42 +0000:
> Hi Miquel,
>
> > -----Original Message-----
> > From: Miquel Raynal [mailto:miquel.raynal@bootlin.com]
> > Sent: Wednesday, December 12, 2018 2:40 PM
> > To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> > Cc: Boris Brezillon <boris.brezillon@bootlin.com>; robh@kernel.org; richard@nod.at; linux-
> > kernel@vger.kernel.org; marek.vasut@gmail.com; linux-mtd@lists.infradead.org;
> > nagasuresh12@gmail.com; Michal Simek <michals@xilinx.com>;
> > computersforpeace@gmail.com; dwmw2@infradead.org
> > Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan
> > NAND Flash Controller
> >
> > Hi Naga,
> >
> > Naga Sureshkumar Relli <nagasure@xilinx.com> wrote on Wed, 12 Dec 2018
> > 09:04:16 +0000:
> >
> > > Hi Miquel,
> > >
> > > > -----Original Message-----
> > > > From: Miquel Raynal [mailto:miquel.raynal@bootlin.com]
> > > > Sent: Wednesday, December 12, 2018 1:42 PM
> > > > To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> > > > Cc: Boris Brezillon <boris.brezillon@bootlin.com>; robh@kernel.org;
> > > > richard@nod.at; linux- kernel@vger.kernel.org;
> > > > marek.vasut@gmail.com; linux-mtd@lists.infradead.org;
> > > > nagasuresh12@gmail.com; Michal Simek <michals@xilinx.com>;
> > > > computersforpeace@gmail.com; dwmw2@infradead.org
> > > > Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support
> > > > for Arasan NAND Flash Controller
> > > >
> > > > Hi Naga,
> > > >
> > > > Naga Sureshkumar Relli <nagasure@xilinx.com> wrote on Wed, 12 Dec
> > > > 2018
> > > > 05:27:03 +0000:
> > > >
> > > > > Hi Boris & Miquel,
> > > > >
> > > > > An update to my comments on thread https://lkml.org/lkml/2018/11/15/656.
> > > > > In this I said, will take a default error count value as 16 and
> > > > > during page read, will check the error count Register value with
> > > > > this and if it is equal to or greater than the default count(16) then I am checking for
> > Erased pages.
> > > > > But bit[7:0] in ECC_Error_Count_Register(0x38) will update for each error occurred.
> > > > > Link:
> > > > > https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultr
> > > > > ascale-
> > > > registers.html and check for NAND module, ECC_Error_Count_Register.
> > > > >
> > > > > I mean previously I dependent on Total error count value
> > > > > (bit[16:8]), but we can simply check for bit[7:0] To see the error occurred or not.
> > > > > I tried with this approach and I don't see any issues with that.
> > > > > I ran ubifs with this and I am able to see the bit[7:0] count is
> > > > > updated for erased page read and then will Use
> > > > > nand_chech_erased_ecc_chunk() to see the
> > > > bitflips.
> > > > >
> > > > > If it is ok, I will update the driver and will send new patch, but
> > > > > do you have any other
> > > > comments on v12?
> > > >
> > > > Is 'nandbiterrs -i' running correctly now?
> > > Yes, but with some changes in driver.
> > > I have added the log and changes done in https://lkml.org/lkml/2018/11/23/705.
> >
> > No, I don't see a working nandbiterrs there, sorry.
> The log that I have attached is from mtd_nandbiterrs test
> So as per ARASAN controller ECC mechanism, it will correct upto 24-bit. After that the test will fail.
There is a distinction between:
1/ The driver fails to correct more than 24-bit and advertise the
caller that the page read is somehow corrupted.
2/ The driver fails to correct more than 24-bit but does not complain
about it. In our case, the caller (the test tool) will compare the
page written and read: if it do not match it means the driver is
broken because the driver reported a successful operation despite
the fact that it returned a corrupted page.
You are in the second case, we expect the driver to behave like in 1/.
>
> I am running mtd-utils nandbiterr test now. Will let you know once I completed that.
Yes please, prefer using the userspace tools.
Thanks,
Miquèl
next prev parent reply other threads:[~2018-12-12 13:18 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 5:00 [LINUX PATCH v12 0/3] Add support for Arasan NAND Flash controller Naga Sureshkumar Relli
2018-11-09 5:00 ` [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation Naga Sureshkumar Relli
2018-11-09 6:28 ` Boris Brezillon
2018-11-09 12:33 ` Naga Sureshkumar Relli
2018-11-09 12:54 ` Miquel Raynal
2018-11-09 13:19 ` Naga Sureshkumar Relli
2018-11-16 11:50 ` Martin Lund
2018-11-16 12:10 ` Martin Lund
2018-11-16 12:33 ` Michal Simek
2018-11-16 13:50 ` Naga Sureshkumar Relli
2018-11-16 14:22 ` Martin Lund
2018-11-09 5:00 ` [LINUX PATCH v12 2/3] mtd: rawnand: Add an option to get sdr timing mode number Naga Sureshkumar Relli
2018-11-09 5:00 ` [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Naga Sureshkumar Relli
2018-11-09 8:07 ` Boris Brezillon
2018-11-09 13:18 ` Naga Sureshkumar Relli
2018-11-09 23:03 ` kbuild test robot
2018-11-12 10:55 ` Martin Lund
2018-11-12 10:58 ` Boris Brezillon
2018-11-12 12:43 ` Naga Sureshkumar Relli
2018-11-15 9:34 ` Naga Sureshkumar Relli
2018-11-18 18:52 ` Miquel Raynal
2018-11-18 19:43 ` Boris Brezillon
2018-11-19 6:20 ` Naga Sureshkumar Relli
2018-11-19 8:02 ` Boris Brezillon
2018-11-20 7:02 ` Naga Sureshkumar Relli
2018-11-20 11:02 ` Boris Brezillon
2018-11-20 12:36 ` Miquel Raynal
2018-11-23 13:53 ` Naga Sureshkumar Relli
2018-12-12 5:27 ` Naga Sureshkumar Relli
2018-12-12 8:11 ` Miquel Raynal
2018-12-12 9:04 ` Naga Sureshkumar Relli
2018-12-12 9:09 ` Miquel Raynal
2018-12-12 13:07 ` Naga Sureshkumar Relli
2018-12-12 13:18 ` Miquel Raynal [this message]
2018-12-17 13:21 ` Naga Sureshkumar Relli
2018-12-17 16:41 ` Miquel Raynal
2018-12-18 5:33 ` Naga Sureshkumar Relli
2018-12-19 14:26 ` Miquel Raynal
2018-12-21 7:36 ` Naga Sureshkumar Relli
2019-01-28 6:04 ` Naga Sureshkumar Relli
2019-01-28 9:27 ` Miquel Raynal
2019-01-28 9:35 ` Naga Sureshkumar Relli
2019-06-19 4:44 ` Naga Sureshkumar Relli
2019-06-27 16:27 ` Miquel Raynal
2019-06-28 4:20 ` Naga Sureshkumar Relli
2018-11-15 16:45 ` Dan Carpenter
2018-11-20 16:24 ` Boris Brezillon
2018-12-04 9:18 ` Naga Sureshkumar Relli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212141825.69711c57@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=michals@xilinx.com \
--cc=nagasure@xilinx.com \
--cc=nagasuresh12@gmail.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).