From: Naga Sureshkumar Relli <nagasure@xilinx.com>
To: Michal Simek <michals@xilinx.com>,
Martin Lund <martin.lund@keep-it-simple.com>
Cc: "boris.brezillon@bootlin.com" <boris.brezillon@bootlin.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"richard@nod.at" <richard@nod.at>,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Marek Vašut" <marek.vasut@gmail.com>,
"naga sureshkumar" <nagasuresh12@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>
Subject: RE: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation
Date: Fri, 16 Nov 2018 13:50:35 +0000 [thread overview]
Message-ID: <MWHPR02MB26231009A82C0372F62B5292AFDD0@MWHPR02MB2623.namprd02.prod.outlook.com> (raw)
In-Reply-To: <6ce1726a-f24d-17b8-d839-0a51c424a850@xilinx.com>
Hi,
> -----Original Message-----
> From: Michal Simek [mailto:michal.simek@xilinx.com]
> Sent: Friday, November 16, 2018 6:04 PM
> To: Martin Lund <martin.lund@keep-it-simple.com>; Naga Sureshkumar Relli
> <nagasure@xilinx.com>
> Cc: boris.brezillon@bootlin.com; miquel.raynal@bootlin.com; richard@nod.at; David
> Woodhouse <dwmw2@infradead.org>; Brian Norris <computersforpeace@gmail.com>; Marek
> Vašut <marek.vasut@gmail.com>; naga sureshkumar <nagasuresh12@gmail.com>; linux-
> mtd@lists.infradead.org; linux-kernel@vger.kernel.org; robh@kernel.org
> Subject: Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding
> documentation
>
> On 16. 11. 18 12:50, Martin Lund wrote:
> > Hi Naga,
> >
> > I've been working on running up the latest kernel (v4.20-rc2) on our
> > custom Xilinx hw board so that I can test the v12 version of your
> > Arasan nand driver.
> >
> > I've managed to get the driver successfully up and running and ready
> > for testing with a Micron MT29F64G08AFAAAWP device. However, setting
> > it up I've found a few inaccuracies in the documentation of the device
> > tree bindings.
> >
> > This is the device configuration that ended up working for me with
> > linux v4.20-rc2:
> >
> > nfc: nand@ff100000 {
> > compatible = "xlnx,zynqmp-nand", "arasan,nfc-v3p10";
> > reg = <0x0 0xff100000 0x0 0x1000>;
> > clock-names = "clk_sys", "clk_flash";
> > clocks = <&clk200>, <&clk100>;
> > interrupt-parent = <&gic>;
> > interrupts = <0 14 4>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > nand@0 {
> > reg = <0>;
> > nand-ecc-mode = "hw";
> > };
> > };
> >
> > Compared with the example you will notice that "clock-name" should be
> > "clock-names". reg was missing a "0x0".
>
> clock-names and even that names - you are right it is not correct and should be fixed.
Clock-names I will change from "clock-name" to "clock-names".
But I got some review comments previously, to use "sys" instead of "clk_sys" and "flash" instead of "clk_flash".
And I have to change this in driver.
I will update that.
Thanks,
Naga Sureshkumar Relli
>
> Missing 0x0 in reg doesn't matter because it depends on address/size cells.
>
> > I think it is helpful to provide a real-world working example, so you
> > might also consider changing the example "clocks" configuration to
> > clk200/clk100 since there is no clk_misc among the clock sources of
> > any of the xilinx zynqmp board device tree configurations.
>
> Real example is the best normally just c&p from existing dts is the way to go.
> But in connection to clocks it doesn't matter what exactly should be there and I don't think
> there is any consistency in that. Hopefully this will be removed by yaml conversion.
>
> Thanks,
> Michal
next prev parent reply other threads:[~2018-11-16 13:50 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 5:00 [LINUX PATCH v12 0/3] Add support for Arasan NAND Flash controller Naga Sureshkumar Relli
2018-11-09 5:00 ` [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation Naga Sureshkumar Relli
2018-11-09 6:28 ` Boris Brezillon
2018-11-09 12:33 ` Naga Sureshkumar Relli
2018-11-09 12:54 ` Miquel Raynal
2018-11-09 13:19 ` Naga Sureshkumar Relli
2018-11-16 11:50 ` Martin Lund
2018-11-16 12:10 ` Martin Lund
2018-11-16 12:33 ` Michal Simek
2018-11-16 13:50 ` Naga Sureshkumar Relli [this message]
2018-11-16 14:22 ` Martin Lund
2018-11-09 5:00 ` [LINUX PATCH v12 2/3] mtd: rawnand: Add an option to get sdr timing mode number Naga Sureshkumar Relli
2018-11-09 5:00 ` [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Naga Sureshkumar Relli
2018-11-09 8:07 ` Boris Brezillon
2018-11-09 13:18 ` Naga Sureshkumar Relli
2018-11-09 23:03 ` kbuild test robot
2018-11-12 10:55 ` Martin Lund
2018-11-12 10:58 ` Boris Brezillon
2018-11-12 12:43 ` Naga Sureshkumar Relli
2018-11-15 9:34 ` Naga Sureshkumar Relli
2018-11-18 18:52 ` Miquel Raynal
2018-11-18 19:43 ` Boris Brezillon
2018-11-19 6:20 ` Naga Sureshkumar Relli
2018-11-19 8:02 ` Boris Brezillon
2018-11-20 7:02 ` Naga Sureshkumar Relli
2018-11-20 11:02 ` Boris Brezillon
2018-11-20 12:36 ` Miquel Raynal
2018-11-23 13:53 ` Naga Sureshkumar Relli
2018-12-12 5:27 ` Naga Sureshkumar Relli
2018-12-12 8:11 ` Miquel Raynal
2018-12-12 9:04 ` Naga Sureshkumar Relli
2018-12-12 9:09 ` Miquel Raynal
2018-12-12 13:07 ` Naga Sureshkumar Relli
2018-12-12 13:18 ` Miquel Raynal
2018-12-17 13:21 ` Naga Sureshkumar Relli
2018-12-17 16:41 ` Miquel Raynal
2018-12-18 5:33 ` Naga Sureshkumar Relli
2018-12-19 14:26 ` Miquel Raynal
2018-12-21 7:36 ` Naga Sureshkumar Relli
2019-01-28 6:04 ` Naga Sureshkumar Relli
2019-01-28 9:27 ` Miquel Raynal
2019-01-28 9:35 ` Naga Sureshkumar Relli
2019-06-19 4:44 ` Naga Sureshkumar Relli
2019-06-27 16:27 ` Miquel Raynal
2019-06-28 4:20 ` Naga Sureshkumar Relli
2018-11-15 16:45 ` Dan Carpenter
2018-11-20 16:24 ` Boris Brezillon
2018-12-04 9:18 ` Naga Sureshkumar Relli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR02MB26231009A82C0372F62B5292AFDD0@MWHPR02MB2623.namprd02.prod.outlook.com \
--to=nagasure@xilinx.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=martin.lund@keep-it-simple.com \
--cc=michals@xilinx.com \
--cc=miquel.raynal@bootlin.com \
--cc=nagasuresh12@gmail.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).