* [PATCH] irqchip: gic-v3: remove dead code in gic_iterate_rdists
@ 2018-12-17 7:51 Peng Fan
0 siblings, 0 replies; only message in thread
From: Peng Fan @ 2018-12-17 7:51 UTC (permalink / raw)
To: marc.zyngier, jason, tglx; +Cc: linux-kernel, dl-linux-imx, Peng Fan
In gic_iterate_rdists, ret will never be 0 when `ret ? -ENODEV : 0` at
the end of function, so let's directly return -ENODEV.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/irqchip/irq-gic-v3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 8f87f40c9460..9d6e802e29ce 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -425,7 +425,7 @@ static void __init gic_dist_init(void)
static int gic_iterate_rdists(int (*fn)(struct redist_region *, void __iomem *))
{
- int ret = -ENODEV;
+ int ret;
int i;
for (i = 0; i < gic_data.nr_redist_regions; i++) {
@@ -459,7 +459,7 @@ static int gic_iterate_rdists(int (*fn)(struct redist_region *, void __iomem *))
} while (!(typer & GICR_TYPER_LAST));
}
- return ret ? -ENODEV : 0;
+ return -ENODEV;
}
static int __gic_populate_rdist(struct redist_region *region, void __iomem *ptr)
--
2.14.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-12-17 7:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-17 7:51 [PATCH] irqchip: gic-v3: remove dead code in gic_iterate_rdists Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).