From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Ulf Hansson <ulf.hansson@linaro.org>,
Arun Kumar Neelakantam <aneela@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] soc: qcom: Add AOSS QMP genpd provider
Date: Mon, 14 Jan 2019 15:29:30 -0800 [thread overview]
Message-ID: <20190114232930.GE9278@minitux> (raw)
In-Reply-To: <154750565372.169631.9416138415370937156@swboyd.mtv.corp.google.com>
On Mon 14 Jan 14:40 PST 2019, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2019-01-06 00:09:11)
> > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> > index dda19471057f..d81256ef5055 100644
> > --- a/drivers/soc/qcom/Kconfig
> > +++ b/drivers/soc/qcom/Kconfig
> > @@ -12,6 +12,15 @@ config QCOM_AOSS_QMP
> > micro-controller in the AOSS, using QMP, to control certain resource
> > that are not exposed through RPMh.
> >
> > +config QCOM_AOSS_QMP_PD
> > + tristate "Qualcomm AOSS Messaging Power Domain driver"
> > + depends on QCOM_AOSS_QMP
> > + select PM_GENERIC_DOMAINS
> > + help
> > + This driver provides the means of controlling the AOSSs handling of
>
> Is that possesive? AOSS's?
>
That's correct, will fix.
> > + low-power state for resources related to the remoteproc subsystems as
> > + well as controlling the debug clocks.
> > +
> > config QCOM_COMMAND_DB
> > bool "Qualcomm Command DB"
> > depends on ARCH_QCOM || COMPILE_TEST
> > diff --git a/drivers/soc/qcom/aoss-qmp-pd.c b/drivers/soc/qcom/aoss-qmp-pd.c
> > new file mode 100644
> > index 000000000000..62b8fcb9d09e
> > --- /dev/null
> > +++ b/drivers/soc/qcom/aoss-qmp-pd.c
> > @@ -0,0 +1,135 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2018, Linaro Ltd
> > + */
> > +#include <linux/module.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/pm_domain.h>
> > +#include <linux/soc/qcom/aoss-qmp.h>
> > +#include <dt-bindings/power/qcom-aoss-qmp.h>
> > +
> > +struct qmp_pd {
> > + struct qmp *qmp;
> > +
> > + struct generic_pm_domain pd;
> > +
> > + const char *name;
> > +};
> > +
> > +#define to_qmp_pd_resource(res) container_of(res, struct qmp_pd, pd)
> > +
> > +struct qmp_pd_resource {
> > + const char *name;
> > + int (*on)(struct generic_pm_domain *domain);
> > + int (*off)(struct generic_pm_domain *domain);
> > +};
> > +
> > +static int qmp_pd_clock_toggle(struct qmp_pd *res, bool enable)
> > +{
> > + char buf[96];
>
> Is 96 calculated from somewhere? Can it be a define because it's quite
> magical.
>
This is inherited by downstream, I know it has to be % 4, I'll check and
update accordingly.
Thanks,
Bjorn
next prev parent reply other threads:[~2019-01-14 23:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 8:09 [PATCH v2 0/7] Qualcomm AOSS QMP side channel binding and driver Bjorn Andersson
2019-01-06 8:09 ` [PATCH v2 1/7] dt-bindings: soc: qcom: Add AOSS QMP binding Bjorn Andersson
2019-01-11 22:10 ` Rob Herring
2019-01-14 22:30 ` Stephen Boyd
2019-01-06 8:09 ` [PATCH v2 2/7] soc: qcom: Add AOSS QMP communication driver Bjorn Andersson
2019-01-10 12:48 ` Arun Kumar Neelakantam
2019-01-14 22:36 ` Stephen Boyd
2019-01-14 23:20 ` Bjorn Andersson
2019-01-06 8:09 ` [PATCH v2 3/7] soc: qcom: Add AOSS QMP genpd provider Bjorn Andersson
2019-01-10 4:59 ` Sai Prakash Ranjan
2019-01-14 22:40 ` Stephen Boyd
2019-01-14 23:29 ` Bjorn Andersson [this message]
2019-01-06 8:09 ` [PATCH v2 4/7] remoteproc: q6v5-mss: Vote for rpmh power domains Bjorn Andersson
2019-01-09 14:39 ` Sibi Sankar
2019-01-06 8:09 ` [PATCH v2 5/7] remoteproc: q6v5-mss: Active powerdomain for SDM845 Bjorn Andersson
2019-01-09 14:40 ` Sibi Sankar
2019-01-06 8:09 ` [PATCH v2 6/7] amba: Allow pclk to be controlled by power domain Bjorn Andersson
2019-01-06 8:09 ` [(RFC) PATCH v2 7/7] soc: qcom: aoss-qmp: Add cooling device support Bjorn Andersson
2019-01-11 22:11 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114232930.GE9278@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).