From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: f.suligoi@asem.it, jeffrey.t.kirsher@intel.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter
Date: Thu, 28 Feb 2019 11:47:07 -0800 (PST) [thread overview]
Message-ID: <20190228.114707.11382969767373748.davem@davemloft.net> (raw)
In-Reply-To: <20190228192958.GA24085@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Thu, 28 Feb 2019 20:29:58 +0100
> On Thu, Feb 28, 2019 at 05:13:27PM +0000, Flavio Suligoi wrote:
>> > > Hi Andrew,
>> > >
>> > > we produce a lot of boards and we have to change the MAC address,
>> > > from u-boot, for every board. So I must save in the u-boot
>> > > environment (SPI NOR flash) the MAC address for every board.
>> >
>> > Hi Flavio
>> >
>> > u-boot should be able to write the MAC address in the correct part of
>> > device tree. Boards have been doing this a long time.
>> >
>> > Module parameters are considered bad. You should only do it if you
>> > have no other option. Here you do have another options, so it is going
>> > to be a hard sell getting David to access your patch.
>> >
>> > You will have more success by adding a call to
>> > eth_platform_get_mac_address() to the e1000e driver.
>>
>> You have right, and thanks for your suggestions,
>> but with a kernel parameter I can use the same method
>> for any board where the NVM is missed, independently of any architecture
>> (with or without the device tree presence - ARM or x86 or others).
>
> Hi Flavio
>
> Well, lets wait for David to say what he thinks about the module
> parameter.
I already rejected this, no way... Drivers that already have the
unacceptable module parameter are no an argument for spreading this
mistake further.
next prev parent reply other threads:[~2019-02-28 19:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 9:20 [PATCH] net: e1000e: add MAC address kernel cmd line parameter Flavio Suligoi
2019-02-28 13:38 ` [PATCH v2] " Flavio Suligoi
2019-02-28 13:52 ` [PATCH v3] " Flavio Suligoi
2019-02-28 15:32 ` Andrew Lunn
2019-02-28 15:51 ` Flavio Suligoi
2019-02-28 16:37 ` Andrew Lunn
2019-02-28 17:13 ` Flavio Suligoi
2019-02-28 19:29 ` Andrew Lunn
2019-02-28 19:47 ` David Miller [this message]
2019-03-01 8:15 ` Flavio Suligoi
2019-02-28 18:21 ` [PATCH] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228.114707.11382969767373748.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.suligoi@asem.it \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).