From: Andrew Lunn <andrew@lunn.ch>
To: Flavio Suligoi <f.suligoi@asem.it>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
"David S . Miller" <davem@davemloft.net>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] net: e1000e: add MAC address kernel cmd line parameter
Date: Thu, 28 Feb 2019 20:29:58 +0100 [thread overview]
Message-ID: <20190228192958.GA24085@lunn.ch> (raw)
In-Reply-To: <6a7a37813e71420b929c769dd1e77664@asem.it>
On Thu, Feb 28, 2019 at 05:13:27PM +0000, Flavio Suligoi wrote:
> > > Hi Andrew,
> > >
> > > we produce a lot of boards and we have to change the MAC address,
> > > from u-boot, for every board. So I must save in the u-boot
> > > environment (SPI NOR flash) the MAC address for every board.
> >
> > Hi Flavio
> >
> > u-boot should be able to write the MAC address in the correct part of
> > device tree. Boards have been doing this a long time.
> >
> > Module parameters are considered bad. You should only do it if you
> > have no other option. Here you do have another options, so it is going
> > to be a hard sell getting David to access your patch.
> >
> > You will have more success by adding a call to
> > eth_platform_get_mac_address() to the e1000e driver.
>
> You have right, and thanks for your suggestions,
> but with a kernel parameter I can use the same method
> for any board where the NVM is missed, independently of any architecture
> (with or without the device tree presence - ARM or x86 or others).
Hi Flavio
Well, lets wait for David to say what he thinks about the module
parameter.
Andrew
next prev parent reply other threads:[~2019-02-28 19:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 9:20 [PATCH] net: e1000e: add MAC address kernel cmd line parameter Flavio Suligoi
2019-02-28 13:38 ` [PATCH v2] " Flavio Suligoi
2019-02-28 13:52 ` [PATCH v3] " Flavio Suligoi
2019-02-28 15:32 ` Andrew Lunn
2019-02-28 15:51 ` Flavio Suligoi
2019-02-28 16:37 ` Andrew Lunn
2019-02-28 17:13 ` Flavio Suligoi
2019-02-28 19:29 ` Andrew Lunn [this message]
2019-02-28 19:47 ` David Miller
2019-03-01 8:15 ` Flavio Suligoi
2019-02-28 18:21 ` [PATCH] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228192958.GA24085@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.suligoi@asem.it \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).