* [PATCH] arm64/stacktrace: Export save_stack_trace_regs()
@ 2019-03-01 20:00 William Cohen
2019-03-19 12:59 ` Catalin Marinas
0 siblings, 1 reply; 2+ messages in thread
From: William Cohen @ 2019-03-01 20:00 UTC (permalink / raw)
To: catalin.marinas, will.deacon, linux-kernel; +Cc: William Cohen
The ARM64 implements the save_stack_trace_regs function, but it is
unusable for any diagnostic tooling compiled as a kernel module due
the missing EXPORT_SYMBOL_GPL for the function. Export
save_stack_trace_regs() to align with other architectures such as
s390, openrisc, and powerpc. This is similar to the ARM64 export of
save_stack_trace_tsk() added in git commit e27c7fa015d6.
Signed-off-by: William Cohen <wcohen@redhat.com>
---
arch/arm64/kernel/stacktrace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index 1a29f2695ff2..d908b5e9e949 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -143,6 +143,7 @@ void save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
if (trace->nr_entries < trace->max_entries)
trace->entries[trace->nr_entries++] = ULONG_MAX;
}
+EXPORT_SYMBOL_GPL(save_stack_trace_regs);
static noinline void __save_stack_trace(struct task_struct *tsk,
struct stack_trace *trace, unsigned int nosched)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64/stacktrace: Export save_stack_trace_regs()
2019-03-01 20:00 [PATCH] arm64/stacktrace: Export save_stack_trace_regs() William Cohen
@ 2019-03-19 12:59 ` Catalin Marinas
0 siblings, 0 replies; 2+ messages in thread
From: Catalin Marinas @ 2019-03-19 12:59 UTC (permalink / raw)
To: William Cohen; +Cc: will.deacon, linux-kernel
On Fri, Mar 01, 2019 at 03:00:41PM -0500, William Cohen wrote:
> The ARM64 implements the save_stack_trace_regs function, but it is
> unusable for any diagnostic tooling compiled as a kernel module due
> the missing EXPORT_SYMBOL_GPL for the function. Export
> save_stack_trace_regs() to align with other architectures such as
> s390, openrisc, and powerpc. This is similar to the ARM64 export of
> save_stack_trace_tsk() added in git commit e27c7fa015d6.
>
> Signed-off-by: William Cohen <wcohen@redhat.com>
Queued for 5.1-rc2. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-19 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 20:00 [PATCH] arm64/stacktrace: Export save_stack_trace_regs() William Cohen
2019-03-19 12:59 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).