* [PATCH v2] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port
@ 2019-03-01 7:26 Michal Vokáč
2019-03-04 5:33 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Michal Vokáč @ 2019-03-01 7:26 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Andrew Lunn, devicetree, linux-kernel,
Michal Vokáč
Use rgmii-id phy mode for the CPU port (MAC0) of the QCA8334 switch
to add delays to both Tx and Rx clock.
It worked with the rgmii mode before because the qca8k driver
(incorrectly) enabled delays in that mode and rgmii-id was not
implemented at all.
Commit 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
removed the delays from the RGMII mode and hence broke the networking.
To fix the problem, commit a968b5e9d587 ("net: dsa: qca8k: Enable delay
for RGMII_ID mode") was introduced.
Now the correct phy mode is available so use it.
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
Changes in v2:
- Reworded commit message - added more details regarding the issue.
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
index b715ab0fa1ff..091d829f6b05 100644
--- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
+++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
@@ -125,7 +125,7 @@
ethphy0: port@0 {
reg = <0>;
label = "cpu";
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
ethernet = <&fec>;
fixed-link {
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port
2019-03-01 7:26 [PATCH v2] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port Michal Vokáč
@ 2019-03-04 5:33 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2019-03-04 5:33 UTC (permalink / raw)
To: Michal Vokáč; +Cc: Rob Herring, Andrew Lunn, devicetree, linux-kernel
On Fri, Mar 01, 2019 at 08:26:42AM +0100, Michal Vokáč wrote:
> Use rgmii-id phy mode for the CPU port (MAC0) of the QCA8334 switch
> to add delays to both Tx and Rx clock.
>
> It worked with the rgmii mode before because the qca8k driver
> (incorrectly) enabled delays in that mode and rgmii-id was not
> implemented at all.
>
> Commit 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
> removed the delays from the RGMII mode and hence broke the networking.
>
> To fix the problem, commit a968b5e9d587 ("net: dsa: qca8k: Enable delay
> for RGMII_ID mode") was introduced.
>
> Now the correct phy mode is available so use it.
>
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-04 5:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 7:26 [PATCH v2] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port Michal Vokáč
2019-03-04 5:33 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).