linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: linux-arm-kernel@lists.infradead.org
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Thierry Reding" <treding@nvidia.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Johan Hovold" <johan@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Subject: [PATCH 3/5] ARM: dts: imx50: Add PHY node for usbotg and adjust clocks
Date: Tue, 19 Mar 2019 16:24:18 +0100	[thread overview]
Message-ID: <20190319152421.16179-4-j.neuschaefer@gmx.net> (raw)
In-Reply-To: <20190319152421.16179-1-j.neuschaefer@gmx.net>

Even though the ChipIdea USB controller binding[1] doesn't specify the
properties that reference a PHY as required, the Linux driver
requires[2] such a reference.

The clock situation is like on i.MX53: The USB controller is clocked
from IMX5_CLK_USBOH3_GATE and the PHY from IMX5_CLK_USB_PHY1_GATE.

[1]: Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
[2]: Search for EINVAL in drivers/usb/chipidea/ci_hdrc_imx.c

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 arch/arm/boot/dts/imx50.dtsi | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
index ee1e3e8bf4ec..e5632ce24ba0 100644
--- a/arch/arm/boot/dts/imx50.dtsi
+++ b/arch/arm/boot/dts/imx50.dtsi
@@ -76,6 +76,14 @@
 		};
 	};

+	usbphy0: usbphy-0 {
+		compatible = "usb-nop-xceiv";
+		clocks = <&clks IMX5_CLK_USB_PHY1_GATE>;
+		clock-names = "main_clk";
+		#phy-cells = <0>;
+		status = "okay";
+	};
+
 	soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
@@ -187,7 +195,8 @@
 				compatible = "fsl,imx50-usb", "fsl,imx27-usb";
 				reg = <0x53f80000 0x0200>;
 				interrupts = <18>;
-				clocks = <&clks IMX5_CLK_USB_PHY1_GATE>;
+				clocks = <&clks IMX5_CLK_USBOH3_GATE>;
+				fsl,usbphy = <&usbphy0>;
 				status = "disabled";
 			};

--
2.20.1


  parent reply	other threads:[~2019-03-19 15:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 15:24 [PATCH 0/5] ARM: Initial devicetree for Kobo Aura Jonathan Neuschäfer
2019-03-19 15:24 ` [PATCH 1/5] dt-bindings: Add vendor prefix for Rakuten Kobo, Inc Jonathan Neuschäfer
2019-03-19 15:24 ` [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS Jonathan Neuschäfer
2019-03-22  1:31   ` Shawn Guo
2019-03-26 16:26     ` Jonathan Neuschäfer
2019-03-29  2:44       ` Shawn Guo
2019-03-19 15:24 ` Jonathan Neuschäfer [this message]
2019-03-22  1:41   ` [PATCH 3/5] ARM: dts: imx50: Add PHY node for usbotg and adjust clocks Shawn Guo
2019-03-19 15:24 ` [PATCH 4/5] ARM: dts: imx50-kobo-aura: Enable USB support Jonathan Neuschäfer
2019-03-19 15:24 ` [PATCH 5/5] ARM: dts: imx50: Fix the numbering of the I2C controllers Jonathan Neuschäfer
2019-03-22  1:46   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190319152421.16179-4-j.neuschaefer@gmx.net \
    --to=j.neuschaefer@gmx.net \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=heiko@sntech.de \
    --cc=jagan@amarulasolutions.com \
    --cc=johan@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).