From: Shawn Guo <shawnguo@kernel.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Thierry Reding <treding@nvidia.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Heiko Stuebner <heiko@sntech.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Johan Hovold <johan@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS
Date: Fri, 29 Mar 2019 10:44:50 +0800 [thread overview]
Message-ID: <20190329024449.GM12513@dragon> (raw)
In-Reply-To: <20190326162653.GD2095@latitude>
On Tue, Mar 26, 2019 at 05:26:53PM +0100, Jonathan Neuschäfer wrote:
> Hi, thanks for your comments. I'll address them in v2.
>
> On Fri, Mar 22, 2019 at 09:31:53AM +0800, Shawn Guo wrote:
> > On Tue, Mar 19, 2019 at 04:24:17PM +0100, Jonathan Neuschäfer wrote:
> > > The Kobo Aura is an e-book reader released in 2013.
> [...]
> > > + sd2_pwrseq: pwrseq {
> > > + compatible = "mmc-pwrseq-simple";
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_sd2_reset>;
> > > +
> >
> > Please do not have random newlines.
>
> Does that apply to all empty lines between properties?
Yes, that's what we do for i.MX device trees.
>
> >
> > > + reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> [...]
> > > +&iomuxc {
> > > + pinctrl_uart2: uart2 {
> > > + fsl,pins = <
> > > + MX50_PAD_UART2_TXD__UART2_TXD_MUX 0x1e4
> > > + MX50_PAD_UART2_RXD__UART2_RXD_MUX 0x1e4
> > > + >;
> > > + };
> > > +
> > > + pinctrl_i2c1: i2c1 {
> >
> > Please sort these pinctrl nodes alphabetically.
>
> It doesn't make a difference here, but should I generally sort by name
> or by label in cases like this one?
Keep using the naming schema below, and it always makes no difference
then.
pinctrl_xxx: xxx
Shawn
next prev parent reply other threads:[~2019-03-29 2:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 15:24 [PATCH 0/5] ARM: Initial devicetree for Kobo Aura Jonathan Neuschäfer
2019-03-19 15:24 ` [PATCH 1/5] dt-bindings: Add vendor prefix for Rakuten Kobo, Inc Jonathan Neuschäfer
2019-03-19 15:24 ` [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS Jonathan Neuschäfer
2019-03-22 1:31 ` Shawn Guo
2019-03-26 16:26 ` Jonathan Neuschäfer
2019-03-29 2:44 ` Shawn Guo [this message]
2019-03-19 15:24 ` [PATCH 3/5] ARM: dts: imx50: Add PHY node for usbotg and adjust clocks Jonathan Neuschäfer
2019-03-22 1:41 ` Shawn Guo
2019-03-19 15:24 ` [PATCH 4/5] ARM: dts: imx50-kobo-aura: Enable USB support Jonathan Neuschäfer
2019-03-19 15:24 ` [PATCH 5/5] ARM: dts: imx50: Fix the numbering of the I2C controllers Jonathan Neuschäfer
2019-03-22 1:46 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329024449.GM12513@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=j.neuschaefer@gmx.net \
--cc=jagan@amarulasolutions.com \
--cc=johan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).