linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hwrng: omap - Set default quality
@ 2019-03-11 10:58 Rouven Czerwinski
  2019-03-22 13:03 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Rouven Czerwinski @ 2019-03-11 10:58 UTC (permalink / raw)
  To: Herbert Xu
  Cc: kernel, Rouven Czerwinski, Deepak Saxena, Matt Mackall,
	Arnd Bergmann, Greg Kroah-Hartman, linux-crypto, linux-kernel

Newer combinations of the glibc, kernel and openssh can result in long initial
startup times on OMAP devices:

[    6.671425] systemd-rc-once[102]: Creating ED25519 key; this may take some time ...
[  142.652491] systemd-rc-once[102]: Creating ED25519 key; done.

due to the blocking getrandom(2) system call:

[  142.610335] random: crng init done

Set the quality level for the omap hwrng driver allowing the kernel to use the
hwrng as an entropy source at boot.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
 drivers/char/hw_random/omap-rng.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
index b65ff6962899..e9b6ac61fb7f 100644
--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -443,6 +443,7 @@ static int omap_rng_probe(struct platform_device *pdev)
 	priv->rng.read = omap_rng_do_read;
 	priv->rng.init = omap_rng_init;
 	priv->rng.cleanup = omap_rng_cleanup;
+	priv->rng.quality = 900;
 
 	priv->rng.priv = (unsigned long)priv;
 	platform_set_drvdata(pdev, priv);
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hwrng: omap - Set default quality
  2019-03-11 10:58 [PATCH] hwrng: omap - Set default quality Rouven Czerwinski
@ 2019-03-22 13:03 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-03-22 13:03 UTC (permalink / raw)
  To: Rouven Czerwinski
  Cc: kernel, Deepak Saxena, Matt Mackall, Arnd Bergmann,
	Greg Kroah-Hartman, linux-crypto, linux-kernel

On Mon, Mar 11, 2019 at 11:58:57AM +0100, Rouven Czerwinski wrote:
> Newer combinations of the glibc, kernel and openssh can result in long initial
> startup times on OMAP devices:
> 
> [    6.671425] systemd-rc-once[102]: Creating ED25519 key; this may take some time ...
> [  142.652491] systemd-rc-once[102]: Creating ED25519 key; done.
> 
> due to the blocking getrandom(2) system call:
> 
> [  142.610335] random: crng init done
> 
> Set the quality level for the omap hwrng driver allowing the kernel to use the
> hwrng as an entropy source at boot.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  drivers/char/hw_random/omap-rng.c | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-22 13:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 10:58 [PATCH] hwrng: omap - Set default quality Rouven Czerwinski
2019-03-22 13:03 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).