* [PATCH] riscv: fix accessing 8-byte variable from RV32
@ 2019-03-22 6:37 Alan Kao
2019-03-22 13:34 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Alan Kao @ 2019-03-22 6:37 UTC (permalink / raw)
To: linux-kernel, linux-riscv, palmer; +Cc: Alan Kao, Greentime Hu, Vincent Chen
A memory save operation to 8-byte variable in RV32 is divided into
two sw instructions in the put_user macro. The current fixup returns
execution flow to the second sw instead of the one after it.
This patch fixes this fixup code according to the load access part.
Signed-off-by: Alan Kao<alankao@andestech.com>
Cc: Greentime Hu <greentime@andestech.com>
Cc: Vincent Chen <deanbo422@gmail.com>
---
arch/riscv/include/asm/uaccess.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/include/asm/uaccess.h b/arch/riscv/include/asm/uaccess.h
index a00168b..fb53a80 100644
--- a/arch/riscv/include/asm/uaccess.h
+++ b/arch/riscv/include/asm/uaccess.h
@@ -300,7 +300,7 @@ do { \
" .balign 4\n" \
"4:\n" \
" li %0, %6\n" \
- " jump 2b, %1\n" \
+ " jump 3b, %1\n" \
" .previous\n" \
" .section __ex_table,\"a\"\n" \
" .balign " RISCV_SZPTR "\n" \
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] riscv: fix accessing 8-byte variable from RV32
2019-03-22 6:37 [PATCH] riscv: fix accessing 8-byte variable from RV32 Alan Kao
@ 2019-03-22 13:34 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2019-03-22 13:34 UTC (permalink / raw)
To: Alan Kao; +Cc: linux-kernel, linux-riscv, palmer, Vincent Chen, Greentime Hu
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-22 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 6:37 [PATCH] riscv: fix accessing 8-byte variable from RV32 Alan Kao
2019-03-22 13:34 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).