* [PATCH v2 1/1] bsr: do not use assignment in if condition
@ 2019-05-15 15:09 parna.naveenkumar
2019-05-15 15:14 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: parna.naveenkumar @ 2019-05-15 15:09 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, Naveen Kumar Parna
From: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
checkpatch.pl does not like assignment in if condition
Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
---
drivers/char/bsr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index d16ba62d03a0..935d4b300340 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -322,7 +322,8 @@ static int __init bsr_init(void)
goto out_err_2;
}
- if ((ret = bsr_create_devs(np)) < 0) {
+ ret = bsr_create_devs(np);
+ if (ret < 0) {
np = NULL;
goto out_err_3;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] bsr: do not use assignment in if condition
2019-05-15 15:09 [PATCH v2 1/1] bsr: do not use assignment in if condition parna.naveenkumar
@ 2019-05-15 15:14 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-05-15 15:14 UTC (permalink / raw)
To: parna.naveenkumar; +Cc: arnd, linux-kernel
On Wed, May 15, 2019 at 08:39:52PM +0530, parna.naveenkumar@gmail.com wrote:
> From: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
>
> checkpatch.pl does not like assignment in if condition
>
> Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
> ---
> drivers/char/bsr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
If you do a v2, you always have to show below the --- line what changed
from the previous version.
v3? :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-15 15:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 15:09 [PATCH v2 1/1] bsr: do not use assignment in if condition parna.naveenkumar
2019-05-15 15:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).