* [PATCH] staging: rtl8712: Replace function r8712_init_mlme_priv
@ 2019-05-30 20:55 Nishka Dasgupta
2019-05-31 9:29 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Nishka Dasgupta @ 2019-05-30 20:55 UTC (permalink / raw)
To: larry.finger, florian.c.schilhabel, gregkh, himadri18.07,
dan.carpenter, colin.king, straube.linux, yangx92, devel,
linux-kernel
Cc: Nishka Dasgupta
Delete r8712_init_mlme_priv as it does nothing except call
_init_mlme_priv, and rename _init_mlme_priv to
r8712_init_mlme_priv.
Change the type of the new r8712_init_mlme_priv (formerly _init_mlme_priv)
to (non-static) int, from static sint.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 7c7267d0fc9e..57d8e7dceef7 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -29,7 +29,7 @@
static void update_ht_cap(struct _adapter *padapter, u8 *pie, uint ie_len);
-static sint _init_mlme_priv(struct _adapter *padapter)
+int r8712_init_mlme_priv(struct _adapter *padapter)
{
sint i;
u8 *pbuf;
@@ -205,11 +205,6 @@ u8 *r8712_get_capability_from_ie(u8 *ie)
return ie + 8 + 2;
}
-int r8712_init_mlme_priv(struct _adapter *padapter)
-{
- return _init_mlme_priv(padapter);
-}
-
void r8712_free_mlme_priv(struct mlme_priv *pmlmepriv)
{
kfree(pmlmepriv->free_bss_buf);
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8712: Replace function r8712_init_mlme_priv
2019-05-30 20:55 [PATCH] staging: rtl8712: Replace function r8712_init_mlme_priv Nishka Dasgupta
@ 2019-05-31 9:29 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-05-31 9:29 UTC (permalink / raw)
To: Nishka Dasgupta
Cc: larry.finger, florian.c.schilhabel, gregkh, himadri18.07,
colin.king, straube.linux, yangx92, devel, linux-kernel
On Fri, May 31, 2019 at 02:25:31AM +0530, Nishka Dasgupta wrote:
> Delete r8712_init_mlme_priv as it does nothing except call
> _init_mlme_priv, and rename _init_mlme_priv to
> r8712_init_mlme_priv.
> Change the type of the new r8712_init_mlme_priv (formerly _init_mlme_priv)
> to (non-static) int, from static sint.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good, thanks.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-31 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-30 20:55 [PATCH] staging: rtl8712: Replace function r8712_init_mlme_priv Nishka Dasgupta
2019-05-31 9:29 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).