* [PATCH] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag
@ 2019-07-04 19:10 Hariprasad Kelam
2019-07-05 20:10 ` [alsa-devel] " Ladislav Michl
0 siblings, 1 reply; 3+ messages in thread
From: Hariprasad Kelam @ 2019-07-04 19:10 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Srinivas Kandagatla, Vinod Koul, Hariprasad Kelam, Gen Zhang,
Dan Carpenter, alsa-devel, linux-kernel
Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
handler finished".
fixes below issue reported by coccicheck
sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
sound/soc/codecs/wcd9335.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index 85737fe..7ab9bf6f 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = {
static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
{
int irq, ret, i;
+ unsigned long irqflags;
+
+ irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT;
for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) {
irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq);
@@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
ret = devm_request_threaded_irq(wcd->dev, irq, NULL,
wcd9335_irqs[i].handler,
- IRQF_TRIGGER_RISING,
+ irqflags,
wcd9335_irqs[i].name, wcd);
if (ret) {
dev_err(wcd->dev, "Failed to request %s\n",
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag
2019-07-04 19:10 [PATCH] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag Hariprasad Kelam
@ 2019-07-05 20:10 ` Ladislav Michl
2019-07-10 2:02 ` Hariprasad Kelam
0 siblings, 1 reply; 3+ messages in thread
From: Ladislav Michl @ 2019-07-05 20:10 UTC (permalink / raw)
To: Hariprasad Kelam
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Srinivas Kandagatla, Vinod Koul, Gen Zhang, Dan Carpenter,
alsa-devel, linux-kernel
On Fri, Jul 05, 2019 at 12:40:26AM +0530, Hariprasad Kelam wrote:
> Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
> handler finished".
>
> fixes below issue reported by coccicheck
>
> sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no
> primary handler requested without IRQF_ONESHOT
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> sound/soc/codecs/wcd9335.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> index 85737fe..7ab9bf6f 100644
> --- a/sound/soc/codecs/wcd9335.c
> +++ b/sound/soc/codecs/wcd9335.c
> @@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = {
> static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
> {
> int irq, ret, i;
> + unsigned long irqflags;
> +
> + irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT;
Why does this change trigger adding a variable?
> for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) {
> irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq);
> @@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
>
> ret = devm_request_threaded_irq(wcd->dev, irq, NULL,
> wcd9335_irqs[i].handler,
> - IRQF_TRIGGER_RISING,
> + irqflags,
> wcd9335_irqs[i].name, wcd);
> if (ret) {
> dev_err(wcd->dev, "Failed to request %s\n",
> --
> 2.7.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag
2019-07-05 20:10 ` [alsa-devel] " Ladislav Michl
@ 2019-07-10 2:02 ` Hariprasad Kelam
0 siblings, 0 replies; 3+ messages in thread
From: Hariprasad Kelam @ 2019-07-10 2:02 UTC (permalink / raw)
To: Ladislav Michl, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Srinivas Kandagatla, Vinod Koul, Gen Zhang,
Dan Carpenter, alsa-devel, linux-kernel
On Fri, Jul 05, 2019 at 10:10:06PM +0200, Ladislav Michl wrote:
> On Fri, Jul 05, 2019 at 12:40:26AM +0530, Hariprasad Kelam wrote:
> > Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq
> > handler finished".
> >
> > fixes below issue reported by coccicheck
> >
> > sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no
> > primary handler requested without IRQF_ONESHOT
> >
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> > ---
> > sound/soc/codecs/wcd9335.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> > index 85737fe..7ab9bf6f 100644
> > --- a/sound/soc/codecs/wcd9335.c
> > +++ b/sound/soc/codecs/wcd9335.c
> > @@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = {
> > static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
> > {
> > int irq, ret, i;
> > + unsigned long irqflags;
> > +
> > + irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT;
>
> Why does this change trigger adding a variable?
Yes variable is not required. Will resend the patch without variable.
>
> > for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) {
> > irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq);
> > @@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd)
> >
> > ret = devm_request_threaded_irq(wcd->dev, irq, NULL,
> > wcd9335_irqs[i].handler,
> > - IRQF_TRIGGER_RISING,
> > + irqflags,
> > wcd9335_irqs[i].name, wcd);
> > if (ret) {
> > dev_err(wcd->dev, "Failed to request %s\n",
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-10 2:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04 19:10 [PATCH] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag Hariprasad Kelam
2019-07-05 20:10 ` [alsa-devel] " Ladislav Michl
2019-07-10 2:02 ` Hariprasad Kelam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).