* [PATCH] gve: Remove the exporting of gve_probe
@ 2019-07-14 12:02 Denis Efremov
2019-07-14 19:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Denis Efremov @ 2019-07-14 12:02 UTC (permalink / raw)
To: Catherine Sullivan
Cc: Denis Efremov, Sagi Shahar, Jon Olson, David S. Miller, netdev,
linux-kernel
The function gve_probe is declared static and marked EXPORT_SYMBOL, which
is at best an odd combination. Because the function is not used outside of
the drivers/net/ethernet/google/gve/gve_main.c file it is defined in, this
commit removes the EXPORT_SYMBOL() marking.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
drivers/net/ethernet/google/gve/gve_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
index 24f16e3368cd..e8ee8cac2bbf 100644
--- a/drivers/net/ethernet/google/gve/gve_main.c
+++ b/drivers/net/ethernet/google/gve/gve_main.c
@@ -1192,7 +1192,6 @@ static int gve_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
pci_disable_device(pdev);
return -ENXIO;
}
-EXPORT_SYMBOL(gve_probe);
static void gve_remove(struct pci_dev *pdev)
{
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gve: Remove the exporting of gve_probe
2019-07-14 12:02 [PATCH] gve: Remove the exporting of gve_probe Denis Efremov
@ 2019-07-14 19:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-07-14 19:13 UTC (permalink / raw)
To: efremov; +Cc: csully, sagis, jonolson, netdev, linux-kernel
From: Denis Efremov <efremov@linux.com>
Date: Sun, 14 Jul 2019 15:02:25 +0300
> The function gve_probe is declared static and marked EXPORT_SYMBOL, which
> is at best an odd combination. Because the function is not used outside of
> the drivers/net/ethernet/google/gve/gve_main.c file it is defined in, this
> commit removes the EXPORT_SYMBOL() marking.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-14 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-14 12:02 [PATCH] gve: Remove the exporting of gve_probe Denis Efremov
2019-07-14 19:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).