* [PATCH v6 0/2] Add ST lsm6dso i3c support
@ 2019-07-19 13:30 Vitor Soares
2019-07-19 13:30 ` [PATCH v6 1/2] i3c: move i3c_device_match_id to device.c and export it Vitor Soares
2019-07-19 13:30 ` [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR Vitor Soares
0 siblings, 2 replies; 11+ messages in thread
From: Vitor Soares @ 2019-07-19 13:30 UTC (permalink / raw)
To: linux-iio, linux-i3c, linux-kernel
Cc: lorenzo, gregkh, rafael, bbrezillon, Joao.Pinto, Vitor Soares
This patch-series add i3c support for STM LSM6DSO and LSM6DSR sensors.
It is also introduced i3c support on regmap API. Due to the lack of
i3c devices with HDR feature on the market the support, for now, is only
for i3c SDR mode by using i3c_device_do_priv_xfers() method.
The i3c regmap API is already available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git
tags/regmap-i3c
Change in v6:
Improve kerneldoc
Change in v5:
Remove regmap-i3c patch, already applied in regmap tree
Fix warning when compiling in 64-bit architecture
Change in v4:
remover hw_id variable from st_lsm6dsx_i3c_probe()
Change in v3:
Update st_lsm6dsx_probe() call
Remove i3c_get_device_id() and use i3c_device_match_id()
Changes in v2:
Change i3c_get_device_id() to drivers/i3c/device.c
Add support for LSM6DSR
Vitor Soares (2):
i3c: add i3c_get_device_id helper
iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR
drivers/i3c/device.c | 53 +++++++++++++++++++++++++++
drivers/i3c/master.c | 45 -----------------------
drivers/iio/imu/st_lsm6dsx/Kconfig | 8 +++-
drivers/iio/imu/st_lsm6dsx/Makefile | 1 +
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c | 57 +++++++++++++++++++++++++++++
include/linux/i3c/device.h | 4 ++
6 files changed, 122 insertions(+), 46 deletions(-)
create mode 100644 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v6 1/2] i3c: move i3c_device_match_id to device.c and export it
2019-07-19 13:30 [PATCH v6 0/2] Add ST lsm6dso i3c support Vitor Soares
@ 2019-07-19 13:30 ` Vitor Soares
2019-07-19 13:45 ` Boris Brezillon
2019-07-19 13:30 ` [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR Vitor Soares
1 sibling, 1 reply; 11+ messages in thread
From: Vitor Soares @ 2019-07-19 13:30 UTC (permalink / raw)
To: linux-iio, linux-i3c, linux-kernel
Cc: lorenzo, gregkh, rafael, bbrezillon, Joao.Pinto, Vitor Soares
Some I3C device drivers need to know which entry matches the
i3c_device object passed to the probe function
Let's move i3c_device_match_id() to device.c and export it so it can be
used by drivers.
Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
---
Changes in v6:
Improve kerneldoc
Changes in v5:
Add kerneldoc
Improve commit message
Changes in v4:
None
Changes in v3:
Remove i3c_get_device_id
Move i3c_device_match_id from drivers/i3c/master.c to drivers/i3c/device.c
Export i3c_device_match_id
Changes in v2:
move this function to drivers/i3c/device.c
drivers/i3c/device.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++
drivers/i3c/master.c | 45 ---------------------------------------
include/linux/i3c/device.h | 4 ++++
3 files changed, 57 insertions(+), 45 deletions(-)
diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c
index 69cc040..c15f5ca 100644
--- a/drivers/i3c/device.c
+++ b/drivers/i3c/device.c
@@ -201,6 +201,59 @@ struct i3c_device *dev_to_i3cdev(struct device *dev)
EXPORT_SYMBOL_GPL(dev_to_i3cdev);
/**
+ * i3c_device_match_id() - Returns the i3c_device_id entry matching @i3cdev
+ * @i3cdev: I3C device
+ * @id_table: I3C device match table
+ *
+ * Return: a pointer to an i3c_device_id object or NULL if there's no match.
+ */
+const struct i3c_device_id *
+i3c_device_match_id(struct i3c_device *i3cdev,
+ const struct i3c_device_id *id_table)
+{
+ struct i3c_device_info devinfo;
+ const struct i3c_device_id *id;
+
+ i3c_device_get_info(i3cdev, &devinfo);
+
+ /*
+ * The lower 32bits of the provisional ID is just filled with a random
+ * value, try to match using DCR info.
+ */
+ if (!I3C_PID_RND_LOWER_32BITS(devinfo.pid)) {
+ u16 manuf = I3C_PID_MANUF_ID(devinfo.pid);
+ u16 part = I3C_PID_PART_ID(devinfo.pid);
+ u16 ext_info = I3C_PID_EXTRA_INFO(devinfo.pid);
+
+ /* First try to match by manufacturer/part ID. */
+ for (id = id_table; id->match_flags != 0; id++) {
+ if ((id->match_flags & I3C_MATCH_MANUF_AND_PART) !=
+ I3C_MATCH_MANUF_AND_PART)
+ continue;
+
+ if (manuf != id->manuf_id || part != id->part_id)
+ continue;
+
+ if ((id->match_flags & I3C_MATCH_EXTRA_INFO) &&
+ ext_info != id->extra_info)
+ continue;
+
+ return id;
+ }
+ }
+
+ /* Fallback to DCR match. */
+ for (id = id_table; id->match_flags != 0; id++) {
+ if ((id->match_flags & I3C_MATCH_DCR) &&
+ id->dcr == devinfo.dcr)
+ return id;
+ }
+
+ return NULL;
+}
+EXPORT_SYMBOL_GPL(i3c_device_match_id);
+
+/**
* i3c_driver_register_with_owner() - register an I3C device driver
*
* @drv: driver to register
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 5f4bd52..7667f84 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -270,51 +270,6 @@ static const struct device_type i3c_device_type = {
.uevent = i3c_device_uevent,
};
-static const struct i3c_device_id *
-i3c_device_match_id(struct i3c_device *i3cdev,
- const struct i3c_device_id *id_table)
-{
- struct i3c_device_info devinfo;
- const struct i3c_device_id *id;
-
- i3c_device_get_info(i3cdev, &devinfo);
-
- /*
- * The lower 32bits of the provisional ID is just filled with a random
- * value, try to match using DCR info.
- */
- if (!I3C_PID_RND_LOWER_32BITS(devinfo.pid)) {
- u16 manuf = I3C_PID_MANUF_ID(devinfo.pid);
- u16 part = I3C_PID_PART_ID(devinfo.pid);
- u16 ext_info = I3C_PID_EXTRA_INFO(devinfo.pid);
-
- /* First try to match by manufacturer/part ID. */
- for (id = id_table; id->match_flags != 0; id++) {
- if ((id->match_flags & I3C_MATCH_MANUF_AND_PART) !=
- I3C_MATCH_MANUF_AND_PART)
- continue;
-
- if (manuf != id->manuf_id || part != id->part_id)
- continue;
-
- if ((id->match_flags & I3C_MATCH_EXTRA_INFO) &&
- ext_info != id->extra_info)
- continue;
-
- return id;
- }
- }
-
- /* Fallback to DCR match. */
- for (id = id_table; id->match_flags != 0; id++) {
- if ((id->match_flags & I3C_MATCH_DCR) &&
- id->dcr == devinfo.dcr)
- return id;
- }
-
- return NULL;
-}
-
static int i3c_device_match(struct device *dev, struct device_driver *drv)
{
struct i3c_device *i3cdev;
diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
index 5ecb055..de102e4 100644
--- a/include/linux/i3c/device.h
+++ b/include/linux/i3c/device.h
@@ -188,6 +188,10 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv)
struct device *i3cdev_to_dev(struct i3c_device *i3cdev);
struct i3c_device *dev_to_i3cdev(struct device *dev);
+const struct i3c_device_id *
+i3c_device_match_id(struct i3c_device *i3cdev,
+ const struct i3c_device_id *id_table);
+
static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev,
void *data)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR
2019-07-19 13:30 [PATCH v6 0/2] Add ST lsm6dso i3c support Vitor Soares
2019-07-19 13:30 ` [PATCH v6 1/2] i3c: move i3c_device_match_id to device.c and export it Vitor Soares
@ 2019-07-19 13:30 ` Vitor Soares
2019-07-21 17:16 ` Jonathan Cameron
1 sibling, 1 reply; 11+ messages in thread
From: Vitor Soares @ 2019-07-19 13:30 UTC (permalink / raw)
To: linux-iio, linux-i3c, linux-kernel
Cc: lorenzo, gregkh, rafael, bbrezillon, Joao.Pinto, Vitor Soares
For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in
spi and i2c mode.
The LSM6DSO and LSM6DSR are also i3c capable so let's give i3c support to
them.
Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
---
Changes in v6:
none
Changes in v5:
Move regmap_config declaration inside st_lsm6dsx_i3c_probe()
Fix warning [-Wint-to-void-pointer-cast] when compiling in 64-bit arch
Changes in v4:
Remove hw_id variable
Changes in v3:
Remove unnecessary st_lsm6dsx_i3c_data table used to hold device name
Use st_lsm6dsx_probe new form
Changes in v2:
Add support for LSM6DSR
Set pm_ops to st_lsm6dsx_pm_ops
drivers/iio/imu/st_lsm6dsx/Kconfig | 8 +++-
drivers/iio/imu/st_lsm6dsx/Makefile | 1 +
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c | 57 +++++++++++++++++++++++++++++
3 files changed, 65 insertions(+), 1 deletion(-)
create mode 100644 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig
index 9e59297..6b5a73c 100644
--- a/drivers/iio/imu/st_lsm6dsx/Kconfig
+++ b/drivers/iio/imu/st_lsm6dsx/Kconfig
@@ -1,11 +1,12 @@
config IIO_ST_LSM6DSX
tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors"
- depends on (I2C || SPI)
+ depends on (I2C || SPI || I3C)
select IIO_BUFFER
select IIO_KFIFO_BUF
select IIO_ST_LSM6DSX_I2C if (I2C)
select IIO_ST_LSM6DSX_SPI if (SPI_MASTER)
+ select IIO_ST_LSM6DSX_I3C if (I3C)
help
Say yes here to build support for STMicroelectronics LSM6DSx imu
sensor. Supported devices: lsm6ds3, lsm6ds3h, lsm6dsl, lsm6dsm,
@@ -23,3 +24,8 @@ config IIO_ST_LSM6DSX_SPI
tristate
depends on IIO_ST_LSM6DSX
select REGMAP_SPI
+
+config IIO_ST_LSM6DSX_I3C
+ tristate
+ depends on IIO_ST_LSM6DSX
+ select REGMAP_I3C
diff --git a/drivers/iio/imu/st_lsm6dsx/Makefile b/drivers/iio/imu/st_lsm6dsx/Makefile
index e5f733c..c676965 100644
--- a/drivers/iio/imu/st_lsm6dsx/Makefile
+++ b/drivers/iio/imu/st_lsm6dsx/Makefile
@@ -4,3 +4,4 @@ st_lsm6dsx-y := st_lsm6dsx_core.o st_lsm6dsx_buffer.o \
obj-$(CONFIG_IIO_ST_LSM6DSX) += st_lsm6dsx.o
obj-$(CONFIG_IIO_ST_LSM6DSX_I2C) += st_lsm6dsx_i2c.o
obj-$(CONFIG_IIO_ST_LSM6DSX_SPI) += st_lsm6dsx_spi.o
+obj-$(CONFIG_IIO_ST_LSM6DSX_I3C) += st_lsm6dsx_i3c.o
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
new file mode 100644
index 0000000..57e6331
--- /dev/null
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
+ *
+ * Author: Vitor Soares <vitor.soares@synopsys.com>
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/i3c/device.h>
+#include <linux/i3c/master.h>
+#include <linux/slab.h>
+#include <linux/of.h>
+#include <linux/regmap.h>
+
+#include "st_lsm6dsx.h"
+
+static const struct i3c_device_id st_lsm6dsx_i3c_ids[] = {
+ I3C_DEVICE(0x0104, 0x006C, (void *)ST_LSM6DSO_ID),
+ I3C_DEVICE(0x0104, 0x006B, (void *)ST_LSM6DSR_ID),
+ { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(i3c, st_lsm6dsx_i3c_ids);
+
+static int st_lsm6dsx_i3c_probe(struct i3c_device *i3cdev)
+{
+ struct regmap_config st_lsm6dsx_i3c_regmap_config = {
+ .reg_bits = 8,
+ .val_bits = 8,
+ };
+ const struct i3c_device_id *id = i3c_device_match_id(i3cdev,
+ st_lsm6dsx_i3c_ids);
+ struct regmap *regmap;
+
+ regmap = devm_regmap_init_i3c(i3cdev, &st_lsm6dsx_i3c_regmap_config);
+ if (IS_ERR(regmap)) {
+ dev_err(&i3cdev->dev, "Failed to register i3c regmap %d\n",
+ (int)PTR_ERR(regmap));
+ return PTR_ERR(regmap);
+ }
+
+ return st_lsm6dsx_probe(&i3cdev->dev, 0, (uintptr_t)id->data, regmap);
+}
+
+static struct i3c_driver st_lsm6dsx_driver = {
+ .driver = {
+ .name = "st_lsm6dsx_i3c",
+ .pm = &st_lsm6dsx_pm_ops,
+ },
+ .probe = st_lsm6dsx_i3c_probe,
+ .id_table = st_lsm6dsx_i3c_ids,
+};
+module_i3c_driver(st_lsm6dsx_driver);
+
+MODULE_AUTHOR("Vitor Soares <vitor.soares@synopsys.com>");
+MODULE_DESCRIPTION("STMicroelectronics st_lsm6dsx i3c driver");
+MODULE_LICENSE("GPL v2");
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v6 1/2] i3c: move i3c_device_match_id to device.c and export it
2019-07-19 13:30 ` [PATCH v6 1/2] i3c: move i3c_device_match_id to device.c and export it Vitor Soares
@ 2019-07-19 13:45 ` Boris Brezillon
2019-07-19 15:42 ` Vitor Soares
0 siblings, 1 reply; 11+ messages in thread
From: Boris Brezillon @ 2019-07-19 13:45 UTC (permalink / raw)
To: Vitor Soares
Cc: linux-iio, linux-i3c, linux-kernel, lorenzo, gregkh, rafael,
bbrezillon, Joao.Pinto
On Fri, 19 Jul 2019 15:30:54 +0200
Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> Some I3C device drivers need to know which entry matches the
> i3c_device object passed to the probe function
>
> Let's move i3c_device_match_id() to device.c and export it so it can be
> used by drivers.
>
> Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
Looks good to me. I'll apply the patch when -rc1 is out and provide an
immutable branch for iio maintainers.
> ---
> Changes in v6:
> Improve kerneldoc
>
> Changes in v5:
> Add kerneldoc
> Improve commit message
>
> Changes in v4:
> None
>
> Changes in v3:
> Remove i3c_get_device_id
> Move i3c_device_match_id from drivers/i3c/master.c to drivers/i3c/device.c
> Export i3c_device_match_id
>
> Changes in v2:
> move this function to drivers/i3c/device.c
>
> drivers/i3c/device.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++
> drivers/i3c/master.c | 45 ---------------------------------------
> include/linux/i3c/device.h | 4 ++++
> 3 files changed, 57 insertions(+), 45 deletions(-)
>
> diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c
> index 69cc040..c15f5ca 100644
> --- a/drivers/i3c/device.c
> +++ b/drivers/i3c/device.c
> @@ -201,6 +201,59 @@ struct i3c_device *dev_to_i3cdev(struct device *dev)
> EXPORT_SYMBOL_GPL(dev_to_i3cdev);
>
> /**
> + * i3c_device_match_id() - Returns the i3c_device_id entry matching @i3cdev
> + * @i3cdev: I3C device
> + * @id_table: I3C device match table
> + *
> + * Return: a pointer to an i3c_device_id object or NULL if there's no match.
> + */
> +const struct i3c_device_id *
> +i3c_device_match_id(struct i3c_device *i3cdev,
> + const struct i3c_device_id *id_table)
> +{
> + struct i3c_device_info devinfo;
> + const struct i3c_device_id *id;
> +
> + i3c_device_get_info(i3cdev, &devinfo);
> +
> + /*
> + * The lower 32bits of the provisional ID is just filled with a random
> + * value, try to match using DCR info.
> + */
> + if (!I3C_PID_RND_LOWER_32BITS(devinfo.pid)) {
> + u16 manuf = I3C_PID_MANUF_ID(devinfo.pid);
> + u16 part = I3C_PID_PART_ID(devinfo.pid);
> + u16 ext_info = I3C_PID_EXTRA_INFO(devinfo.pid);
> +
> + /* First try to match by manufacturer/part ID. */
> + for (id = id_table; id->match_flags != 0; id++) {
> + if ((id->match_flags & I3C_MATCH_MANUF_AND_PART) !=
> + I3C_MATCH_MANUF_AND_PART)
> + continue;
> +
> + if (manuf != id->manuf_id || part != id->part_id)
> + continue;
> +
> + if ((id->match_flags & I3C_MATCH_EXTRA_INFO) &&
> + ext_info != id->extra_info)
> + continue;
> +
> + return id;
> + }
> + }
> +
> + /* Fallback to DCR match. */
> + for (id = id_table; id->match_flags != 0; id++) {
> + if ((id->match_flags & I3C_MATCH_DCR) &&
> + id->dcr == devinfo.dcr)
> + return id;
> + }
> +
> + return NULL;
> +}
> +EXPORT_SYMBOL_GPL(i3c_device_match_id);
> +
> +/**
> * i3c_driver_register_with_owner() - register an I3C device driver
> *
> * @drv: driver to register
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 5f4bd52..7667f84 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -270,51 +270,6 @@ static const struct device_type i3c_device_type = {
> .uevent = i3c_device_uevent,
> };
>
> -static const struct i3c_device_id *
> -i3c_device_match_id(struct i3c_device *i3cdev,
> - const struct i3c_device_id *id_table)
> -{
> - struct i3c_device_info devinfo;
> - const struct i3c_device_id *id;
> -
> - i3c_device_get_info(i3cdev, &devinfo);
> -
> - /*
> - * The lower 32bits of the provisional ID is just filled with a random
> - * value, try to match using DCR info.
> - */
> - if (!I3C_PID_RND_LOWER_32BITS(devinfo.pid)) {
> - u16 manuf = I3C_PID_MANUF_ID(devinfo.pid);
> - u16 part = I3C_PID_PART_ID(devinfo.pid);
> - u16 ext_info = I3C_PID_EXTRA_INFO(devinfo.pid);
> -
> - /* First try to match by manufacturer/part ID. */
> - for (id = id_table; id->match_flags != 0; id++) {
> - if ((id->match_flags & I3C_MATCH_MANUF_AND_PART) !=
> - I3C_MATCH_MANUF_AND_PART)
> - continue;
> -
> - if (manuf != id->manuf_id || part != id->part_id)
> - continue;
> -
> - if ((id->match_flags & I3C_MATCH_EXTRA_INFO) &&
> - ext_info != id->extra_info)
> - continue;
> -
> - return id;
> - }
> - }
> -
> - /* Fallback to DCR match. */
> - for (id = id_table; id->match_flags != 0; id++) {
> - if ((id->match_flags & I3C_MATCH_DCR) &&
> - id->dcr == devinfo.dcr)
> - return id;
> - }
> -
> - return NULL;
> -}
> -
> static int i3c_device_match(struct device *dev, struct device_driver *drv)
> {
> struct i3c_device *i3cdev;
> diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
> index 5ecb055..de102e4 100644
> --- a/include/linux/i3c/device.h
> +++ b/include/linux/i3c/device.h
> @@ -188,6 +188,10 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv)
> struct device *i3cdev_to_dev(struct i3c_device *i3cdev);
> struct i3c_device *dev_to_i3cdev(struct device *dev);
>
> +const struct i3c_device_id *
> +i3c_device_match_id(struct i3c_device *i3cdev,
> + const struct i3c_device_id *id_table);
> +
> static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev,
> void *data)
> {
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v6 1/2] i3c: move i3c_device_match_id to device.c and export it
2019-07-19 13:45 ` Boris Brezillon
@ 2019-07-19 15:42 ` Vitor Soares
0 siblings, 0 replies; 11+ messages in thread
From: Vitor Soares @ 2019-07-19 15:42 UTC (permalink / raw)
To: Boris Brezillon, Vitor Soares
Cc: linux-iio, linux-i3c, linux-kernel, lorenzo, gregkh, rafael,
bbrezillon, Joao.Pinto
From: Boris Brezillon <boris.brezillon@collabora.com>
Date: Fri, Jul 19, 2019 at 14:45:03
> On Fri, 19 Jul 2019 15:30:54 +0200
> Vitor Soares <Vitor.Soares@synopsys.com> wrote:
>
> > Some I3C device drivers need to know which entry matches the
> > i3c_device object passed to the probe function
> >
> > Let's move i3c_device_match_id() to device.c and export it so it can be
> > used by drivers.
> >
> > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
>
> Looks good to me. I'll apply the patch when -rc1 is out and provide an
> immutable branch for iio maintainers.
Thanks,
Vitor Soares
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR
2019-07-19 13:30 ` [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR Vitor Soares
@ 2019-07-21 17:16 ` Jonathan Cameron
2019-07-27 10:42 ` Boris Brezillon
2019-09-25 15:35 ` Vitor Soares
0 siblings, 2 replies; 11+ messages in thread
From: Jonathan Cameron @ 2019-07-21 17:16 UTC (permalink / raw)
To: Vitor Soares
Cc: linux-iio, linux-i3c, linux-kernel, lorenzo, gregkh, rafael,
bbrezillon, Joao.Pinto
On Fri, 19 Jul 2019 15:30:55 +0200
Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in
> spi and i2c mode.
>
> The LSM6DSO and LSM6DSR are also i3c capable so let's give i3c support to
> them.
>
> Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
> Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Great. I'll pick this up once Boris has that immutable branch
available. Give me a poke if I seem to have lost it!
Thanks,
Jonathan
> ---
> Changes in v6:
> none
>
> Changes in v5:
> Move regmap_config declaration inside st_lsm6dsx_i3c_probe()
> Fix warning [-Wint-to-void-pointer-cast] when compiling in 64-bit arch
>
> Changes in v4:
> Remove hw_id variable
>
> Changes in v3:
> Remove unnecessary st_lsm6dsx_i3c_data table used to hold device name
> Use st_lsm6dsx_probe new form
>
> Changes in v2:
> Add support for LSM6DSR
> Set pm_ops to st_lsm6dsx_pm_ops
>
> drivers/iio/imu/st_lsm6dsx/Kconfig | 8 +++-
> drivers/iio/imu/st_lsm6dsx/Makefile | 1 +
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c | 57 +++++++++++++++++++++++++++++
> 3 files changed, 65 insertions(+), 1 deletion(-)
> create mode 100644 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig
> index 9e59297..6b5a73c 100644
> --- a/drivers/iio/imu/st_lsm6dsx/Kconfig
> +++ b/drivers/iio/imu/st_lsm6dsx/Kconfig
> @@ -1,11 +1,12 @@
>
> config IIO_ST_LSM6DSX
> tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors"
> - depends on (I2C || SPI)
> + depends on (I2C || SPI || I3C)
> select IIO_BUFFER
> select IIO_KFIFO_BUF
> select IIO_ST_LSM6DSX_I2C if (I2C)
> select IIO_ST_LSM6DSX_SPI if (SPI_MASTER)
> + select IIO_ST_LSM6DSX_I3C if (I3C)
> help
> Say yes here to build support for STMicroelectronics LSM6DSx imu
> sensor. Supported devices: lsm6ds3, lsm6ds3h, lsm6dsl, lsm6dsm,
> @@ -23,3 +24,8 @@ config IIO_ST_LSM6DSX_SPI
> tristate
> depends on IIO_ST_LSM6DSX
> select REGMAP_SPI
> +
> +config IIO_ST_LSM6DSX_I3C
> + tristate
> + depends on IIO_ST_LSM6DSX
> + select REGMAP_I3C
> diff --git a/drivers/iio/imu/st_lsm6dsx/Makefile b/drivers/iio/imu/st_lsm6dsx/Makefile
> index e5f733c..c676965 100644
> --- a/drivers/iio/imu/st_lsm6dsx/Makefile
> +++ b/drivers/iio/imu/st_lsm6dsx/Makefile
> @@ -4,3 +4,4 @@ st_lsm6dsx-y := st_lsm6dsx_core.o st_lsm6dsx_buffer.o \
> obj-$(CONFIG_IIO_ST_LSM6DSX) += st_lsm6dsx.o
> obj-$(CONFIG_IIO_ST_LSM6DSX_I2C) += st_lsm6dsx_i2c.o
> obj-$(CONFIG_IIO_ST_LSM6DSX_SPI) += st_lsm6dsx_spi.o
> +obj-$(CONFIG_IIO_ST_LSM6DSX_I3C) += st_lsm6dsx_i3c.o
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> new file mode 100644
> index 0000000..57e6331
> --- /dev/null
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> @@ -0,0 +1,57 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
> + *
> + * Author: Vitor Soares <vitor.soares@synopsys.com>
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/i3c/device.h>
> +#include <linux/i3c/master.h>
> +#include <linux/slab.h>
> +#include <linux/of.h>
> +#include <linux/regmap.h>
> +
> +#include "st_lsm6dsx.h"
> +
> +static const struct i3c_device_id st_lsm6dsx_i3c_ids[] = {
> + I3C_DEVICE(0x0104, 0x006C, (void *)ST_LSM6DSO_ID),
> + I3C_DEVICE(0x0104, 0x006B, (void *)ST_LSM6DSR_ID),
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(i3c, st_lsm6dsx_i3c_ids);
> +
> +static int st_lsm6dsx_i3c_probe(struct i3c_device *i3cdev)
> +{
> + struct regmap_config st_lsm6dsx_i3c_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> + };
> + const struct i3c_device_id *id = i3c_device_match_id(i3cdev,
> + st_lsm6dsx_i3c_ids);
> + struct regmap *regmap;
> +
> + regmap = devm_regmap_init_i3c(i3cdev, &st_lsm6dsx_i3c_regmap_config);
> + if (IS_ERR(regmap)) {
> + dev_err(&i3cdev->dev, "Failed to register i3c regmap %d\n",
> + (int)PTR_ERR(regmap));
> + return PTR_ERR(regmap);
> + }
> +
> + return st_lsm6dsx_probe(&i3cdev->dev, 0, (uintptr_t)id->data, regmap);
> +}
> +
> +static struct i3c_driver st_lsm6dsx_driver = {
> + .driver = {
> + .name = "st_lsm6dsx_i3c",
> + .pm = &st_lsm6dsx_pm_ops,
> + },
> + .probe = st_lsm6dsx_i3c_probe,
> + .id_table = st_lsm6dsx_i3c_ids,
> +};
> +module_i3c_driver(st_lsm6dsx_driver);
> +
> +MODULE_AUTHOR("Vitor Soares <vitor.soares@synopsys.com>");
> +MODULE_DESCRIPTION("STMicroelectronics st_lsm6dsx i3c driver");
> +MODULE_LICENSE("GPL v2");
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR
2019-07-21 17:16 ` Jonathan Cameron
@ 2019-07-27 10:42 ` Boris Brezillon
2019-07-27 20:54 ` Jonathan Cameron
2019-09-25 15:35 ` Vitor Soares
1 sibling, 1 reply; 11+ messages in thread
From: Boris Brezillon @ 2019-07-27 10:42 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Vitor Soares, linux-iio, linux-i3c, linux-kernel, lorenzo,
gregkh, rafael, bbrezillon, Joao.Pinto
On Sun, 21 Jul 2019 18:16:56 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Fri, 19 Jul 2019 15:30:55 +0200
> Vitor Soares <Vitor.Soares@synopsys.com> wrote:
>
> > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in
> > spi and i2c mode.
> >
> > The LSM6DSO and LSM6DSR are also i3c capable so let's give i3c support to
> > them.
> >
> > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
> > Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Great. I'll pick this up once Boris has that immutable branch
> available. Give me a poke if I seem to have lost it!
Here it is:
The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b:
Linus 5.3-rc1 (2019-07-21 14:05:38 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git tags/i3c/export-i3c_device_match_id
for you to fetch changes up to 934d24a5e1508e73c0001afb54a3916e4270428f:
i3c: move i3c_device_match_id to device.c and export it (2019-07-27 11:22:19 +0200)
----------------------------------------------------------------
Needed for the st_lsm6dsx_i3c.c driver
----------------------------------------------------------------
Vitor Soares (1):
i3c: move i3c_device_match_id to device.c and export it
drivers/i3c/device.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
drivers/i3c/master.c | 45 ---------------------------------------------
include/linux/i3c/device.h | 4 ++++
3 files changed, 57 insertions(+), 45 deletions(-)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR
2019-07-27 10:42 ` Boris Brezillon
@ 2019-07-27 20:54 ` Jonathan Cameron
0 siblings, 0 replies; 11+ messages in thread
From: Jonathan Cameron @ 2019-07-27 20:54 UTC (permalink / raw)
To: Boris Brezillon
Cc: Vitor Soares, linux-iio, linux-i3c, linux-kernel, lorenzo,
gregkh, rafael, bbrezillon, Joao.Pinto
On Sat, 27 Jul 2019 12:42:12 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> On Sun, 21 Jul 2019 18:16:56 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Fri, 19 Jul 2019 15:30:55 +0200
> > Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> >
> > > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in
> > > spi and i2c mode.
> > >
> > > The LSM6DSO and LSM6DSR are also i3c capable so let's give i3c support to
> > > them.
> > >
> > > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
> > > Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> > Great. I'll pick this up once Boris has that immutable branch
> > available. Give me a poke if I seem to have lost it!
>
> Here it is:
>
Great. Merged that into the togreg branch of iio and applied this patch.
Pushed out as testing to let the autobuilders have a poke at it all.
Thanks,
Jonathan
> The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b:
>
> Linus 5.3-rc1 (2019-07-21 14:05:38 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git tags/i3c/export-i3c_device_match_id
>
> for you to fetch changes up to 934d24a5e1508e73c0001afb54a3916e4270428f:
>
> i3c: move i3c_device_match_id to device.c and export it (2019-07-27 11:22:19 +0200)
>
> ----------------------------------------------------------------
> Needed for the st_lsm6dsx_i3c.c driver
>
> ----------------------------------------------------------------
> Vitor Soares (1):
> i3c: move i3c_device_match_id to device.c and export it
>
> drivers/i3c/device.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/i3c/master.c | 45 ---------------------------------------------
> include/linux/i3c/device.h | 4 ++++
> 3 files changed, 57 insertions(+), 45 deletions(-)
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR
2019-07-21 17:16 ` Jonathan Cameron
2019-07-27 10:42 ` Boris Brezillon
@ 2019-09-25 15:35 ` Vitor Soares
2019-10-03 11:49 ` Jonathan Cameron
1 sibling, 1 reply; 11+ messages in thread
From: Vitor Soares @ 2019-09-25 15:35 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-iio, linux-i3c, linux-kernel, lorenzo, gregkh, rafael,
bbrezillon, Joao.Pinto
Hi Jonathan,
From: Jonathan Cameron <jic23@kernel.org>
Date: Sun, Jul 21, 2019 at 18:16:56
> On Fri, 19 Jul 2019 15:30:55 +0200
> Vitor Soares <Vitor.Soares@synopsys.com> wrote:
>
> > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in
> > spi and i2c mode.
> >
> > The LSM6DSO and LSM6DSR are also i3c capable so let's give i3c support to
> > them.
> >
> > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
> > Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Great. I'll pick this up once Boris has that immutable branch
> available. Give me a poke if I seem to have lost it!
>
> Thanks,
>
> Jonathan
I didn't see the i3c support for st_lsm6dsx driver in pull request, could
you please check it?
Best regards,
Vitor Soares
> > ---
> > Changes in v6:
> > none
> >
> > Changes in v5:
> > Move regmap_config declaration inside st_lsm6dsx_i3c_probe()
> > Fix warning [-Wint-to-void-pointer-cast] when compiling in 64-bit arch
> >
> > Changes in v4:
> > Remove hw_id variable
> >
> > Changes in v3:
> > Remove unnecessary st_lsm6dsx_i3c_data table used to hold device name
> > Use st_lsm6dsx_probe new form
> >
> > Changes in v2:
> > Add support for LSM6DSR
> > Set pm_ops to st_lsm6dsx_pm_ops
> >
> > drivers/iio/imu/st_lsm6dsx/Kconfig | 8 +++-
> > drivers/iio/imu/st_lsm6dsx/Makefile | 1 +
> > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c | 57 +++++++++++++++++++++++++++++
> > 3 files changed, 65 insertions(+), 1 deletion(-)
> > create mode 100644 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> >
> > diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig
> > index 9e59297..6b5a73c 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/Kconfig
> > +++ b/drivers/iio/imu/st_lsm6dsx/Kconfig
> > @@ -1,11 +1,12 @@
> >
> > config IIO_ST_LSM6DSX
> > tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors"
> > - depends on (I2C || SPI)
> > + depends on (I2C || SPI || I3C)
> > select IIO_BUFFER
> > select IIO_KFIFO_BUF
> > select IIO_ST_LSM6DSX_I2C if (I2C)
> > select IIO_ST_LSM6DSX_SPI if (SPI_MASTER)
> > + select IIO_ST_LSM6DSX_I3C if (I3C)
> > help
> > Say yes here to build support for STMicroelectronics LSM6DSx imu
> > sensor. Supported devices: lsm6ds3, lsm6ds3h, lsm6dsl, lsm6dsm,
> > @@ -23,3 +24,8 @@ config IIO_ST_LSM6DSX_SPI
> > tristate
> > depends on IIO_ST_LSM6DSX
> > select REGMAP_SPI
> > +
> > +config IIO_ST_LSM6DSX_I3C
> > + tristate
> > + depends on IIO_ST_LSM6DSX
> > + select REGMAP_I3C
> > diff --git a/drivers/iio/imu/st_lsm6dsx/Makefile b/drivers/iio/imu/st_lsm6dsx/Makefile
> > index e5f733c..c676965 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/Makefile
> > +++ b/drivers/iio/imu/st_lsm6dsx/Makefile
> > @@ -4,3 +4,4 @@ st_lsm6dsx-y := st_lsm6dsx_core.o st_lsm6dsx_buffer.o \
> > obj-$(CONFIG_IIO_ST_LSM6DSX) += st_lsm6dsx.o
> > obj-$(CONFIG_IIO_ST_LSM6DSX_I2C) += st_lsm6dsx_i2c.o
> > obj-$(CONFIG_IIO_ST_LSM6DSX_SPI) += st_lsm6dsx_spi.o
> > +obj-$(CONFIG_IIO_ST_LSM6DSX_I3C) += st_lsm6dsx_i3c.o
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> > new file mode 100644
> > index 0000000..57e6331
> > --- /dev/null
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> > @@ -0,0 +1,57 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
> > + *
> > + * Author: Vitor Soares <vitor.soares@synopsys.com>
> > + */
> > +
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +#include <linux/i3c/device.h>
> > +#include <linux/i3c/master.h>
> > +#include <linux/slab.h>
> > +#include <linux/of.h>
> > +#include <linux/regmap.h>
> > +
> > +#include "st_lsm6dsx.h"
> > +
> > +static const struct i3c_device_id st_lsm6dsx_i3c_ids[] = {
> > + I3C_DEVICE(0x0104, 0x006C, (void *)ST_LSM6DSO_ID),
> > + I3C_DEVICE(0x0104, 0x006B, (void *)ST_LSM6DSR_ID),
> > + { /* sentinel */ },
> > +};
> > +MODULE_DEVICE_TABLE(i3c, st_lsm6dsx_i3c_ids);
> > +
> > +static int st_lsm6dsx_i3c_probe(struct i3c_device *i3cdev)
> > +{
> > + struct regmap_config st_lsm6dsx_i3c_regmap_config = {
> > + .reg_bits = 8,
> > + .val_bits = 8,
> > + };
> > + const struct i3c_device_id *id = i3c_device_match_id(i3cdev,
> > + st_lsm6dsx_i3c_ids);
> > + struct regmap *regmap;
> > +
> > + regmap = devm_regmap_init_i3c(i3cdev, &st_lsm6dsx_i3c_regmap_config);
> > + if (IS_ERR(regmap)) {
> > + dev_err(&i3cdev->dev, "Failed to register i3c regmap %d\n",
> > + (int)PTR_ERR(regmap));
> > + return PTR_ERR(regmap);
> > + }
> > +
> > + return st_lsm6dsx_probe(&i3cdev->dev, 0, (uintptr_t)id->data, regmap);
> > +}
> > +
> > +static struct i3c_driver st_lsm6dsx_driver = {
> > + .driver = {
> > + .name = "st_lsm6dsx_i3c",
> > + .pm = &st_lsm6dsx_pm_ops,
> > + },
> > + .probe = st_lsm6dsx_i3c_probe,
> > + .id_table = st_lsm6dsx_i3c_ids,
> > +};
> > +module_i3c_driver(st_lsm6dsx_driver);
> > +
> > +MODULE_AUTHOR("Vitor Soares <vitor.soares@synopsys.com>");
> > +MODULE_DESCRIPTION("STMicroelectronics st_lsm6dsx i3c driver");
> > +MODULE_LICENSE("GPL v2");
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR
2019-09-25 15:35 ` Vitor Soares
@ 2019-10-03 11:49 ` Jonathan Cameron
2019-10-03 17:38 ` Vitor Soares
0 siblings, 1 reply; 11+ messages in thread
From: Jonathan Cameron @ 2019-10-03 11:49 UTC (permalink / raw)
To: Vitor Soares
Cc: Jonathan Cameron, linux-iio, linux-i3c, linux-kernel, lorenzo,
gregkh, rafael, bbrezillon, Joao.Pinto
On Wed, 25 Sep 2019 15:35:10 +0000
Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> Hi Jonathan,
>
> From: Jonathan Cameron <jic23@kernel.org>
> Date: Sun, Jul 21, 2019 at 18:16:56
>
> > On Fri, 19 Jul 2019 15:30:55 +0200
> > Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> >
> > > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in
> > > spi and i2c mode.
> > >
> > > The LSM6DSO and LSM6DSR are also i3c capable so let's give i3c support to
> > > them.
> > >
> > > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
> > > Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> > Great. I'll pick this up once Boris has that immutable branch
> > available. Give me a poke if I seem to have lost it!
> >
> > Thanks,
> >
> > Jonathan
>
> I didn't see the i3c support for st_lsm6dsx driver in pull request, could
> you please check it?
Seems to have made it
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c?h=v5.4-rc1
I checked back. Was in the first pull request back on the 12th of August.
Jonathan
>
> Best regards,
> Vitor Soares
>
> > > ---
> > > Changes in v6:
> > > none
> > >
> > > Changes in v5:
> > > Move regmap_config declaration inside st_lsm6dsx_i3c_probe()
> > > Fix warning [-Wint-to-void-pointer-cast] when compiling in 64-bit arch
> > >
> > > Changes in v4:
> > > Remove hw_id variable
> > >
> > > Changes in v3:
> > > Remove unnecessary st_lsm6dsx_i3c_data table used to hold device name
> > > Use st_lsm6dsx_probe new form
> > >
> > > Changes in v2:
> > > Add support for LSM6DSR
> > > Set pm_ops to st_lsm6dsx_pm_ops
> > >
> > > drivers/iio/imu/st_lsm6dsx/Kconfig | 8 +++-
> > > drivers/iio/imu/st_lsm6dsx/Makefile | 1 +
> > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c | 57 +++++++++++++++++++++++++++++
> > > 3 files changed, 65 insertions(+), 1 deletion(-)
> > > create mode 100644 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> > >
> > > diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig
> > > index 9e59297..6b5a73c 100644
> > > --- a/drivers/iio/imu/st_lsm6dsx/Kconfig
> > > +++ b/drivers/iio/imu/st_lsm6dsx/Kconfig
> > > @@ -1,11 +1,12 @@
> > >
> > > config IIO_ST_LSM6DSX
> > > tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors"
> > > - depends on (I2C || SPI)
> > > + depends on (I2C || SPI || I3C)
> > > select IIO_BUFFER
> > > select IIO_KFIFO_BUF
> > > select IIO_ST_LSM6DSX_I2C if (I2C)
> > > select IIO_ST_LSM6DSX_SPI if (SPI_MASTER)
> > > + select IIO_ST_LSM6DSX_I3C if (I3C)
> > > help
> > > Say yes here to build support for STMicroelectronics LSM6DSx imu
> > > sensor. Supported devices: lsm6ds3, lsm6ds3h, lsm6dsl, lsm6dsm,
> > > @@ -23,3 +24,8 @@ config IIO_ST_LSM6DSX_SPI
> > > tristate
> > > depends on IIO_ST_LSM6DSX
> > > select REGMAP_SPI
> > > +
> > > +config IIO_ST_LSM6DSX_I3C
> > > + tristate
> > > + depends on IIO_ST_LSM6DSX
> > > + select REGMAP_I3C
> > > diff --git a/drivers/iio/imu/st_lsm6dsx/Makefile b/drivers/iio/imu/st_lsm6dsx/Makefile
> > > index e5f733c..c676965 100644
> > > --- a/drivers/iio/imu/st_lsm6dsx/Makefile
> > > +++ b/drivers/iio/imu/st_lsm6dsx/Makefile
> > > @@ -4,3 +4,4 @@ st_lsm6dsx-y := st_lsm6dsx_core.o st_lsm6dsx_buffer.o \
> > > obj-$(CONFIG_IIO_ST_LSM6DSX) += st_lsm6dsx.o
> > > obj-$(CONFIG_IIO_ST_LSM6DSX_I2C) += st_lsm6dsx_i2c.o
> > > obj-$(CONFIG_IIO_ST_LSM6DSX_SPI) += st_lsm6dsx_spi.o
> > > +obj-$(CONFIG_IIO_ST_LSM6DSX_I3C) += st_lsm6dsx_i3c.o
> > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> > > new file mode 100644
> > > index 0000000..57e6331
> > > --- /dev/null
> > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c
> > > @@ -0,0 +1,57 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
> > > + *
> > > + * Author: Vitor Soares <vitor.soares@synopsys.com>
> > > + */
> > > +
> > > +#include <linux/kernel.h>
> > > +#include <linux/module.h>
> > > +#include <linux/i3c/device.h>
> > > +#include <linux/i3c/master.h>
> > > +#include <linux/slab.h>
> > > +#include <linux/of.h>
> > > +#include <linux/regmap.h>
> > > +
> > > +#include "st_lsm6dsx.h"
> > > +
> > > +static const struct i3c_device_id st_lsm6dsx_i3c_ids[] = {
> > > + I3C_DEVICE(0x0104, 0x006C, (void *)ST_LSM6DSO_ID),
> > > + I3C_DEVICE(0x0104, 0x006B, (void *)ST_LSM6DSR_ID),
> > > + { /* sentinel */ },
> > > +};
> > > +MODULE_DEVICE_TABLE(i3c, st_lsm6dsx_i3c_ids);
> > > +
> > > +static int st_lsm6dsx_i3c_probe(struct i3c_device *i3cdev)
> > > +{
> > > + struct regmap_config st_lsm6dsx_i3c_regmap_config = {
> > > + .reg_bits = 8,
> > > + .val_bits = 8,
> > > + };
> > > + const struct i3c_device_id *id = i3c_device_match_id(i3cdev,
> > > + st_lsm6dsx_i3c_ids);
> > > + struct regmap *regmap;
> > > +
> > > + regmap = devm_regmap_init_i3c(i3cdev, &st_lsm6dsx_i3c_regmap_config);
> > > + if (IS_ERR(regmap)) {
> > > + dev_err(&i3cdev->dev, "Failed to register i3c regmap %d\n",
> > > + (int)PTR_ERR(regmap));
> > > + return PTR_ERR(regmap);
> > > + }
> > > +
> > > + return st_lsm6dsx_probe(&i3cdev->dev, 0, (uintptr_t)id->data, regmap);
> > > +}
> > > +
> > > +static struct i3c_driver st_lsm6dsx_driver = {
> > > + .driver = {
> > > + .name = "st_lsm6dsx_i3c",
> > > + .pm = &st_lsm6dsx_pm_ops,
> > > + },
> > > + .probe = st_lsm6dsx_i3c_probe,
> > > + .id_table = st_lsm6dsx_i3c_ids,
> > > +};
> > > +module_i3c_driver(st_lsm6dsx_driver);
> > > +
> > > +MODULE_AUTHOR("Vitor Soares <vitor.soares@synopsys.com>");
> > > +MODULE_DESCRIPTION("STMicroelectronics st_lsm6dsx i3c driver");
> > > +MODULE_LICENSE("GPL v2");
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR
2019-10-03 11:49 ` Jonathan Cameron
@ 2019-10-03 17:38 ` Vitor Soares
0 siblings, 0 replies; 11+ messages in thread
From: Vitor Soares @ 2019-10-03 17:38 UTC (permalink / raw)
To: Jonathan Cameron, Vitor Soares
Cc: Jonathan Cameron, linux-iio, linux-i3c, linux-kernel, lorenzo,
gregkh, rafael, bbrezillon, Joao.Pinto
Hi Jonathan,
From: Jonathan Cameron <jonathan.cameron@huawei.com>
Date: Thu, Oct 03,
2019 at 12:49:02
> On Wed, 25 Sep 2019 15:35:10 +0000
> Vitor Soares <Vitor.Soares@synopsys.com> wrote:
>
> > Hi Jonathan,
> >
> > From: Jonathan Cameron <jic23@kernel.org>
> > Date: Sun, Jul 21, 2019 at 18:16:56
> >
> > > On Fri, 19 Jul 2019 15:30:55 +0200
> > > Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> > >
> > > > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in
> > > > spi and i2c mode.
> > > >
> > > > The LSM6DSO and LSM6DSR are also i3c capable so let's give i3c support to
> > > > them.
> > > >
> > > > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
> > > > Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> > > Great. I'll pick this up once Boris has that immutable branch
> > > available. Give me a poke if I seem to have lost it!
> > >
> > > Thanks,
> > >
> > > Jonathan
> >
> > I didn't see the i3c support for st_lsm6dsx driver in pull request, could
> > you please check it?
> Seems to have made it
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_torvalds_linux.git_tree_drivers_iio_imu_st-5Flsm6dsx_st-5Flsm6dsx-5Fi3c.c-3Fh-3Dv5.4-2Drc1&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg6PK9PateHwjb_DY0&m=RaUb9HXBdF5dxPWn5sdO7gqqaQzqY7UFd8Rcv0ioTx0&s=-Xs5gaN2wau8fXfg5hryTStGMVD8WFA66mX0hCMsmXg&e=
>
> I checked back. Was in the first pull request back on the 12th of August.
>
> Jonathan
I confirm that is there. I'm already using it.
Thanks a lot.
Best regards,
Vitor Soares
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-10-03 17:38 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-19 13:30 [PATCH v6 0/2] Add ST lsm6dso i3c support Vitor Soares
2019-07-19 13:30 ` [PATCH v6 1/2] i3c: move i3c_device_match_id to device.c and export it Vitor Soares
2019-07-19 13:45 ` Boris Brezillon
2019-07-19 15:42 ` Vitor Soares
2019-07-19 13:30 ` [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR Vitor Soares
2019-07-21 17:16 ` Jonathan Cameron
2019-07-27 10:42 ` Boris Brezillon
2019-07-27 20:54 ` Jonathan Cameron
2019-09-25 15:35 ` Vitor Soares
2019-10-03 11:49 ` Jonathan Cameron
2019-10-03 17:38 ` Vitor Soares
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).