From: Ira Weiny <ira.weiny@intel.com>
To: Bharath Vedartham <linux.bhar@gmail.com>
Cc: arnd@arndb.de, sivanich@sgi.com, gregkh@linuxfoundation.org,
jhubbard@nvidia.com, jglisse@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/3] sgi-gru: get_user_page changes
Date: Sun, 21 Jul 2019 21:49:48 -0700 [thread overview]
Message-ID: <20190722044947.GA6157@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <1563724685-6540-1-git-send-email-linux.bhar@gmail.com>
On Sun, Jul 21, 2019 at 09:28:02PM +0530, Bharath Vedartham wrote:
> This patch series incorporates a few changes in the get_user_page usage
> of sgi-gru.
>
> The main change is the first patch, which is a trivial one line change to
> convert put_page to put_user_page to enable tracking of get_user_pages.
>
> The second patch removes an uneccessary ifdef of CONFIG_HUGETLB.
>
> The third patch adds __get_user_pages_fast in atomic_pte_lookup to retrive
> a physical user page in an atomic context instead of manually walking up
> the page tables like the current code does. This patch should be subject to
> more review from the gup people.
>
> drivers/misc/sgi-gru/* builds after this patch series. But I do not have the
> hardware to verify these changes.
>
> The first patch implements gup tracking in the current code. This is to be tested
> as to check whether gup tracking works properly. Currently, in the upstream kernels
> put_user_page simply calls put_page. But that is to change in the future.
> Any suggestions as to how to test this code?
>
> The implementation of gup tracking is in:
> https://github.com/johnhubbard/linux/tree/gup_dma_core
>
> We could test it by applying the first patch to the above tree and test it.
>
> More details are in the individual changelogs.
>
> Bharath Vedartham (3):
I don't have an opinion on the second patch regarding any performance concerns
since I'm not familiar with this hardware.
But from a GUP POV For the series.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> sgi-gru: Convert put_page() to get_user_page*()
> sgi-gru: Remove CONFIG_HUGETLB_PAGE ifdef
> sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup
>
> drivers/misc/sgi-gru/grufault.c | 50 +++++++----------------------------------
> 1 file changed, 8 insertions(+), 42 deletions(-)
>
> --
> 2.7.4
>
prev parent reply other threads:[~2019-07-22 4:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 15:58 [PATCH 0/3] sgi-gru: get_user_page changes Bharath Vedartham
2019-07-21 15:58 ` [PATCH 1/3] sgi-gru: Convert put_page() to get_user_page*() Bharath Vedartham
2019-07-22 2:25 ` John Hubbard
2019-07-22 17:47 ` Bharath Vedartham
2019-07-21 15:58 ` [PATCH 2/3] sgi-gru: Remove CONFIG_HUGETLB_PAGE ifdef Bharath Vedartham
2019-07-22 2:34 ` John Hubbard
2019-07-22 3:20 ` William Kucharski
2019-07-22 17:50 ` Bharath Vedartham
2019-07-22 22:53 ` William Kucharski
2019-07-21 15:58 ` [PATCH 3/3] sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup Bharath Vedartham
2019-07-22 2:32 ` John Hubbard
2019-07-22 17:53 ` Bharath Vedartham
2019-07-22 23:06 ` John Hubbard
2019-07-22 4:49 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722044947.GA6157@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux.bhar@gmail.com \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).