From: William Kucharski <william.kucharski@oracle.com>
To: Bharath Vedartham <linux.bhar@gmail.com>
Cc: arnd@arndb.de, sivanich@sgi.com, gregkh@linuxfoundation.org,
ira.weiny@intel.com, jhubbard@nvidia.com, jglisse@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] sgi-gru: Remove CONFIG_HUGETLB_PAGE ifdef
Date: Mon, 22 Jul 2019 16:53:53 -0600 [thread overview]
Message-ID: <58D68134-E068-466C-AAD8-FA69596E8C26@oracle.com> (raw)
In-Reply-To: <20190722175022.GB12278@bharath12345-Inspiron-5559>
> On Jul 22, 2019, at 11:50 AM, Bharath Vedartham <linux.bhar@gmail.com> wrote:
>
>>
>>
>> In all likelihood, these questions are no-ops, and the optimizer may even make my questions completely moot, but I thought I might as well ask anyway.
>>
> That sounds reasonable. I am not really sure as to how much of
> an improvement it would be, the condition will be evaluated eitherways
> AFAIK? Eitherways, the ternary operator does not look good. I ll make a
> version 2 of this.
In THEORY the "unlikely" hints to the compiler that that leg of the "if" can be made the branch and jump leg, though in reality optimization is much more complex than that.
Still, the unlikely() call is also nicely self-documenting as to what the expected outcome is.
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
next prev parent reply other threads:[~2019-07-22 22:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 15:58 [PATCH 0/3] sgi-gru: get_user_page changes Bharath Vedartham
2019-07-21 15:58 ` [PATCH 1/3] sgi-gru: Convert put_page() to get_user_page*() Bharath Vedartham
2019-07-22 2:25 ` John Hubbard
2019-07-22 17:47 ` Bharath Vedartham
2019-07-21 15:58 ` [PATCH 2/3] sgi-gru: Remove CONFIG_HUGETLB_PAGE ifdef Bharath Vedartham
2019-07-22 2:34 ` John Hubbard
2019-07-22 3:20 ` William Kucharski
2019-07-22 17:50 ` Bharath Vedartham
2019-07-22 22:53 ` William Kucharski [this message]
2019-07-21 15:58 ` [PATCH 3/3] sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup Bharath Vedartham
2019-07-22 2:32 ` John Hubbard
2019-07-22 17:53 ` Bharath Vedartham
2019-07-22 23:06 ` John Hubbard
2019-07-22 4:49 ` [PATCH 0/3] sgi-gru: get_user_page changes Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58D68134-E068-466C-AAD8-FA69596E8C26@oracle.com \
--to=william.kucharski@oracle.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux.bhar@gmail.com \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).