* [PATCH] Staging: rtl8188eu: core: rtw_security: fixed a coding style issue
@ 2019-08-06 11:54 Merwin Trever Ferrao
2019-08-06 12:04 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Merwin Trever Ferrao @ 2019-08-06 11:54 UTC (permalink / raw)
To: Larry.Finger, gregkh, dan.carpenter; +Cc: devel, linux-kernel, merwintf
Fixed WARNING: else is not generally useful after a break or return
---
drivers/staging/rtl8188eu/core/rtw_security.c | 41 +++++++++----------
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
index 2f90f60f1681..435c0fbec54a 100644
--- a/drivers/staging/rtl8188eu/core/rtw_security.c
+++ b/drivers/staging/rtl8188eu/core/rtw_security.c
@@ -87,29 +87,28 @@ static u8 crc32_reverseBit(u8 data)
static void crc32_init(void)
{
- if (bcrc32initialized == 1) {
+ int i, j;
+ u32 c;
+ u8 *p = (u8 *)&c, *p1;
+ u8 k;
+
+ if (bcrc32initialized == 1)
return;
- } else {
- int i, j;
- u32 c;
- u8 *p = (u8 *)&c, *p1;
- u8 k;
-
- c = 0x12340000;
-
- for (i = 0; i < 256; ++i) {
- k = crc32_reverseBit((u8)i);
- for (c = ((u32)k) << 24, j = 8; j > 0; --j)
- c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
- p1 = (u8 *)&crc32_table[i];
-
- p1[0] = crc32_reverseBit(p[3]);
- p1[1] = crc32_reverseBit(p[2]);
- p1[2] = crc32_reverseBit(p[1]);
- p1[3] = crc32_reverseBit(p[0]);
- }
- bcrc32initialized = 1;
+
+ c = 0x12340000;
+
+ for (i = 0; i < 256; ++i) {
+ k = crc32_reverseBit((u8)i);
+ for (c = ((u32)k) << 24, j = 8; j > 0; --j)
+ c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
+ p1 = (u8 *)&crc32_table[i];
+
+ p1[0] = crc32_reverseBit(p[3]);
+ p1[1] = crc32_reverseBit(p[2]);
+ p1[2] = crc32_reverseBit(p[1]);
+ p1[3] = crc32_reverseBit(p[0]);
}
+ bcrc32initialized = 1;
}
static __le32 getcrc32(u8 *buf, int len)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: rtl8188eu: core: rtw_security: fixed a coding style issue
2019-08-06 11:54 [PATCH] Staging: rtl8188eu: core: rtw_security: fixed a coding style issue Merwin Trever Ferrao
@ 2019-08-06 12:04 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-08-06 12:04 UTC (permalink / raw)
To: Merwin Trever Ferrao; +Cc: Larry.Finger, gregkh, devel, linux-kernel
On Tue, Aug 06, 2019 at 05:24:38PM +0530, Merwin Trever Ferrao wrote:
> Fixed WARNING: else is not generally useful after a break or return
> ---
Much better, but you forgot the the Signed-off-by so we can't apply it.
Also it's nice to be more specific with the subject.
[PATCH] Staging: rtl8188eu: rtw_security: tidy up crc32_init().
And for the full commit message maybe write something like:
This code generates a checkpatch warning:
WARNING: else is not generally useful after a break or return
If we move the declarations to the start of the function then we can
pull the code back one tab and it makes the function a lot more readable.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-06 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-06 11:54 [PATCH] Staging: rtl8188eu: core: rtw_security: fixed a coding style issue Merwin Trever Ferrao
2019-08-06 12:04 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).