linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls
@ 2019-08-15  9:19 YueHaibing
  2019-08-15 10:08 ` Charles Keepax
  2019-08-15 17:14 ` Applied "ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls" to the asoc tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-08-15  9:19 UTC (permalink / raw)
  To: lgirdwood, broonie, perex, tiwai, tglx, info
  Cc: linux-kernel, alsa-devel, patches, YueHaibing

sound/soc/codecs/wm8737.c:112:29: warning:
 high_3d defined but not used [-Wunused-const-variable=]

'high_3d' should be used for 3D High Cut-off.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 2a9ae13a2641 ("ASoC: Add initial WM8737 driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 sound/soc/codecs/wm8737.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8737.c b/sound/soc/codecs/wm8737.c
index 0c246fb..7a3f9fb 100644
--- a/sound/soc/codecs/wm8737.c
+++ b/sound/soc/codecs/wm8737.c
@@ -167,7 +167,7 @@ SOC_DOUBLE("Polarity Invert Switch", WM8737_ADC_CONTROL, 5, 6, 1, 0),
 SOC_SINGLE("3D Switch", WM8737_3D_ENHANCE, 0, 1, 0),
 SOC_SINGLE("3D Depth", WM8737_3D_ENHANCE, 1, 15, 0),
 SOC_ENUM("3D Low Cut-off", low_3d),
-SOC_ENUM("3D High Cut-off", low_3d),
+SOC_ENUM("3D High Cut-off", high_3d),
 SOC_SINGLE_TLV("3D ADC Volume", WM8737_3D_ENHANCE, 7, 1, 1, adc_tlv),
 
 SOC_SINGLE("Noise Gate Switch", WM8737_NOISE_GATE, 0, 1, 0),
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls
  2019-08-15  9:19 [PATCH -next] ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls YueHaibing
@ 2019-08-15 10:08 ` Charles Keepax
  2019-08-15 17:14 ` Applied "ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls" to the asoc tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2019-08-15 10:08 UTC (permalink / raw)
  To: YueHaibing
  Cc: lgirdwood, broonie, perex, tiwai, tglx, info, linux-kernel,
	alsa-devel, patches

On Thu, Aug 15, 2019 at 05:19:20PM +0800, YueHaibing wrote:
> sound/soc/codecs/wm8737.c:112:29: warning:
>  high_3d defined but not used [-Wunused-const-variable=]
> 
> 'high_3d' should be used for 3D High Cut-off.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 2a9ae13a2641 ("ASoC: Add initial WM8737 driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls" to the asoc tree
  2019-08-15  9:19 [PATCH -next] ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls YueHaibing
  2019-08-15 10:08 ` Charles Keepax
@ 2019-08-15 17:14 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2019-08-15 17:14 UTC (permalink / raw)
  To: YueHaibing
  Cc: alsa-devel, broonie, Charles Keepax, Hulk Robot, info, lgirdwood,
	linux-kernel, Mark Brown, patches, perex, tglx, tiwai

The patch

   ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 554b75bde64bcad9662530726d1483f7ef012069 Mon Sep 17 00:00:00 2001
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 15 Aug 2019 17:19:20 +0800
Subject: [PATCH] ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls

sound/soc/codecs/wm8737.c:112:29: warning:
 high_3d defined but not used [-Wunused-const-variable=]

'high_3d' should be used for 3D High Cut-off.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 2a9ae13a2641 ("ASoC: Add initial WM8737 driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20190815091920.64480-1-yuehaibing@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/wm8737.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8737.c b/sound/soc/codecs/wm8737.c
index 0c246fb5e5ac..7a3f9fbe8d53 100644
--- a/sound/soc/codecs/wm8737.c
+++ b/sound/soc/codecs/wm8737.c
@@ -167,7 +167,7 @@ SOC_DOUBLE("Polarity Invert Switch", WM8737_ADC_CONTROL, 5, 6, 1, 0),
 SOC_SINGLE("3D Switch", WM8737_3D_ENHANCE, 0, 1, 0),
 SOC_SINGLE("3D Depth", WM8737_3D_ENHANCE, 1, 15, 0),
 SOC_ENUM("3D Low Cut-off", low_3d),
-SOC_ENUM("3D High Cut-off", low_3d),
+SOC_ENUM("3D High Cut-off", high_3d),
 SOC_SINGLE_TLV("3D ADC Volume", WM8737_3D_ENHANCE, 7, 1, 1, adc_tlv),
 
 SOC_SINGLE("Noise Gate Switch", WM8737_NOISE_GATE, 0, 1, 0),
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-15 17:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15  9:19 [PATCH -next] ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls YueHaibing
2019-08-15 10:08 ` Charles Keepax
2019-08-15 17:14 ` Applied "ASoC: wm8737: Fix copy-paste error in wm8737_snd_controls" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).