From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: [PATCH v3 00/10] Device property improvements, add %pfw format specifier
Date: Thu, 29 Aug 2019 13:10:33 +0300 [thread overview]
Message-ID: <20190829101043.24963-1-sakari.ailus@linux.intel.com> (raw)
Hi all,
This set adds functionality into the device property API (counting a
node's parents as well as obtaining its name) in order to support printing
fwnode names using a new conversion specifier "%pfw". The names that are
produced are equivalent to its OF counterpart "%pOF" on OF systems for the
two supported modifiers ("f" and "P").
Printing a node's name is something that's been available on OF for a long
time and if something is converted to device property API (such as the
V4L2 fwnode framework) it always got removed of a nice feature that was
sometimes essential in debugging. With this set, that no longer is the
case.
since v2:
- Better comments in acpi_fwnode_get_name_prefix().
- Added swnode implementation.
- Fixed swnode refcounting in get_parent() ("swnode: Get reference to
parent swnode in get_parent op")
- Make argument to to_software_node() const (a new patch)
- Factored out confusingly named kobject_string() that had a single
caller.
- Cleaner fwnode_count_parents() implementation (as discussed in review).
- Made fwnode_count_parents() argument const.
- Added tests (last patch in the set).
since v1:
- Add patch to remove support for %pf and %pF (depends on another patch
removing all use of %pf and %pF) (now 4th patch)
- Fix kerneldoc argument documentation for fwnode_get_name (2nd patch)
- Align kerneldoc style with the rest of drivers/base/property.c (no extra
newline after function name)
- Make checkpatch.pl complain about "%pf" not followed by "w" (6th patch)
- WARN_ONCE() on use of invalid conversion specifiers ("%pf" not followed
by "w")
Sakari Ailus (10):
software node: Get reference to parent swnode in get_parent op
software node: Make argument to to_software_node const
device property: Add functions for accessing node's parents
device property: Add fwnode_get_name for returning the name of a node
device property: Add a function to obtain a node's prefix
lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps
lib/vsprintf: Make use of fwnode API to obtain node names and
separators
lib/vsprintf: OF nodes are first and foremost, struct device_nodes
lib/vsprintf: Add %pfw conversion specifier for printing fwnode names
lib/test_printf: Add tests for %pfw printk modifier
Documentation/core-api/printk-formats.rst | 34 ++++++---
drivers/acpi/property.c | 48 +++++++++++++
drivers/base/property.c | 83 +++++++++++++++++++--
drivers/base/swnode.c | 55 +++++++++++++-
drivers/of/property.c | 16 +++++
include/linux/fwnode.h | 4 ++
include/linux/property.h | 8 ++-
lib/test_printf.c | 37 ++++++++++
lib/vsprintf.c | 88 +++++++++++++----------
scripts/checkpatch.pl | 4 +-
10 files changed, 318 insertions(+), 59 deletions(-)
--
2.20.1
next reply other threads:[~2019-08-29 10:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 10:10 Sakari Ailus [this message]
2019-08-29 10:10 ` [PATCH v3 01/10] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-08-30 12:22 ` Andy Shevchenko
2019-09-02 6:46 ` Sakari Ailus
2019-08-30 12:26 ` Heikki Krogerus
2019-08-30 12:33 ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 02/10] software node: Make argument to to_software_node const Sakari Ailus
2019-08-30 12:22 ` Andy Shevchenko
2019-08-30 12:27 ` Heikki Krogerus
2019-08-29 10:10 ` [PATCH v3 03/10] device property: Add functions for accessing node's parents Sakari Ailus
2019-08-29 10:44 ` [PATCH v4 " Sakari Ailus
2019-08-30 12:42 ` Andy Shevchenko
2019-09-02 7:05 ` Sakari Ailus
2019-08-30 12:34 ` [PATCH v3 " Andy Shevchenko
2019-09-02 7:30 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 04/10] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-08-30 12:37 ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 05/10] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-08-30 12:46 ` Andy Shevchenko
2019-09-02 7:29 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 06/10] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-08-30 12:48 ` Andy Shevchenko
2019-09-02 7:06 ` Sakari Ailus
2019-08-30 12:55 ` Andy Shevchenko
2019-09-02 7:07 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 07/10] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-08-30 12:53 ` Andy Shevchenko
2019-09-02 7:11 ` Sakari Ailus
2019-09-02 9:48 ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 08/10] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Sakari Ailus
2019-08-30 12:57 ` Andy Shevchenko
2019-09-02 7:28 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 09/10] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-08-30 13:03 ` Andy Shevchenko
2019-09-02 7:22 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 10/10] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-08-30 13:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829101043.24963-1-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).