From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 09/10] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names
Date: Mon, 2 Sep 2019 10:22:22 +0300 [thread overview]
Message-ID: <20190902072222.GG5475@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20190830130349.GJ2680@smile.fi.intel.com>
Hi Andy,
Thanks for the review.
On Fri, Aug 30, 2019 at 04:03:49PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 29, 2019 at 01:10:42PM +0300, Sakari Ailus wrote:
> > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to
> > support printing full path of the node, including its name ("f") and only
> > the node's name ("P") in the printk family of functions. The two flags
> > have equivalent functionality to existing %pOF with the same two modifiers
> > ("f" and "P") on OF based systems. The ability to do the same on ACPI
> > based systems is added by this patch.
> >
> > On ACPI based systems the resulting strings look like
> >
> > \_SB.PCI0.CIO2.port@1.endpoint@0
> >
> > where the nodes are separated by a dot (".") and the first three are
> > ACPI device nodes and the latter two ACPI data nodes.
>
> Couple of comments below, FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
>
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> > Documentation/core-api/printk-formats.rst | 24 +++++++++++++++
> > lib/vsprintf.c | 37 +++++++++++++++++++++++
> > scripts/checkpatch.pl | 3 +-
> > 3 files changed, 63 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst
> > index 922a29eb70e6c..abba210f67567 100644
> > --- a/Documentation/core-api/printk-formats.rst
> > +++ b/Documentation/core-api/printk-formats.rst
> > @@ -418,6 +418,30 @@ Examples::
> >
> > Passed by reference.
> >
> > +Fwnode handles
> > +--------------
> > +
> > +::
> > +
> > + %pfw[fP]
>
> I'm not familiar with all flavours of the OF case, the question is do we use
> same letters for analogues?
Yes. There are some that may be unworkable to be extended, but in general
this helps folks who are familiar with the OF conversion specifiers.
>
> > +
> > +For printing information on fwnode handles. The default is to print the full
> > +node name, including the path. The modifiers are functionally equivalent to
> > +%pOF above.
> > +
> > + - f - full name of the node, including the path
> > + - P - the name of the node including an address (if there is one)
> > +
> > +Examples (ACPI):
> > +
> > + %pfwf \_SB.PCI0.CIO2.port@1.endpoint@0 - Full node name
> > + %pfwP endpoint@0 - Node name
> > +
> > +Examples (OF):
> > +
> > + %pfwf /ocp@68000000/i2c@48072000/camera@10/port/endpoint - Full name
> > + %pfwP endpoint - Node name
> > +
> > Time and date (struct rtc_time)
> > -------------------------------
> >
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> > index 19f9b3f30623e..79dacd0b9e124 100644
> > --- a/lib/vsprintf.c
> > +++ b/lib/vsprintf.c
> > @@ -1978,6 +1978,37 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
> > return widen_string(buf, buf - buf_start, end, spec);
> > }
> >
> > +static noinline_for_stack
> > +char *fwnode_string(char *buf, char *end, struct fwnode_handle *fwnode,
> > + struct printf_spec spec, const char *fmt)
> > +{
> > + struct printf_spec str_spec = spec;
> > + char *buf_start = buf;
> > +
> > + str_spec.field_width = -1;
> > +
> > + if (*fmt != 'w')
> > + return error_string(buf, end, "(%pfw?)", spec);
> > +
> > + if (check_pointer(&buf, end, fwnode, spec))
> > + return buf;
> > +
> > + fmt++;
> > +
> > + switch (*fmt) {
> > + case 'f': /* full_name */
> > + default:
> > + buf = fwnode_full_name_string(fwnode, buf, end);
> > + break;
> > + case 'P': /* name */
>
> > + buf = string(buf, end, fwnode_get_name(fwnode),
> > + str_spec);
>
> Perfectly one line.
Fixed.
--
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2019-09-02 7:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 10:10 [PATCH v3 00/10] Device property improvements, add %pfw format specifier Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 01/10] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-08-30 12:22 ` Andy Shevchenko
2019-09-02 6:46 ` Sakari Ailus
2019-08-30 12:26 ` Heikki Krogerus
2019-08-30 12:33 ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 02/10] software node: Make argument to to_software_node const Sakari Ailus
2019-08-30 12:22 ` Andy Shevchenko
2019-08-30 12:27 ` Heikki Krogerus
2019-08-29 10:10 ` [PATCH v3 03/10] device property: Add functions for accessing node's parents Sakari Ailus
2019-08-29 10:44 ` [PATCH v4 " Sakari Ailus
2019-08-30 12:42 ` Andy Shevchenko
2019-09-02 7:05 ` Sakari Ailus
2019-08-30 12:34 ` [PATCH v3 " Andy Shevchenko
2019-09-02 7:30 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 04/10] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-08-30 12:37 ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 05/10] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-08-30 12:46 ` Andy Shevchenko
2019-09-02 7:29 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 06/10] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-08-30 12:48 ` Andy Shevchenko
2019-09-02 7:06 ` Sakari Ailus
2019-08-30 12:55 ` Andy Shevchenko
2019-09-02 7:07 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 07/10] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-08-30 12:53 ` Andy Shevchenko
2019-09-02 7:11 ` Sakari Ailus
2019-09-02 9:48 ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 08/10] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Sakari Ailus
2019-08-30 12:57 ` Andy Shevchenko
2019-09-02 7:28 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 09/10] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-08-30 13:03 ` Andy Shevchenko
2019-09-02 7:22 ` Sakari Ailus [this message]
2019-08-29 10:10 ` [PATCH v3 10/10] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-08-30 13:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902072222.GG5475@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).