linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Michael Petlan <mpetlan@redhat.com>
Subject: Re: [PATCH 1/4] perf tools: Fix python/perf.so compilation
Date: Sun, 1 Sep 2019 12:14:31 -0300	[thread overview]
Message-ID: <20190901151431.GL28011@kernel.org> (raw)
In-Reply-To: <20190901124822.10132-2-jolsa@kernel.org>

Em Sun, Sep 01, 2019 at 02:48:19PM +0200, Jiri Olsa escreveu:
> The python/perf.so compilation needs libperf ready,
> otherwise it fails:
> 
>   $ make python/perf.so JOBS=1
>     BUILD:   Doing 'make -j1' parallel build
>     GEN      python/perf.so
>   gcc: error: /home/jolsa/kernel/linux-perf/tools/perf/lib/libperf.a: No such file or directory
> 
> Fixing this with by adding libperf dependency.

Thanks, tested, applied.

- Arnaldo
 
> Link: http://lkml.kernel.org/n/tip-0aaa6frvqnybjc2rjn7xrvjh@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/Makefile.perf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index f9807d8c005b..2ccc12f3730b 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -567,7 +567,7 @@ all: shell_compatibility_test $(ALL_PROGRAMS) $(LANG_BINDINGS) $(OTHER_PROGRAMS)
>  # Create python binding output directory if not already present
>  _dummy := $(shell [ -d '$(OUTPUT)python' ] || mkdir -p '$(OUTPUT)python')
>  
> -$(OUTPUT)python/perf.so: $(PYTHON_EXT_SRCS) $(PYTHON_EXT_DEPS) $(LIBTRACEEVENT_DYNAMIC_LIST)
> +$(OUTPUT)python/perf.so: $(PYTHON_EXT_SRCS) $(PYTHON_EXT_DEPS) $(LIBTRACEEVENT_DYNAMIC_LIST) $(LIBPERF)
>  	$(QUIET_GEN)LDSHARED="$(CC) -pthread -shared" \
>          CFLAGS='$(CFLAGS)' LDFLAGS='$(LDFLAGS) $(LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS)' \
>  	  $(PYTHON_WORD) util/setup.py \
> -- 
> 2.21.0

-- 

- Arnaldo

  reply	other threads:[~2019-09-01 15:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-01 12:48 [PATCH 0/4] perf tools: libperf related fixes Jiri Olsa
2019-09-01 12:48 ` [PATCH 1/4] perf tools: Fix python/perf.so compilation Jiri Olsa
2019-09-01 15:14   ` Arnaldo Carvalho de Melo [this message]
2019-09-20 16:21   ` [tip: perf/urgent] perf python: Add missing python/perf.so dependency for libperf tip-bot2 for Jiri Olsa
2019-09-01 12:48 ` [PATCH 2/4] perf tests: Fix static build test Jiri Olsa
2019-09-01 15:15   ` Arnaldo Carvalho de Melo
2019-09-01 15:46     ` Jiri Olsa
2019-09-01 12:48 ` [PATCH 3/4] perf tests: Add libperf automated test Jiri Olsa
2019-09-01 15:18   ` Arnaldo Carvalho de Melo
2019-09-20 16:21   ` [tip: perf/urgent] perf tests: Add libperf automated test for 'make -C tools/perf build-test' tip-bot2 for Jiri Olsa
2019-09-01 12:48 ` [PATCH 4/4] libperf: Add missing event.h into install rule Jiri Olsa
2019-09-01 15:18   ` Arnaldo Carvalho de Melo
2019-09-20 16:21   ` [tip: perf/urgent] libperf: Add missing event.h file to " tip-bot2 for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190901151431.GL28011@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).