linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Michael Petlan <mpetlan@redhat.com>
Subject: Re: [PATCH 2/4] perf tests: Fix static build test
Date: Sun, 1 Sep 2019 17:46:18 +0200	[thread overview]
Message-ID: <20190901154618.GA10402@krava> (raw)
In-Reply-To: <20190901151528.GM28011@kernel.org>

On Sun, Sep 01, 2019 at 12:15:28PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Sep 01, 2019 at 02:48:20PM +0200, Jiri Olsa escreveu:
> > Link: http://lkml.kernel.org/n/tip-ibdgg163291sx5m5xkojx5sq@git.kernel.org
> 
> 
> Can you explain why this is needed? Wat is the problem with building
> statically with those features? What happens when one tries to do it
> that way?
> 
> I.e. what is this fixing?

sry, I have to disable VDSO and JVMTI for static build,
because they are shared libraries and just won't pass
with -static in LDFLAGS.. I wanted to throw it out,
because I'm confused that the test is passing for you
just like it is right now ;-)

I'll send out version with changelog

jirka

> 
> - Arnaldo
> 
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/perf/tests/make | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> > index 70c48475896d..17ee3facfd4d 100644
> > --- a/tools/perf/tests/make
> > +++ b/tools/perf/tests/make
> > @@ -100,7 +100,7 @@ make_install_info   := install-info
> >  make_install_pdf    := install-pdf
> >  make_install_prefix       := install prefix=/tmp/krava
> >  make_install_prefix_slash := install prefix=/tmp/krava/
> > -make_static         := LDFLAGS=-static
> > +make_static         := LDFLAGS=-static NO_PERF_READ_VDSO32=1 NO_JVMTI=1
> >  
> >  # all the NO_* variable combined
> >  make_minimal        := NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1
> > -- 
> > 2.21.0
> 
> -- 
> 
> - Arnaldo

  reply	other threads:[~2019-09-01 15:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-01 12:48 [PATCH 0/4] perf tools: libperf related fixes Jiri Olsa
2019-09-01 12:48 ` [PATCH 1/4] perf tools: Fix python/perf.so compilation Jiri Olsa
2019-09-01 15:14   ` Arnaldo Carvalho de Melo
2019-09-20 16:21   ` [tip: perf/urgent] perf python: Add missing python/perf.so dependency for libperf tip-bot2 for Jiri Olsa
2019-09-01 12:48 ` [PATCH 2/4] perf tests: Fix static build test Jiri Olsa
2019-09-01 15:15   ` Arnaldo Carvalho de Melo
2019-09-01 15:46     ` Jiri Olsa [this message]
2019-09-01 12:48 ` [PATCH 3/4] perf tests: Add libperf automated test Jiri Olsa
2019-09-01 15:18   ` Arnaldo Carvalho de Melo
2019-09-20 16:21   ` [tip: perf/urgent] perf tests: Add libperf automated test for 'make -C tools/perf build-test' tip-bot2 for Jiri Olsa
2019-09-01 12:48 ` [PATCH 4/4] libperf: Add missing event.h into install rule Jiri Olsa
2019-09-01 15:18   ` Arnaldo Carvalho de Melo
2019-09-20 16:21   ` [tip: perf/urgent] libperf: Add missing event.h file to " tip-bot2 for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190901154618.GA10402@krava \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).